From: Fabio Estevam <festevam@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: s.hauer@pengutronix.de, devicetree@vger.kernel.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
arnd@arndb.de, alistair23@gmail.com, kernel@pengutronix.de,
jernej.skrabec@gmail.com, linux@armlinux.org.uk
Subject: Re: [PATCH v3 3/3] ARM: dts: imx7d-remarkable2: Enable the rohm,bd71815
Date: Sat, 25 Feb 2023 17:37:06 -0300 [thread overview]
Message-ID: <CAOMZO5COg7wZbG3aWcwMsvTBQ9Ft8CQ9wearXMh+00o29CTaeg@mail.gmail.com> (raw)
In-Reply-To: <20230225113712.340612-4-alistair@alistair23.me>
On Sat, Feb 25, 2023 at 8:37 AM Alistair Francis <alistair@alistair23.me> wrote:
> +&i2c2 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + status = "okay";
> +
> + bd71815: pmic@4b {
> + compatible = "rohm,bd71815";
> + reg = <0x4b>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_bd71815>;
> + interrupt-parent = <&gpio6>; /* PMIC_INT_B GPIO6_IO16 */
> + interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> + gpio-controller;
> + clocks = <&clks IMX7D_CLKO2_ROOT_SRC>;
> + clock-output-names = "bd71815-32k-out";
> + #clock-cells = <0>;
> + #gpio-cells = <1>;
The binding document says #gpio-cells = <2>;
> +
> + regulators {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + buck1_reg: regulator@0 {
> + reg = <0>;
The regulator@0 and reg should not be present.
Please check Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: s.hauer@pengutronix.de, devicetree@vger.kernel.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
arnd@arndb.de, alistair23@gmail.com, kernel@pengutronix.de,
jernej.skrabec@gmail.com, linux@armlinux.org.uk
Subject: Re: [PATCH v3 3/3] ARM: dts: imx7d-remarkable2: Enable the rohm,bd71815
Date: Sat, 25 Feb 2023 17:37:06 -0300 [thread overview]
Message-ID: <CAOMZO5COg7wZbG3aWcwMsvTBQ9Ft8CQ9wearXMh+00o29CTaeg@mail.gmail.com> (raw)
In-Reply-To: <20230225113712.340612-4-alistair@alistair23.me>
On Sat, Feb 25, 2023 at 8:37 AM Alistair Francis <alistair@alistair23.me> wrote:
> +&i2c2 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + status = "okay";
> +
> + bd71815: pmic@4b {
> + compatible = "rohm,bd71815";
> + reg = <0x4b>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_bd71815>;
> + interrupt-parent = <&gpio6>; /* PMIC_INT_B GPIO6_IO16 */
> + interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> + gpio-controller;
> + clocks = <&clks IMX7D_CLKO2_ROOT_SRC>;
> + clock-output-names = "bd71815-32k-out";
> + #clock-cells = <0>;
> + #gpio-cells = <1>;
The binding document says #gpio-cells = <2>;
> +
> + regulators {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + buck1_reg: regulator@0 {
> + reg = <0>;
The regulator@0 and reg should not be present.
Please check Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-25 20:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 11:37 [PATCH v3 0/3] imx7d-remarkable2: Enable cyttsp5 and rohm,bd71815 Alistair Francis
2023-02-25 11:37 ` Alistair Francis
2023-02-25 11:37 ` [PATCH v3 1/3] ARM: dts: imx7d-remarkable2: Enable the cyttsp5 Alistair Francis
2023-02-25 11:37 ` Alistair Francis
2023-02-25 11:37 ` [PATCH v3 2/3] ARM: imx_v6_v7_defconfig: Enable rohm,bd71815 Alistair Francis
2023-02-25 11:37 ` Alistair Francis
2023-02-25 11:37 ` [PATCH v3 3/3] ARM: dts: imx7d-remarkable2: Enable the rohm,bd71815 Alistair Francis
2023-02-25 11:37 ` Alistair Francis
2023-02-25 14:22 ` Matti Vaittinen
2023-02-25 14:22 ` Matti Vaittinen
2023-02-26 5:50 ` Alistair Francis
2023-02-26 5:50 ` Alistair Francis
2023-02-25 20:37 ` Fabio Estevam [this message]
2023-02-25 20:37 ` Fabio Estevam
2023-02-26 5:52 ` Alistair Francis
2023-02-26 5:52 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5COg7wZbG3aWcwMsvTBQ9Ft8CQ9wearXMh+00o29CTaeg@mail.gmail.com \
--to=festevam@gmail.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.