From: Sumit Semwal <sumit.semwal@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
Pawel Osciak <pawel@osciak.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Dave Airlie <airlied@linux.ie>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
intel-gfx@lists.freedesktop.org,
LKML <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Linaro MM SIG Mailman List <linaro-mm-sig@lists.linaro.org>,
kgene@kernel.org, Thierry Reding <thierry.reding@gmail.com>,
daniel.vetter@intel.com, linux-tegra@vger.kernel.org,
rmk+kernel@arm.linux.org.uk,
Marek Szyprowski <m.szyprowski@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible
Date: Wed, 28 Jan 2015 17:57:28 +0530 [thread overview]
Message-ID: <CAO_48GF7CQvY4dF4RoXytSkAQPf-AMsO9Co_UvpS4hr4TY_Wig@mail.gmail.com> (raw)
In-Reply-To: <54C8C612.1030701@linaro.org>
On 28 January 2015 at 16:50, Daniel Thompson <daniel.thompson@linaro.org> wrote:
> On 28/01/15 06:00, Sumit Semwal wrote:
<snip>
>> +/**
>> + * helper macro for exporters; zeros and fills in most common values
>> + */
>> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
>> + struct dma_buf_export_info a = {0}; \
>> + exp_info.exp_name = KBUILD_MODNAME
>> +
>
> This risks generating C99 warnings unless used with care (and only once
> per function). Shouldn't this be more like:
>
> #define DEFINE_DMA_BUF_EXPORT_INFO(a) \
> struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
>
Ah! My bad; thanks for catching this, Daniel; I'll send out the
updated patch in a minute!
> Daniel.
>
--
Thanks and regards,
Sumit Semwal
Kernel Team Lead - Linaro Mobile Group
Linaro.org │ Open source software for ARM SoCs
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Semwal <sumit.semwal@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Linaro MM SIG Mailman List <linaro-mm-sig@lists.linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
rmk+kernel@arm.linux.org.uk, Dave Airlie <airlied@linux.ie>,
kgene@kernel.org, daniel.vetter@intel.com,
Thierry Reding <thierry.reding@gmail.com>,
Pawel Osciak <pawel@osciak.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
intel-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible
Date: Wed, 28 Jan 2015 17:57:28 +0530 [thread overview]
Message-ID: <CAO_48GF7CQvY4dF4RoXytSkAQPf-AMsO9Co_UvpS4hr4TY_Wig@mail.gmail.com> (raw)
In-Reply-To: <54C8C612.1030701@linaro.org>
On 28 January 2015 at 16:50, Daniel Thompson <daniel.thompson@linaro.org> wrote:
> On 28/01/15 06:00, Sumit Semwal wrote:
<snip>
>> +/**
>> + * helper macro for exporters; zeros and fills in most common values
>> + */
>> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
>> + struct dma_buf_export_info a = {0}; \
>> + exp_info.exp_name = KBUILD_MODNAME
>> +
>
> This risks generating C99 warnings unless used with care (and only once
> per function). Shouldn't this be more like:
>
> #define DEFINE_DMA_BUF_EXPORT_INFO(a) \
> struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
>
Ah! My bad; thanks for catching this, Daniel; I'll send out the
updated patch in a minute!
> Daniel.
>
--
Thanks and regards,
Sumit Semwal
Kernel Team Lead - Linaro Mobile Group
Linaro.org │ Open source software for ARM SoCs
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Semwal <sumit.semwal@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Linaro MM SIG Mailman List <linaro-mm-sig@lists.linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
rmk+kernel@arm.linux.org.uk, Dave Airlie <airlied@linux.ie>,
kgene@kernel.org, daniel.vetter@intel.com,
Thierry Reding <thierry.reding@gmail.com>,
Pawel Osciak <pawel@osciak.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
intel-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible
Date: Wed, 28 Jan 2015 17:57:28 +0530 [thread overview]
Message-ID: <CAO_48GF7CQvY4dF4RoXytSkAQPf-AMsO9Co_UvpS4hr4TY_Wig@mail.gmail.com> (raw)
In-Reply-To: <54C8C612.1030701@linaro.org>
On 28 January 2015 at 16:50, Daniel Thompson <daniel.thompson@linaro.org> wrote:
> On 28/01/15 06:00, Sumit Semwal wrote:
<snip>
>> +/**
>> + * helper macro for exporters; zeros and fills in most common values
>> + */
>> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
>> + struct dma_buf_export_info a = {0}; \
>> + exp_info.exp_name = KBUILD_MODNAME
>> +
>
> This risks generating C99 warnings unless used with care (and only once
> per function). Shouldn't this be more like:
>
> #define DEFINE_DMA_BUF_EXPORT_INFO(a) \
> struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
>
Ah! My bad; thanks for catching this, Daniel; I'll send out the
updated patch in a minute!
> Daniel.
>
--
Thanks and regards,
Sumit Semwal
Kernel Team Lead - Linaro Mobile Group
Linaro.org │ Open source software for ARM SoCs
WARNING: multiple messages have this Message-ID (diff)
From: sumit.semwal@linaro.org (Sumit Semwal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible
Date: Wed, 28 Jan 2015 17:57:28 +0530 [thread overview]
Message-ID: <CAO_48GF7CQvY4dF4RoXytSkAQPf-AMsO9Co_UvpS4hr4TY_Wig@mail.gmail.com> (raw)
In-Reply-To: <54C8C612.1030701@linaro.org>
On 28 January 2015 at 16:50, Daniel Thompson <daniel.thompson@linaro.org> wrote:
> On 28/01/15 06:00, Sumit Semwal wrote:
<snip>
>> +/**
>> + * helper macro for exporters; zeros and fills in most common values
>> + */
>> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
>> + struct dma_buf_export_info a = {0}; \
>> + exp_info.exp_name = KBUILD_MODNAME
>> +
>
> This risks generating C99 warnings unless used with care (and only once
> per function). Shouldn't this be more like:
>
> #define DEFINE_DMA_BUF_EXPORT_INFO(a) \
> struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
>
Ah! My bad; thanks for catching this, Daniel; I'll send out the
updated patch in a minute!
> Daniel.
>
--
Thanks and regards,
Sumit Semwal
Kernel Team Lead - Linaro Mobile Group
Linaro.org ? Open source software for ARM SoCs
next prev parent reply other threads:[~2015-01-28 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 6:00 [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible Sumit Semwal
2015-01-28 6:00 ` Sumit Semwal
2015-01-28 6:00 ` Sumit Semwal
2015-01-28 11:20 ` Daniel Thompson
2015-01-28 11:20 ` Daniel Thompson
2015-01-28 11:20 ` Daniel Thompson
2015-01-28 12:27 ` Sumit Semwal [this message]
2015-01-28 12:27 ` Sumit Semwal
2015-01-28 12:27 ` Sumit Semwal
2015-01-28 12:27 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO_48GF7CQvY4dF4RoXytSkAQPf-AMsO9Co_UvpS4hr4TY_Wig@mail.gmail.com \
--to=sumit.semwal@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kgene@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@osg.samsung.com \
--cc=pawel@osciak.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.