From: Eric Curtin <ecurtin@redhat.com> To: Nick Alcock <nick.alcock@oracle.com> Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>, Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, Philipp Zabel <p.zabel@pengutronix.de>, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: remove MODULE_LICENSE in non-modules Date: Mon, 20 Feb 2023 05:00:25 +0000 [thread overview] Message-ID: <CAOgh=Fyak7mxqva0qkUtrqBnsBbhMtP+AsHpOz3TNhwp4wPaAQ@mail.gmail.com> (raw) In-Reply-To: <20230217141059.392471-12-nick.alcock@oracle.com> On Fri, 17 Feb 2023 at 14:20, Nick Alcock <nick.alcock@oracle.com> wrote: > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Hector Martin <marcan@marcan.st> > Cc: Sven Peter <sven@svenpeter.dev> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: asahi@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- Reviewed-by: Eric Curtin <ecurtin@redhat.com> Is mise le meas/Regards, Eric Curtin > drivers/soc/apple/apple-pmgr-pwrstate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c b/drivers/soc/apple/apple-pmgr-pwrstate.c > index e1122288409a..2c15474c7b53 100644 > --- a/drivers/soc/apple/apple-pmgr-pwrstate.c > +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c > @@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver = { > > MODULE_AUTHOR("Hector Martin <marcan@marcan.st>"); > MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs"); > -MODULE_LICENSE("GPL v2"); > > module_platform_driver(apple_pmgr_ps_driver); > -- > 2.39.1.268.g9de2f9a303 > >
WARNING: multiple messages have this Message-ID (diff)
From: Eric Curtin <ecurtin@redhat.com> To: Nick Alcock <nick.alcock@oracle.com> Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>, Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, Philipp Zabel <p.zabel@pengutronix.de>, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: remove MODULE_LICENSE in non-modules Date: Mon, 20 Feb 2023 05:00:25 +0000 [thread overview] Message-ID: <CAOgh=Fyak7mxqva0qkUtrqBnsBbhMtP+AsHpOz3TNhwp4wPaAQ@mail.gmail.com> (raw) In-Reply-To: <20230217141059.392471-12-nick.alcock@oracle.com> On Fri, 17 Feb 2023 at 14:20, Nick Alcock <nick.alcock@oracle.com> wrote: > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Hector Martin <marcan@marcan.st> > Cc: Sven Peter <sven@svenpeter.dev> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: asahi@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- Reviewed-by: Eric Curtin <ecurtin@redhat.com> Is mise le meas/Regards, Eric Curtin > drivers/soc/apple/apple-pmgr-pwrstate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c b/drivers/soc/apple/apple-pmgr-pwrstate.c > index e1122288409a..2c15474c7b53 100644 > --- a/drivers/soc/apple/apple-pmgr-pwrstate.c > +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c > @@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver = { > > MODULE_AUTHOR("Hector Martin <marcan@marcan.st>"); > MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs"); > -MODULE_LICENSE("GPL v2"); > > module_platform_driver(apple_pmgr_ps_driver); > -- > 2.39.1.268.g9de2f9a303 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-20 5:01 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-17 14:10 [PATCH 00/24] MODULE_LICENSE removals, second tranche Nick Alcock 2023-02-17 14:10 ` [PATCH 01/24] kbuild, soc: fujitsu: remove MODULE_LICENSE in non-modules Nick Alcock 2023-02-17 14:10 ` [PATCH 02/24] kbuild, PCI: " Nick Alcock 2023-02-17 15:02 ` Bjorn Helgaas 2023-02-17 14:10 ` [PATCH 03/24] kbuild, mfd: altera-sysmgr: " Nick Alcock 2023-02-17 14:10 ` [PATCH 04/24] kbuild, irqchip/al-fic: " Nick Alcock 2023-02-17 14:10 ` [PATCH 05/24] kbuild, cpufreq: amd-pstate: " Nick Alcock 2023-02-23 19:02 ` Rafael J. Wysocki 2023-02-17 14:10 ` [PATCH 06/24] kbuild, binder: " Nick Alcock 2023-02-17 20:18 ` Carlos Llamas 2023-02-17 14:10 ` [PATCH 07/24] kbuild, bus: arm-integrator-lm: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 14:10 ` [PATCH 08/24] kbuild, drivers/perf: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 14:10 ` [PATCH 09/24] kbuild, ARM: tegra: " Nick Alcock 2023-04-05 13:09 ` (subset) " Thierry Reding 2023-02-17 14:10 ` [PATCH 10/24] kbuild, pinctrl: actions: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 14:10 ` [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-19 12:38 ` Sven Peter 2023-02-19 12:38 ` Sven Peter 2023-02-20 5:00 ` Eric Curtin [this message] 2023-02-20 5:00 ` Eric Curtin 2023-02-17 14:10 ` [PATCH 12/24] kbuild, soc: sunxi: sram: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-21 18:24 ` Jernej Škrabec 2023-02-21 18:24 ` Jernej Škrabec 2023-03-14 20:39 ` Jernej Škrabec 2023-03-14 20:39 ` Jernej Škrabec 2023-02-17 14:10 ` [PATCH 13/24] kbuild, clk: bm1880: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 22:43 ` Stephen Boyd 2023-02-17 22:43 ` Stephen Boyd 2023-02-17 14:10 ` [PATCH 14/24] kbuild, firmware: imx: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-03-14 1:35 ` Shawn Guo 2023-03-14 1:35 ` Shawn Guo 2023-03-20 10:36 ` Nick Alcock 2023-03-20 10:36 ` Nick Alcock 2023-03-20 21:42 ` Luis Chamberlain 2023-03-20 21:42 ` Luis Chamberlain 2023-02-17 14:10 ` [PATCH 15/24] kbuild, bus: ixp4xx: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 14:10 ` [PATCH 16/24] kbuild, irqchip/mvebu-pic: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 14:10 ` [PATCH 17/24] kbuild, pinctrl: nuvoton: npcm7xx: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 14:10 ` [PATCH 18/24] kbuild, bus: qcom: " Nick Alcock 2023-02-17 14:10 ` [PATCH 19/24] kbuild, bus: " Nick Alcock 2023-02-17 14:10 ` [PATCH 20/24] kbuild, gpio: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-03-06 9:58 ` Bartosz Golaszewski 2023-03-06 9:58 ` Bartosz Golaszewski 2023-02-17 14:10 ` [PATCH 21/24] kbuild, serial: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-03-09 16:17 ` Greg Kroah-Hartman 2023-03-09 16:17 ` Greg Kroah-Hartman 2023-02-17 14:10 ` [PATCH 22/24] kbuild, dmaengine: s3c24xx: " Nick Alcock 2023-02-17 14:10 ` Nick Alcock 2023-02-17 14:20 ` Krzysztof Kozlowski 2023-02-17 14:20 ` Krzysztof Kozlowski 2023-02-17 14:10 ` [PATCH 23/24] kbuild, EDAC, altera: " Nick Alcock 2023-04-01 11:56 ` Borislav Petkov 2023-02-17 14:10 ` [PATCH 24/24] kbuild, power: reset: keystone-reset: " Nick Alcock 2023-03-27 15:01 ` [PATCH 00/24] MODULE_LICENSE removals, second tranche Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOgh=Fyak7mxqva0qkUtrqBnsBbhMtP+AsHpOz3TNhwp4wPaAQ@mail.gmail.com' \ --to=ecurtin@redhat.com \ --cc=asahi@lists.linux.dev \ --cc=hasegawa-hitomi@fujitsu.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-modules@vger.kernel.org \ --cc=marcan@marcan.st \ --cc=mcgrof@kernel.org \ --cc=nick.alcock@oracle.com \ --cc=p.zabel@pengutronix.de \ --cc=sven@svenpeter.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.