From: Kevin Hilman <khilman@baylibre.com>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Shawn Guo <shawnguo@kernel.org>,
linux-clk@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 2/2] clk: imx7d: Add the IPG root clock
Date: Wed, 25 Jan 2017 21:24:27 -0800 [thread overview]
Message-ID: <CAOi56cUrAyqV3e1zW+UGNRfGaueJr9yH1md3DPJT6vVM_zfpTA@mail.gmail.com> (raw)
In-Reply-To: <1484762037-10737-2-git-send-email-fabio.estevam@nxp.com>
Hi Fabio,
On Wed, Jan 18, 2017 at 9:53 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote:
> Add an entry for the IMX7D_IPG_ROOT clock.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
kernelci.org started detecting boot failures on imx7s-warp in
next-20160124[1], and I bisected it down to this patch, which is in
linux-next as commit dde08302c083.
I verified that reverting that commit on top of next-20160124 gets
imx7s-warp booting again.
Kevin
P.S. Thanks for the donation of the imx7s-warp board, which allows us
to catch these failures early. :)
[1] https://kernelci.org/boot/id/588747e959b514e08213d106/
> ---
> drivers/clk/imx/clk-imx7d.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c
> index ae1d31b..1705f44 100644
> --- a/drivers/clk/imx/clk-imx7d.c
> +++ b/drivers/clk/imx/clk-imx7d.c
> @@ -788,7 +788,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node)
> clks[IMX7D_WRCLK_ROOT_DIV] = imx_clk_divider2("wrclk_post_div", "wrclk_pre_div", base + 0xbd00, 0, 6);
> clks[IMX7D_CLKO1_ROOT_DIV] = imx_clk_divider2("clko1_post_div", "clko1_pre_div", base + 0xbd80, 0, 6);
> clks[IMX7D_CLKO2_ROOT_DIV] = imx_clk_divider2("clko2_post_div", "clko2_pre_div", base + 0xbe00, 0, 6);
> -
> + clks[IMX7D_IPG_ROOT_CLK] = imx_clk_divider2("ipg_root_clk", "ahb_root_clk", base + 0x9080, 0, 2);
> clks[IMX7D_ARM_A7_ROOT_CLK] = imx_clk_gate4("arm_a7_root_clk", "arm_a7_div", base + 0x4000, 0);
> clks[IMX7D_ARM_M4_ROOT_CLK] = imx_clk_gate4("arm_m4_root_clk", "arm_m4_div", base + 0x4010, 0);
> clks[IMX7D_ARM_M0_ROOT_CLK] = imx_clk_gate4("arm_m0_root_clk", "arm_m0_div", base + 0x4020, 0);
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: imx7d: Add the IPG root clock
Date: Wed, 25 Jan 2017 21:24:27 -0800 [thread overview]
Message-ID: <CAOi56cUrAyqV3e1zW+UGNRfGaueJr9yH1md3DPJT6vVM_zfpTA@mail.gmail.com> (raw)
In-Reply-To: <1484762037-10737-2-git-send-email-fabio.estevam@nxp.com>
Hi Fabio,
On Wed, Jan 18, 2017 at 9:53 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote:
> Add an entry for the IMX7D_IPG_ROOT clock.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
kernelci.org started detecting boot failures on imx7s-warp in
next-20160124[1], and I bisected it down to this patch, which is in
linux-next as commit dde08302c083.
I verified that reverting that commit on top of next-20160124 gets
imx7s-warp booting again.
Kevin
P.S. Thanks for the donation of the imx7s-warp board, which allows us
to catch these failures early. :)
[1] https://kernelci.org/boot/id/588747e959b514e08213d106/
> ---
> drivers/clk/imx/clk-imx7d.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c
> index ae1d31b..1705f44 100644
> --- a/drivers/clk/imx/clk-imx7d.c
> +++ b/drivers/clk/imx/clk-imx7d.c
> @@ -788,7 +788,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node)
> clks[IMX7D_WRCLK_ROOT_DIV] = imx_clk_divider2("wrclk_post_div", "wrclk_pre_div", base + 0xbd00, 0, 6);
> clks[IMX7D_CLKO1_ROOT_DIV] = imx_clk_divider2("clko1_post_div", "clko1_pre_div", base + 0xbd80, 0, 6);
> clks[IMX7D_CLKO2_ROOT_DIV] = imx_clk_divider2("clko2_post_div", "clko2_pre_div", base + 0xbe00, 0, 6);
> -
> + clks[IMX7D_IPG_ROOT_CLK] = imx_clk_divider2("ipg_root_clk", "ahb_root_clk", base + 0x9080, 0, 2);
> clks[IMX7D_ARM_A7_ROOT_CLK] = imx_clk_gate4("arm_a7_root_clk", "arm_a7_div", base + 0x4000, 0);
> clks[IMX7D_ARM_M4_ROOT_CLK] = imx_clk_gate4("arm_m4_root_clk", "arm_m4_div", base + 0x4010, 0);
> clks[IMX7D_ARM_M0_ROOT_CLK] = imx_clk_gate4("arm_m0_root_clk", "arm_m0_div", base + 0x4020, 0);
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-01-26 5:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 17:53 [PATCH 1/2] clk: imx7d: Add the OCOTP clock Fabio Estevam
2017-01-18 17:53 ` Fabio Estevam
2017-01-18 17:53 ` [PATCH 2/2] clk: imx7d: Add the IPG root clock Fabio Estevam
2017-01-18 17:53 ` Fabio Estevam
2017-01-21 0:28 ` Stephen Boyd
2017-01-21 0:28 ` Stephen Boyd
2017-01-26 5:24 ` Kevin Hilman [this message]
2017-01-26 5:24 ` Kevin Hilman
2017-01-26 14:50 ` Fabio Estevam
2017-01-26 14:50 ` Fabio Estevam
2017-01-26 23:54 ` Stephen Boyd
2017-01-26 23:54 ` Stephen Boyd
2017-01-21 0:28 ` [PATCH 1/2] clk: imx7d: Add the OCOTP clock Stephen Boyd
2017-01-21 0:28 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOi56cUrAyqV3e1zW+UGNRfGaueJr9yH1md3DPJT6vVM_zfpTA@mail.gmail.com \
--to=khilman@baylibre.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.