From: Vishal Moola <vishal.moola@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-um@lists.infradead.org,
xen-devel@lists.xenproject.org, kvm@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs
Date: Mon, 15 May 2023 12:11:46 -0700 [thread overview]
Message-ID: <CAOzc2pz6y=gRcdfkQVgwRuzWeWf2Nx-UBtKnZBTs2qKJ+r7R0Q@mail.gmail.com> (raw)
In-Reply-To: <c0677d21a4b6caa2e5018af000294a974121d9e8.camel@physik.fu-berlin.de>
On Sat, May 6, 2023 at 4:35 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Vishal!
>
> On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote:
> > Part of the conversions to replace pgtable constructor/destructors with
> > ptdesc equivalents. Also cleans up some spacing issues.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> > arch/sh/include/asm/pgalloc.h | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h
> > index a9e98233c4d4..ce2ba99dbd84 100644
> > --- a/arch/sh/include/asm/pgalloc.h
> > +++ b/arch/sh/include/asm/pgalloc.h
> > @@ -2,6 +2,7 @@
> > #ifndef __ASM_SH_PGALLOC_H
> > #define __ASM_SH_PGALLOC_H
> >
> > +#include <linux/mm.h>
> > #include <asm/page.h>
> >
> > #define __HAVE_ARCH_PMD_ALLOC_ONE
> > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
> > set_pmd(pmd, __pmd((unsigned long)page_address(pte)));
> > }
> >
> > -#define __pte_free_tlb(tlb,pte,addr) \
> > -do { \
> > - pgtable_pte_page_dtor(pte); \
> > - tlb_remove_page((tlb), (pte)); \
> > +#define __pte_free_tlb(tlb, pte, addr) \
> > +do { \
> > + ptdesc_pte_dtor(page_ptdesc(pte)); \
> > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \
> > } while (0)
> >
> > #endif /* __ASM_SH_PGALLOC_H */
>
> Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it seems that
> tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page(pt), so
> I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte)))
> is correct.
>
> Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))?
As of this patchset all implementations of __pte_free_tlb() take in a
struct page. Eventually we'll want it to be tlb_remove_page_ptdesc(tlb, pte),
but for now the cast is necessary here.
WARNING: multiple messages have this Message-ID (diff)
From: Vishal Moola <vishal.moola@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-um@lists.infradead.org,
xen-devel@lists.xenproject.org, kvm@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs
Date: Mon, 15 May 2023 12:11:46 -0700 [thread overview]
Message-ID: <CAOzc2pz6y=gRcdfkQVgwRuzWeWf2Nx-UBtKnZBTs2qKJ+r7R0Q@mail.gmail.com> (raw)
In-Reply-To: <c0677d21a4b6caa2e5018af000294a974121d9e8.camel@physik.fu-berlin.de>
On Sat, May 6, 2023 at 4:35 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Vishal!
>
> On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote:
> > Part of the conversions to replace pgtable constructor/destructors with
> > ptdesc equivalents. Also cleans up some spacing issues.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> > arch/sh/include/asm/pgalloc.h | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h
> > index a9e98233c4d4..ce2ba99dbd84 100644
> > --- a/arch/sh/include/asm/pgalloc.h
> > +++ b/arch/sh/include/asm/pgalloc.h
> > @@ -2,6 +2,7 @@
> > #ifndef __ASM_SH_PGALLOC_H
> > #define __ASM_SH_PGALLOC_H
> >
> > +#include <linux/mm.h>
> > #include <asm/page.h>
> >
> > #define __HAVE_ARCH_PMD_ALLOC_ONE
> > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
> > set_pmd(pmd, __pmd((unsigned long)page_address(pte)));
> > }
> >
> > -#define __pte_free_tlb(tlb,pte,addr) \
> > -do { \
> > - pgtable_pte_page_dtor(pte); \
> > - tlb_remove_page((tlb), (pte)); \
> > +#define __pte_free_tlb(tlb, pte, addr) \
> > +do { \
> > + ptdesc_pte_dtor(page_ptdesc(pte)); \
> > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \
> > } while (0)
> >
> > #endif /* __ASM_SH_PGALLOC_H */
>
> Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it seems that
> tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page(pt), so
> I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte)))
> is correct.
>
> Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))?
As of this patchset all implementations of __pte_free_tlb() take in a
struct page. Eventually we'll want it to be tlb_remove_page_ptdesc(tlb, pte),
but for now the cast is necessary here.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Vishal Moola <vishal.moola@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-um@lists.infradead.org,
xen-devel@lists.xenproject.org, kvm@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs
Date: Mon, 15 May 2023 12:11:46 -0700 [thread overview]
Message-ID: <CAOzc2pz6y=gRcdfkQVgwRuzWeWf2Nx-UBtKnZBTs2qKJ+r7R0Q@mail.gmail.com> (raw)
In-Reply-To: <c0677d21a4b6caa2e5018af000294a974121d9e8.camel@physik.fu-berlin.de>
On Sat, May 6, 2023 at 4:35 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Vishal!
>
> On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote:
> > Part of the conversions to replace pgtable constructor/destructors with
> > ptdesc equivalents. Also cleans up some spacing issues.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> > arch/sh/include/asm/pgalloc.h | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h
> > index a9e98233c4d4..ce2ba99dbd84 100644
> > --- a/arch/sh/include/asm/pgalloc.h
> > +++ b/arch/sh/include/asm/pgalloc.h
> > @@ -2,6 +2,7 @@
> > #ifndef __ASM_SH_PGALLOC_H
> > #define __ASM_SH_PGALLOC_H
> >
> > +#include <linux/mm.h>
> > #include <asm/page.h>
> >
> > #define __HAVE_ARCH_PMD_ALLOC_ONE
> > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
> > set_pmd(pmd, __pmd((unsigned long)page_address(pte)));
> > }
> >
> > -#define __pte_free_tlb(tlb,pte,addr) \
> > -do { \
> > - pgtable_pte_page_dtor(pte); \
> > - tlb_remove_page((tlb), (pte)); \
> > +#define __pte_free_tlb(tlb, pte, addr) \
> > +do { \
> > + ptdesc_pte_dtor(page_ptdesc(pte)); \
> > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \
> > } while (0)
> >
> > #endif /* __ASM_SH_PGALLOC_H */
>
> Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it seems that
> tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page(pt), so
> I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte)))
> is correct.
>
> Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))?
As of this patchset all implementations of __pte_free_tlb() take in a
struct page. Eventually we'll want it to be tlb_remove_page_ptdesc(tlb, pte),
but for now the cast is necessary here.
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
WARNING: multiple messages have this Message-ID (diff)
From: Vishal Moola <vishal.moola@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
kvm@vger.kernel.org, linux-openrisc@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-sh@vger.kernel.org,
linux-um@lists.infradead.org, linux-mips@vger.kernel.org,
linux-csky@vger.kernel.org, linux-mm@kvack.org,
linux-m68k@lists.linux-m68k.org,
Matthew Wilcox <willy@infradead.org>,
loongarch@lists.linux.dev, sparclinux@vger.kernel.org,
xen-devel@lists.xenproject.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs
Date: Mon, 15 May 2023 12:11:46 -0700 [thread overview]
Message-ID: <CAOzc2pz6y=gRcdfkQVgwRuzWeWf2Nx-UBtKnZBTs2qKJ+r7R0Q@mail.gmail.com> (raw)
In-Reply-To: <c0677d21a4b6caa2e5018af000294a974121d9e8.camel@physik.fu-berlin.de>
On Sat, May 6, 2023 at 4:35 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Vishal!
>
> On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote:
> > Part of the conversions to replace pgtable constructor/destructors with
> > ptdesc equivalents. Also cleans up some spacing issues.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> > arch/sh/include/asm/pgalloc.h | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h
> > index a9e98233c4d4..ce2ba99dbd84 100644
> > --- a/arch/sh/include/asm/pgalloc.h
> > +++ b/arch/sh/include/asm/pgalloc.h
> > @@ -2,6 +2,7 @@
> > #ifndef __ASM_SH_PGALLOC_H
> > #define __ASM_SH_PGALLOC_H
> >
> > +#include <linux/mm.h>
> > #include <asm/page.h>
> >
> > #define __HAVE_ARCH_PMD_ALLOC_ONE
> > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
> > set_pmd(pmd, __pmd((unsigned long)page_address(pte)));
> > }
> >
> > -#define __pte_free_tlb(tlb,pte,addr) \
> > -do { \
> > - pgtable_pte_page_dtor(pte); \
> > - tlb_remove_page((tlb), (pte)); \
> > +#define __pte_free_tlb(tlb, pte, addr) \
> > +do { \
> > + ptdesc_pte_dtor(page_ptdesc(pte)); \
> > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \
> > } while (0)
> >
> > #endif /* __ASM_SH_PGALLOC_H */
>
> Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it seems that
> tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page(pt), so
> I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte)))
> is correct.
>
> Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))?
As of this patchset all implementations of __pte_free_tlb() take in a
struct page. Eventually we'll want it to be tlb_remove_page_ptdesc(tlb, pte),
but for now the cast is necessary here.
WARNING: multiple messages have this Message-ID (diff)
From: Vishal Moola <vishal.moola@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-um@lists.infradead.org,
xen-devel@lists.xenproject.org, kvm@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs
Date: Mon, 15 May 2023 12:11:46 -0700 [thread overview]
Message-ID: <CAOzc2pz6y=gRcdfkQVgwRuzWeWf2Nx-UBtKnZBTs2qKJ+r7R0Q@mail.gmail.com> (raw)
In-Reply-To: <c0677d21a4b6caa2e5018af000294a974121d9e8.camel@physik.fu-berlin.de>
On Sat, May 6, 2023 at 4:35 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Vishal!
>
> On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote:
> > Part of the conversions to replace pgtable constructor/destructors with
> > ptdesc equivalents. Also cleans up some spacing issues.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> > arch/sh/include/asm/pgalloc.h | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h
> > index a9e98233c4d4..ce2ba99dbd84 100644
> > --- a/arch/sh/include/asm/pgalloc.h
> > +++ b/arch/sh/include/asm/pgalloc.h
> > @@ -2,6 +2,7 @@
> > #ifndef __ASM_SH_PGALLOC_H
> > #define __ASM_SH_PGALLOC_H
> >
> > +#include <linux/mm.h>
> > #include <asm/page.h>
> >
> > #define __HAVE_ARCH_PMD_ALLOC_ONE
> > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
> > set_pmd(pmd, __pmd((unsigned long)page_address(pte)));
> > }
> >
> > -#define __pte_free_tlb(tlb,pte,addr) \
> > -do { \
> > - pgtable_pte_page_dtor(pte); \
> > - tlb_remove_page((tlb), (pte)); \
> > +#define __pte_free_tlb(tlb, pte, addr) \
> > +do { \
> > + ptdesc_pte_dtor(page_ptdesc(pte)); \
> > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \
> > } while (0)
> >
> > #endif /* __ASM_SH_PGALLOC_H */
>
> Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it seems that
> tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page(pt), so
> I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte)))
> is correct.
>
> Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))?
As of this patchset all implementations of __pte_free_tlb() take in a
struct page. Eventually we'll want it to be tlb_remove_page_ptdesc(tlb, pte),
but for now the cast is necessary here.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vishal Moola <vishal.moola@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs
Date: Mon, 15 May 2023 12:11:46 -0700 [thread overview]
Message-ID: <CAOzc2pz6y=gRcdfkQVgwRuzWeWf2Nx-UBtKnZBTs2qKJ+r7R0Q@mail.gmail.com> (raw)
In-Reply-To: <c0677d21a4b6caa2e5018af000294a974121d9e8.camel@physik.fu-berlin.de>
On Sat, May 6, 2023 at 4:35 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Vishal!
>
> On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote:
> > Part of the conversions to replace pgtable constructor/destructors with
> > ptdesc equivalents. Also cleans up some spacing issues.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> > arch/sh/include/asm/pgalloc.h | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h
> > index a9e98233c4d4..ce2ba99dbd84 100644
> > --- a/arch/sh/include/asm/pgalloc.h
> > +++ b/arch/sh/include/asm/pgalloc.h
> > @@ -2,6 +2,7 @@
> > #ifndef __ASM_SH_PGALLOC_H
> > #define __ASM_SH_PGALLOC_H
> >
> > +#include <linux/mm.h>
> > #include <asm/page.h>
> >
> > #define __HAVE_ARCH_PMD_ALLOC_ONE
> > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
> > set_pmd(pmd, __pmd((unsigned long)page_address(pte)));
> > }
> >
> > -#define __pte_free_tlb(tlb,pte,addr) \
> > -do { \
> > - pgtable_pte_page_dtor(pte); \
> > - tlb_remove_page((tlb), (pte)); \
> > +#define __pte_free_tlb(tlb, pte, addr) \
> > +do { \
> > + ptdesc_pte_dtor(page_ptdesc(pte)); \
> > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \
> > } while (0)
> >
> > #endif /* __ASM_SH_PGALLOC_H */
>
> Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it seems that
> tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page(pt), so
> I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte)))
> is correct.
>
> Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))?
As of this patchset all implementations of __pte_free_tlb() take in a
struct page. Eventually we'll want it to be tlb_remove_page_ptdesc(tlb, pte),
but for now the cast is necessary here.
next prev parent reply other threads:[~2023-05-15 19:11 UTC|newest]
Thread overview: 295+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 19:27 [PATCH v2 00/34] Split ptdesc from struct page Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` [PATCH v2 01/34] mm: Add PAGE_TYPE_OP folio functions Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-25 8:55 ` Mike Rapoport
2023-05-25 8:55 ` Mike Rapoport
2023-05-25 8:55 ` Mike Rapoport
2023-05-25 8:55 ` Mike Rapoport
2023-05-25 8:55 ` Mike Rapoport
2023-05-25 17:00 ` Vishal Moola
2023-05-25 17:00 ` Vishal Moola
2023-05-25 17:00 ` Vishal Moola
2023-05-25 17:00 ` Vishal Moola
2023-05-25 17:00 ` Vishal Moola
2023-05-25 17:00 ` Vishal Moola
2023-05-25 20:20 ` Mike Rapoport
2023-05-25 20:20 ` Mike Rapoport
2023-05-25 20:20 ` Mike Rapoport
2023-05-25 20:20 ` Mike Rapoport
2023-05-25 20:20 ` Mike Rapoport
2023-05-25 20:20 ` Mike Rapoport
2023-05-25 20:38 ` Vishal Moola
2023-05-25 20:38 ` Vishal Moola
2023-05-25 20:38 ` Vishal Moola
2023-05-25 20:38 ` Vishal Moola
2023-05-25 20:38 ` Vishal Moola
2023-05-25 20:57 ` Matthew Wilcox
2023-05-25 20:57 ` Matthew Wilcox
2023-05-25 20:57 ` Matthew Wilcox
2023-05-25 20:57 ` Matthew Wilcox
2023-05-25 20:57 ` Matthew Wilcox
2023-05-01 19:27 ` [PATCH v2 02/34] s390: Use _pt_s390_gaddr for gmap address tracking Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-25 8:58 ` Mike Rapoport
2023-05-25 8:58 ` Mike Rapoport
2023-05-25 8:58 ` Mike Rapoport
2023-05-25 8:58 ` Mike Rapoport
2023-05-25 8:58 ` Mike Rapoport
2023-05-25 17:12 ` Vishal Moola
2023-05-25 17:12 ` Vishal Moola
2023-05-25 17:12 ` Vishal Moola
2023-05-25 17:12 ` Vishal Moola
2023-05-25 17:12 ` Vishal Moola
2023-05-25 17:12 ` Vishal Moola
2023-05-01 19:27 ` [PATCH v2 03/34] s390: Use pt_frag_refcount for pagetables Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` [PATCH v2 04/34] pgtable: Create struct ptdesc Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:27 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 05/34] mm: add utility functions for ptdesc Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-25 9:09 ` Mike Rapoport
2023-05-25 9:09 ` Mike Rapoport
2023-05-25 9:09 ` Mike Rapoport
2023-05-25 9:09 ` Mike Rapoport
2023-05-25 9:09 ` Mike Rapoport
2023-05-25 18:04 ` Vishal Moola
2023-05-25 18:04 ` Vishal Moola
2023-05-25 18:04 ` Vishal Moola
2023-05-25 18:04 ` Vishal Moola
2023-05-25 18:04 ` Vishal Moola
2023-05-25 18:04 ` Vishal Moola
2023-05-25 20:25 ` Mike Rapoport
2023-05-25 20:25 ` Mike Rapoport
2023-05-25 20:25 ` Mike Rapoport
2023-05-25 20:25 ` Mike Rapoport
2023-05-25 20:25 ` Mike Rapoport
2023-05-25 20:25 ` Mike Rapoport
2023-05-25 20:53 ` Vishal Moola
2023-05-25 20:53 ` Vishal Moola
2023-05-25 20:53 ` Vishal Moola
2023-05-25 20:53 ` Vishal Moola
2023-05-25 20:53 ` Vishal Moola
2023-05-27 10:41 ` Mike Rapoport
2023-05-27 10:41 ` Mike Rapoport
2023-05-27 10:41 ` Mike Rapoport
2023-05-27 10:41 ` Mike Rapoport
2023-05-27 10:41 ` Mike Rapoport
2023-05-27 15:09 ` Matthew Wilcox
2023-05-27 15:09 ` Matthew Wilcox
2023-05-27 15:09 ` Matthew Wilcox
2023-05-27 15:09 ` Matthew Wilcox
2023-05-27 15:09 ` Matthew Wilcox
2023-05-28 5:47 ` Mike Rapoport
2023-05-28 5:47 ` Mike Rapoport
2023-05-28 5:47 ` Mike Rapoport
2023-05-28 5:47 ` Mike Rapoport
2023-05-28 5:47 ` Mike Rapoport
2023-05-01 19:28 ` [PATCH v2 06/34] mm: Convert pmd_pgtable_page() to pmd_ptdesc() Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 07/34] mm: Convert ptlock_alloc() to use ptdescs Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 08/34] mm: Convert ptlock_ptr() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 09/34] mm: Convert pmd_ptlock_init() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 10/34] mm: Convert ptlock_init() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 11/34] mm: Convert pmd_ptlock_free() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 12/34] mm: Convert ptlock_free() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 13/34] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-25 9:19 ` Mike Rapoport
2023-05-25 9:19 ` Mike Rapoport
2023-05-25 9:19 ` Mike Rapoport
2023-05-25 9:19 ` Mike Rapoport
2023-05-25 9:19 ` Mike Rapoport
2023-05-25 18:17 ` Vishal Moola
2023-05-25 18:17 ` Vishal Moola
2023-05-25 18:17 ` Vishal Moola
2023-05-25 18:17 ` Vishal Moola
2023-05-25 18:17 ` Vishal Moola
2023-05-25 18:17 ` Vishal Moola
2023-05-01 19:28 ` [PATCH v2 14/34] powerpc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 15/34] x86: " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 16/34] s390: Convert various gmap " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 17/34] s390: Convert various pgalloc " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 18/34] mm: Remove page table members from struct page Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 19/34] pgalloc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 20/34] arm: " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 21/34] arm64: " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-02 1:48 ` kernel test robot
2023-05-02 1:48 ` kernel test robot
2023-05-02 1:48 ` kernel test robot
2023-05-02 1:48 ` kernel test robot
2023-05-02 1:48 ` kernel test robot
2023-05-02 2:21 ` kernel test robot
2023-05-02 2:21 ` kernel test robot
2023-05-02 2:21 ` kernel test robot
2023-05-02 2:21 ` kernel test robot
2023-05-02 2:21 ` kernel test robot
2023-05-01 19:28 ` [PATCH v2 22/34] csky: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 23/34] hexagon: " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 24/34] loongarch: Convert various functions " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 25/34] m68k: " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 26/34] mips: " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 27/34] nios2: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 28/34] openrisc: " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 29/34] riscv: Convert alloc_{pmd, pte}_late() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 20:59 ` Palmer Dabbelt
2023-05-01 20:59 ` Palmer Dabbelt
2023-05-01 20:59 ` Palmer Dabbelt
2023-05-01 20:59 ` Palmer Dabbelt
2023-05-01 20:59 ` Palmer Dabbelt
2023-05-01 20:59 ` Palmer Dabbelt
2023-05-01 19:28 ` [PATCH v2 30/34] sh: Convert pte_free_tlb() " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-06 11:35 ` John Paul Adrian Glaubitz
2023-05-06 11:35 ` John Paul Adrian Glaubitz
2023-05-06 11:35 ` John Paul Adrian Glaubitz
2023-05-06 11:35 ` John Paul Adrian Glaubitz
2023-05-06 11:35 ` John Paul Adrian Glaubitz
2023-05-15 19:11 ` Vishal Moola [this message]
2023-05-15 19:11 ` Vishal Moola
2023-05-15 19:11 ` Vishal Moola
2023-05-15 19:11 ` Vishal Moola
2023-05-15 19:11 ` Vishal Moola
2023-05-15 19:11 ` Vishal Moola
2023-05-01 19:28 ` [PATCH v2 31/34] sparc64: Convert various functions " Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 32/34] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 33/34] um: Convert {pmd, pte}_free_tlb() to use ptdescs Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` [PATCH v2 34/34] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-01 19:28 ` Vishal Moola (Oracle)
2023-05-18 12:12 ` [PATCH v2 00/34] Split ptdesc from struct page Jason Gunthorpe
2023-05-18 12:12 ` Jason Gunthorpe
2023-05-18 12:12 ` Jason Gunthorpe
2023-05-18 12:12 ` Jason Gunthorpe
2023-05-18 12:12 ` Jason Gunthorpe
2023-05-18 12:12 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOzc2pz6y=gRcdfkQVgwRuzWeWf2Nx-UBtKnZBTs2qKJ+r7R0Q@mail.gmail.com' \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.