From: youling 257 <youling257@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
Vladimir Murzin <vladimir.murzin@arm.com>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>, Helge Deller <deller@gmx.de>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k@lists.linux-m68k.org, gregkh@google.com,
linuxppc-dev@lists.ozlabs.org, hch@lst.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Mon, 04 Nov 2019 08:27:20 +0000 [thread overview]
Message-ID: <CAOzgRdYTa-nAa7QV6c2aZs910BACg91vAjcjw4V-Oy8KCZVmmQ@mail.gmail.com> (raw)
In-Reply-To: <s5himo0cbmm.wl-tiwai@suse.de>
This driver https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/usb/gadget/function/f_audio_source.c
2019-11-04 16:02 GMT+08:00, Takashi Iwai <tiwai@suse.de>:
> Exactly which driver is hit? The code path is via hw_support_mmap()
> and it's currently:
>
> static bool hw_support_mmap(struct snd_pcm_substream *substream)
> {
> if (!(substream->runtime->hw.info & SNDRV_PCM_INFO_MMAP))
> return false;
>
> if (substream->ops->mmap ||
> substream->dma_buffer.dev.type != SNDRV_DMA_TYPE_DEV)
> return true;
>
> return dma_can_mmap(substream->dma_buffer.dev.dev);
> }
>
> so at least the driver has already set the SNDRV_DMA_TYPE_DEV
> explicitly (it's non-zero) and some device object, but the device
> object was invalid for dma_can_mmap() call.
>
> This smells more like a driver-side issue, not in the core side.
>
>
> thanks,
>
> Takashi
>
WARNING: multiple messages have this Message-ID (diff)
From: youling 257 <youling257@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
Vladimir Murzin <vladimir.murzin@arm.com>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Helge Deller <deller@gmx.de>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k@lists.linux-m68k.org,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org, hch@lst.de,
gregkh@google.com
Subject: Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Mon, 4 Nov 2019 16:27:20 +0800 [thread overview]
Message-ID: <CAOzgRdYTa-nAa7QV6c2aZs910BACg91vAjcjw4V-Oy8KCZVmmQ@mail.gmail.com> (raw)
In-Reply-To: <s5himo0cbmm.wl-tiwai@suse.de>
This driver https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/usb/gadget/function/f_audio_source.c
2019-11-04 16:02 GMT+08:00, Takashi Iwai <tiwai@suse.de>:
> Exactly which driver is hit? The code path is via hw_support_mmap()
> and it's currently:
>
> static bool hw_support_mmap(struct snd_pcm_substream *substream)
> {
> if (!(substream->runtime->hw.info & SNDRV_PCM_INFO_MMAP))
> return false;
>
> if (substream->ops->mmap ||
> substream->dma_buffer.dev.type != SNDRV_DMA_TYPE_DEV)
> return true;
>
> return dma_can_mmap(substream->dma_buffer.dev.dev);
> }
>
> so at least the driver has already set the SNDRV_DMA_TYPE_DEV
> explicitly (it's non-zero) and some device object, but the device
> object was invalid for dma_can_mmap() call.
>
> This smells more like a driver-side issue, not in the core side.
>
>
> thanks,
>
> Takashi
>
WARNING: multiple messages have this Message-ID (diff)
From: youling 257 <youling257@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
Vladimir Murzin <vladimir.murzin@arm.com>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>, Helge Deller <deller@gmx.de>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k@lists.linux-m68k.org, gregkh@google.com,
linuxppc-dev@lists.ozlabs.org, hch@lst.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Mon, 4 Nov 2019 16:27:20 +0800 [thread overview]
Message-ID: <CAOzgRdYTa-nAa7QV6c2aZs910BACg91vAjcjw4V-Oy8KCZVmmQ@mail.gmail.com> (raw)
In-Reply-To: <s5himo0cbmm.wl-tiwai@suse.de>
This driver https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/usb/gadget/function/f_audio_source.c
2019-11-04 16:02 GMT+08:00, Takashi Iwai <tiwai@suse.de>:
> Exactly which driver is hit? The code path is via hw_support_mmap()
> and it's currently:
>
> static bool hw_support_mmap(struct snd_pcm_substream *substream)
> {
> if (!(substream->runtime->hw.info & SNDRV_PCM_INFO_MMAP))
> return false;
>
> if (substream->ops->mmap ||
> substream->dma_buffer.dev.type != SNDRV_DMA_TYPE_DEV)
> return true;
>
> return dma_can_mmap(substream->dma_buffer.dev.dev);
> }
>
> so at least the driver has already set the SNDRV_DMA_TYPE_DEV
> explicitly (it's non-zero) and some device object, but the device
> object was invalid for dma_can_mmap() call.
>
> This smells more like a driver-side issue, not in the core side.
>
>
> thanks,
>
> Takashi
>
WARNING: multiple messages have this Message-ID (diff)
From: youling 257 <youling257@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
Vladimir Murzin <vladimir.murzin@arm.com>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>, Helge Deller <deller@gmx.de>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k@lists.linux-m68k.org, gregkh@google.com,
linuxppc-dev@lists.ozlabs.org, hch@lst.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Mon, 4 Nov 2019 16:27:20 +0800 [thread overview]
Message-ID: <CAOzgRdYTa-nAa7QV6c2aZs910BACg91vAjcjw4V-Oy8KCZVmmQ@mail.gmail.com> (raw)
In-Reply-To: <s5himo0cbmm.wl-tiwai@suse.de>
This driver https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/usb/gadget/function/f_audio_source.c
2019-11-04 16:02 GMT+08:00, Takashi Iwai <tiwai@suse.de>:
> Exactly which driver is hit? The code path is via hw_support_mmap()
> and it's currently:
>
> static bool hw_support_mmap(struct snd_pcm_substream *substream)
> {
> if (!(substream->runtime->hw.info & SNDRV_PCM_INFO_MMAP))
> return false;
>
> if (substream->ops->mmap ||
> substream->dma_buffer.dev.type != SNDRV_DMA_TYPE_DEV)
> return true;
>
> return dma_can_mmap(substream->dma_buffer.dev.dev);
> }
>
> so at least the driver has already set the SNDRV_DMA_TYPE_DEV
> explicitly (it's non-zero) and some device object, but the device
> object was invalid for dma_can_mmap() call.
>
> This smells more like a driver-side issue, not in the core side.
>
>
> thanks,
>
> Takashi
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-04 8:27 UTC|newest]
Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 7:06 ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* youling 257
2019-11-04 7:06 ` youling 257
2019-11-04 7:06 ` youling 257
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:27 ` youling 257 [this message]
2019-11-04 8:27 ` youling 257
2019-11-04 8:27 ` youling 257
2019-11-04 8:27 ` youling 257
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 9:03 ` Takashi Iwai
2019-11-04 9:03 ` Takashi Iwai
2019-11-04 9:03 ` Takashi Iwai
2019-11-04 9:03 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2019-08-05 9:11 [PATCH 4/7] " Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-05 9:11 remove default fallbacks in dma_map_ops v2 Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 1/7] dma-mapping: move the dma_get_sgtable API comments from arm to common code Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 2/7] dma-mapping: explicitly wire up ->mmap and ->get_sgtable Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 3/7] dma-mapping: add a dma_can_mmap helper Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 5/7] m68knommu: add a pgprot_noncached stub Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 6/7] dma-mapping: remove ARCH_NO_COHERENT_DMA_MMAP Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 7/7] dma-mapping: provide a better default ->get_required_mask Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-08 15:59 ` remove default fallbacks in dma_map_ops v3 Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` [PATCH 1/8] dma-mapping: provide a better default ->get_required_mask Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` [PATCH 2/8] dma-mapping: move the dma_get_sgtable API comments from arm to common code Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 3/8] dma-mapping: explicitly wire up ->mmap and ->get_sgtable Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 4/8] dma-mapping: add a dma_can_mmap helper Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 5/8] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-11-04 7:26 ` youling257
2019-11-04 7:26 ` youling257
2019-11-04 7:26 ` youling257
2019-08-08 16:00 ` [PATCH 6/8] arm-nommu: call dma_mmap_from_dev_coherent directly Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-08 16:00 ` [PATCH 7/8] parisc: don't set ARCH_NO_COHERENT_DMA_MMAP Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 8/8] dma-mapping: remove CONFIG_ARCH_NO_COHERENT_DMA_MMAP Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-29 15:38 ` remove default fallbacks in dma_map_ops v3 Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOzgRdYTa-nAa7QV6c2aZs910BACg91vAjcjw4V-Oy8KCZVmmQ@mail.gmail.com \
--to=youling257@gmail.com \
--cc=deller@gmx.de \
--cc=gregkh@google.com \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=robin.murphy@arm.com \
--cc=tiwai@suse.de \
--cc=vladimir.murzin@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.