From: Tomer Maimon <tmaimon77@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: ulf.hansson@linaro.org, avifishman70@gmail.com,
tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
yuenn@google.com, benjaminfair@google.com,
adrian.hunter@intel.com, skhan@linuxfoundation.org,
davidgow@google.com, pbrobinson@gmail.com, gsomlo@gmail.com,
briannorris@chromium.org, arnd@arndb.de, krakoczy@antmicro.com,
openbmc@lists.ozlabs.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver
Date: Mon, 2 Oct 2023 21:29:40 +0300 [thread overview]
Message-ID: <CAP6Zq1jM3=D5PBp1z7=K6LRNJaZe3rEPutXm_xxo7p2Z60sWmQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vd701sE-pkTWYi=PsOpVoBa-fbOm91P3bGLruCn5U1KXA@mail.gmail.com>
Hi Andy,
Thanks for your comments.
On Mon, 2 Oct 2023 at 21:22, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Mon, Oct 2, 2023 at 8:51 PM Tomer Maimon <tmaimon77@gmail.com> wrote:
> >
> > Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
>
> ...
>
> > +/*
> > + * NPCM SDHC MMC host controller driver.
> > + *
> > + * Copyright (c) 2020 Nuvoton Technology corporation.
>
> Shouldn't it be at least 2020,2023 ?
will change to 2023
>
> > + */
>
> ...
>
> > +#include <linux/clk.h>
> > +#include <linux/err.h>
> > +#include <linux/io.h>
> > +#include <linux/mmc/host.h>
> > +#include <linux/mmc/mmc.h>
>
> + mod_devicetable.h
why?
> > +#include <linux/module.h>
> > +#include <linux/of.h>
>
> ...
>
> > + pltfm_host->clk = devm_clk_get_optional(&pdev->dev, NULL);
> > + if (IS_ERR(pltfm_host->clk)) {
> > + ret = PTR_ERR(pltfm_host->clk);
> > + goto err_sdhci;
> > + }
> > +
> > + ret = clk_prepare_enable(pltfm_host->clk);
> > + if (ret)
> > + goto err_sdhci;
>
> Why not use devm_clk_get_optional_enabled()?
Will do
>
> --
> With Best Regards,
> Andy Shevchenko
Best regards,
Tomer
WARNING: multiple messages have this Message-ID (diff)
From: Tomer Maimon <tmaimon77@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org,
benjaminfair@google.com, arnd@arndb.de, krakoczy@antmicro.com,
avifishman70@gmail.com, venture@google.com,
openbmc@lists.ozlabs.org, briannorris@chromium.org,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
tali.perry1@gmail.com, gsomlo@gmail.com, joel@jms.id.au,
davidgow@google.com, skhan@linuxfoundation.org,
linux-kernel@vger.kernel.org, pbrobinson@gmail.com
Subject: Re: [PATCH v3 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver
Date: Mon, 2 Oct 2023 21:29:40 +0300 [thread overview]
Message-ID: <CAP6Zq1jM3=D5PBp1z7=K6LRNJaZe3rEPutXm_xxo7p2Z60sWmQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vd701sE-pkTWYi=PsOpVoBa-fbOm91P3bGLruCn5U1KXA@mail.gmail.com>
Hi Andy,
Thanks for your comments.
On Mon, 2 Oct 2023 at 21:22, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Mon, Oct 2, 2023 at 8:51 PM Tomer Maimon <tmaimon77@gmail.com> wrote:
> >
> > Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
>
> ...
>
> > +/*
> > + * NPCM SDHC MMC host controller driver.
> > + *
> > + * Copyright (c) 2020 Nuvoton Technology corporation.
>
> Shouldn't it be at least 2020,2023 ?
will change to 2023
>
> > + */
>
> ...
>
> > +#include <linux/clk.h>
> > +#include <linux/err.h>
> > +#include <linux/io.h>
> > +#include <linux/mmc/host.h>
> > +#include <linux/mmc/mmc.h>
>
> + mod_devicetable.h
why?
> > +#include <linux/module.h>
> > +#include <linux/of.h>
>
> ...
>
> > + pltfm_host->clk = devm_clk_get_optional(&pdev->dev, NULL);
> > + if (IS_ERR(pltfm_host->clk)) {
> > + ret = PTR_ERR(pltfm_host->clk);
> > + goto err_sdhci;
> > + }
> > +
> > + ret = clk_prepare_enable(pltfm_host->clk);
> > + if (ret)
> > + goto err_sdhci;
>
> Why not use devm_clk_get_optional_enabled()?
Will do
>
> --
> With Best Regards,
> Andy Shevchenko
Best regards,
Tomer
next prev parent reply other threads:[~2023-10-02 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 17:50 [PATCH v3 0/2] MMC: add NPCM SDHCI driver support Tomer Maimon
2023-10-02 17:50 ` Tomer Maimon
2023-10-02 17:50 ` [PATCH v3 1/2] dt-bindings: mmc: npcm,sdhci: Document NPCM SDHCI controller Tomer Maimon
2023-10-02 17:50 ` Tomer Maimon
2023-10-02 17:50 ` [PATCH v3 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver Tomer Maimon
2023-10-02 17:50 ` Tomer Maimon
2023-10-02 18:21 ` Andy Shevchenko
2023-10-02 18:21 ` Andy Shevchenko
2023-10-02 18:29 ` Tomer Maimon [this message]
2023-10-02 18:29 ` Tomer Maimon
2023-10-02 18:31 ` Andy Shevchenko
2023-10-02 18:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP6Zq1jM3=D5PBp1z7=K6LRNJaZe3rEPutXm_xxo7p2Z60sWmQ@mail.gmail.com' \
--to=tmaimon77@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=briannorris@chromium.org \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gsomlo@gmail.com \
--cc=joel@jms.id.au \
--cc=krakoczy@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pbrobinson@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=tali.perry1@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.