From: Ulf Hansson <ulf.hansson@linaro.org> To: Jerome Brunet <jbrunet@baylibre.com> Cc: Carlo Caione <carlo@caione.org>, Kevin Hilman <khilman@baylibre.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, devicetree@vger.kernel.org, "open list:ARM/Amlogic Meson..." <linux-amlogic@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mmc: meson-gx: add device reset Date: Thu, 26 Apr 2018 15:54:48 +0200 [thread overview] Message-ID: <CAPDyKFooqSGrgKqKxTTRBYbi6s-199GhRNhQvVD0wzWWK3UG=Q@mail.gmail.com> (raw) In-Reply-To: <20180426103817.12675-1-jbrunet@baylibre.com> On 26 April 2018 at 12:38, Jerome Brunet <jbrunet@baylibre.com> wrote: > Trigger the reset line of the mmc controller while probing, if available > The reset should be optional for now, at least until all related DT node > have the reset property > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt | 2 ++ Please move DT doc changes into separate patches. And make the DT maintainers are in to field as well. Otherwise, this looks good to me. Kind regards Uffe > drivers/mmc/host/meson-gx-mmc.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt > index 5add8d7d855f..ba434375e7f2 100644 > --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt > +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt > @@ -20,6 +20,7 @@ Required properties: > "clkin1" - Other parent clock of internal mux > The driver has an internal mux clock which switches between clkin0 and clkin1 depending on the > clock rate requested by the MMC core. > +- reset : phandle of the internal reset line > > Example: > > @@ -30,4 +31,5 @@ Example: > clocks = <&clkc CLKID_SD_EMMC_A>, <&xtal>, <&clkc CLKID_FCLK_DIV2>; > clock-names = "core", "clkin0", "clkin1"; > pinctrl-0 = <&emmc_pins>; > + resets = <&reset RESET_SD_EMMC_A>; > }; > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 55bbd67177df..9d214622c8cf 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -35,6 +35,7 @@ > #include <linux/clk.h> > #include <linux/clk-provider.h> > #include <linux/regulator/consumer.h> > +#include <linux/reset.h> > #include <linux/interrupt.h> > #include <linux/bitfield.h> > #include <linux/pinctrl/consumer.h> > @@ -1212,6 +1213,11 @@ static int meson_mmc_probe(struct platform_device *pdev) > goto free_host; > } > > + ret = device_reset_optional(&pdev->dev); > + if (ret) > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "device reset failed: %d\n", ret); > + > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > host->regs = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(host->regs)) { > -- > 2.14.3 >
WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson) To: linus-amlogic@lists.infradead.org Subject: [PATCH] mmc: meson-gx: add device reset Date: Thu, 26 Apr 2018 15:54:48 +0200 [thread overview] Message-ID: <CAPDyKFooqSGrgKqKxTTRBYbi6s-199GhRNhQvVD0wzWWK3UG=Q@mail.gmail.com> (raw) In-Reply-To: <20180426103817.12675-1-jbrunet@baylibre.com> On 26 April 2018 at 12:38, Jerome Brunet <jbrunet@baylibre.com> wrote: > Trigger the reset line of the mmc controller while probing, if available > The reset should be optional for now, at least until all related DT node > have the reset property > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt | 2 ++ Please move DT doc changes into separate patches. And make the DT maintainers are in to field as well. Otherwise, this looks good to me. Kind regards Uffe > drivers/mmc/host/meson-gx-mmc.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt > index 5add8d7d855f..ba434375e7f2 100644 > --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt > +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx.txt > @@ -20,6 +20,7 @@ Required properties: > "clkin1" - Other parent clock of internal mux > The driver has an internal mux clock which switches between clkin0 and clkin1 depending on the > clock rate requested by the MMC core. > +- reset : phandle of the internal reset line > > Example: > > @@ -30,4 +31,5 @@ Example: > clocks = <&clkc CLKID_SD_EMMC_A>, <&xtal>, <&clkc CLKID_FCLK_DIV2>; > clock-names = "core", "clkin0", "clkin1"; > pinctrl-0 = <&emmc_pins>; > + resets = <&reset RESET_SD_EMMC_A>; > }; > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 55bbd67177df..9d214622c8cf 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -35,6 +35,7 @@ > #include <linux/clk.h> > #include <linux/clk-provider.h> > #include <linux/regulator/consumer.h> > +#include <linux/reset.h> > #include <linux/interrupt.h> > #include <linux/bitfield.h> > #include <linux/pinctrl/consumer.h> > @@ -1212,6 +1213,11 @@ static int meson_mmc_probe(struct platform_device *pdev) > goto free_host; > } > > + ret = device_reset_optional(&pdev->dev); > + if (ret) > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "device reset failed: %d\n", ret); > + > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > host->regs = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(host->regs)) { > -- > 2.14.3 >
next prev parent reply other threads:[~2018-04-26 13:54 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-26 10:38 [PATCH] mmc: meson-gx: add device reset Jerome Brunet 2018-04-26 10:38 ` Jerome Brunet 2018-04-26 13:54 ` Ulf Hansson [this message] 2018-04-26 13:54 ` Ulf Hansson 2018-04-26 23:35 ` Kevin Hilman 2018-04-26 23:35 ` Kevin Hilman 2018-05-01 14:43 ` Rob Herring 2018-05-01 14:43 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPDyKFooqSGrgKqKxTTRBYbi6s-199GhRNhQvVD0wzWWK3UG=Q@mail.gmail.com' \ --to=ulf.hansson@linaro.org \ --cc=carlo@caione.org \ --cc=devicetree@vger.kernel.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.