From: Ulf Hansson <ulf.hansson@linaro.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
od@zcrc.me
Subject: Re: [PATCH 1/2] mmc: jz4740: Code cleanup
Date: Thu, 22 Aug 2019 14:13:11 +0200 [thread overview]
Message-ID: <CAPDyKFowvV=O_3Xg8j9nH7szb91Dd1heUt7nK0acRanZL68zsQ@mail.gmail.com> (raw)
In-Reply-To: <20190810121608.24145-1-paul@crapouillou.net>
On Sat, 10 Aug 2019 at 14:16, Paul Cercueil <paul@crapouillou.net> wrote:
>
> Fix wrong code indentation which made the code hard to read, and fix
> return with value in void function.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/jz4740_mmc.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c
> index ffdbfaadd3f2..59f81e8afcce 100644
> --- a/drivers/mmc/host/jz4740_mmc.c
> +++ b/drivers/mmc/host/jz4740_mmc.c
> @@ -186,9 +186,9 @@ static void jz4740_mmc_write_irq_reg(struct jz4740_mmc_host *host,
> uint32_t val)
> {
> if (host->version >= JZ_MMC_JZ4780)
> - return writel(val, host->base + JZ_REG_MMC_IREG);
> + writel(val, host->base + JZ_REG_MMC_IREG);
> else
> - return writew(val, host->base + JZ_REG_MMC_IREG);
> + writew(val, host->base + JZ_REG_MMC_IREG);
> }
>
> static uint32_t jz4740_mmc_read_irq_reg(struct jz4740_mmc_host *host)
> @@ -820,14 +820,14 @@ static irqreturn_t jz_mmc_irq(int irq, void *devid)
> del_timer(&host->timeout_timer);
>
> if (status & JZ_MMC_STATUS_TIMEOUT_RES) {
> - cmd->error = -ETIMEDOUT;
> + cmd->error = -ETIMEDOUT;
> } else if (status & JZ_MMC_STATUS_CRC_RES_ERR) {
> - cmd->error = -EIO;
> + cmd->error = -EIO;
> } else if (status & (JZ_MMC_STATUS_CRC_READ_ERROR |
> JZ_MMC_STATUS_CRC_WRITE_ERROR)) {
> - if (cmd->data)
> - cmd->data->error = -EIO;
> - cmd->error = -EIO;
> + if (cmd->data)
> + cmd->data->error = -EIO;
> + cmd->error = -EIO;
> }
>
> jz4740_mmc_set_irq_enabled(host, irq_reg, false);
> --
> 2.21.0.593.g511ec345e18
>
prev parent reply other threads:[~2019-08-22 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 12:16 [PATCH 1/2] mmc: jz4740: Code cleanup Paul Cercueil
2019-08-10 12:16 ` [PATCH 2/2] mmc: jz4740: Drop dependency on arch header Paul Cercueil
2019-08-22 12:13 ` Ulf Hansson
2019-08-22 12:13 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFowvV=O_3Xg8j9nH7szb91Dd1heUt7nK0acRanZL68zsQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.