From: Ulf Hansson <ulf.hansson@linaro.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
od@zcrc.me
Subject: Re: [PATCH 2/2] mmc: jz4740: Drop dependency on arch header
Date: Thu, 22 Aug 2019 14:13:15 +0200 [thread overview]
Message-ID: <CAPDyKFqMmCcsJi9r9j24wW9gOPsYr+t5TrryqpJ3=EH0ANwi9A@mail.gmail.com> (raw)
In-Reply-To: <20190810121608.24145-2-paul@crapouillou.net>
On Sat, 10 Aug 2019 at 14:16, Paul Cercueil <paul@crapouillou.net> wrote:
>
> We don't need to set the 'slave_id' anymore - that field is never read
> by the DMA driver.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/jz4740_mmc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c
> index 59f81e8afcce..7ff2034d739a 100644
> --- a/drivers/mmc/host/jz4740_mmc.c
> +++ b/drivers/mmc/host/jz4740_mmc.c
> @@ -25,8 +25,6 @@
>
> #include <asm/cacheflush.h>
>
> -#include <asm/mach-jz4740/dma.h>
> -
> #define JZ_REG_MMC_STRPCL 0x00
> #define JZ_REG_MMC_STATUS 0x04
> #define JZ_REG_MMC_CLKRT 0x08
> @@ -292,11 +290,9 @@ static int jz4740_mmc_start_dma_transfer(struct jz4740_mmc_host *host,
> if (data->flags & MMC_DATA_WRITE) {
> conf.direction = DMA_MEM_TO_DEV;
> conf.dst_addr = host->mem_res->start + JZ_REG_MMC_TXFIFO;
> - conf.slave_id = JZ4740_DMA_TYPE_MMC_TRANSMIT;
> } else {
> conf.direction = DMA_DEV_TO_MEM;
> conf.src_addr = host->mem_res->start + JZ_REG_MMC_RXFIFO;
> - conf.slave_id = JZ4740_DMA_TYPE_MMC_RECEIVE;
> }
>
> sg_count = jz4740_mmc_prepare_dma_data(host, data, COOKIE_MAPPED);
> --
> 2.21.0.593.g511ec345e18
>
next prev parent reply other threads:[~2019-08-22 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 12:16 [PATCH 1/2] mmc: jz4740: Code cleanup Paul Cercueil
2019-08-10 12:16 ` [PATCH 2/2] mmc: jz4740: Drop dependency on arch header Paul Cercueil
2019-08-22 12:13 ` Ulf Hansson [this message]
2019-08-22 12:13 ` [PATCH 1/2] mmc: jz4740: Code cleanup Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqMmCcsJi9r9j24wW9gOPsYr+t5TrryqpJ3=EH0ANwi9A@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.