From: Ulf Hansson <ulf.hansson@linaro.org>
To: Chris Brandt <Chris.Brandt@renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Simon Horman <horms+renesas@verge.net.au>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option
Date: Sat, 17 Sep 2016 11:12:13 +0200 [thread overview]
Message-ID: <CAPDyKFqBToUrSbErWrc+zV-WX29Dj5dm+XzWMCfBgOiEtoG8Jg@mail.gmail.com> (raw)
In-Reply-To: <SG2PR06MB11655A641475D2E08A5A3DDC8AFE0@SG2PR06MB1165.apcprd06.prod.outlook.com>
On 13 September 2016 at 17:59, Chris Brandt <Chris.Brandt@renesas.com> wrote:
> Hello Uffe
>
> Thank you for your reply.
>
> On 9/13/2016, Ulf Hansson wrote:
>> Because, if you have an external regulator feeding the mmc with power you
>> should set it up and use it.
>
> But in many board designs, there is no control over the regulator supply (or you would rather have your bootloader do that, not the kernel).
>
> So what this patch is doing is setting it to a default of 3.3v (for just this SoC) and if someone wants to add a regulator in the board's DT file, that will override the ocr_mask set by the driver.
That's perfectly okay to me! I just wanted to get clear picture of
*why* this change was needed.
>
>
> I'm assuming I'll have to do the same for MMC (sh_mmcif.c) once I get to that driver (I need to find my MMC PLUS card first for testing).
Okay!
Kind regards
Uffe
next prev parent reply other threads:[~2016-09-17 9:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 14:15 [PATCH v3 0/3] mmc: sh_mobile_sdhi: Add r7s72100 support Chris Brandt
2016-09-12 14:15 ` [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option Chris Brandt
2016-09-13 12:57 ` Ulf Hansson
2016-09-13 13:26 ` Geert Uytterhoeven
2016-09-13 13:50 ` Chris Brandt
2016-09-13 15:10 ` Ulf Hansson
2016-09-13 15:59 ` Chris Brandt
2016-09-17 9:12 ` Ulf Hansson [this message]
2016-09-17 13:38 ` Chris Brandt
2016-09-13 13:28 ` Chris Brandt
2016-10-20 13:05 ` Wolfram Sang
2016-09-12 14:15 ` [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port Chris Brandt
2016-09-22 8:13 ` Ulf Hansson
2016-10-14 13:18 ` Chris Brandt
2016-10-17 13:36 ` Ulf Hansson
2016-10-17 15:15 ` Wolfram Sang
2016-10-20 13:28 ` Wolfram Sang
2016-10-20 14:35 ` Chris Brandt
2016-10-20 23:12 ` Wolfram Sang
2016-10-21 13:43 ` Chris Brandt
2016-10-21 21:56 ` Wolfram Sang
2016-10-24 11:06 ` Geert Uytterhoeven
2016-10-24 11:11 ` Wolfram Sang
2016-10-24 12:37 ` Chris Brandt
2016-10-20 19:46 ` Chris Brandt
2016-10-20 23:04 ` Wolfram Sang
2016-11-01 8:49 ` Wolfram Sang
2016-11-01 13:40 ` Chris Brandt
2016-11-01 15:07 ` Wolfram Sang
2016-11-01 15:13 ` Chris Brandt
2016-09-12 14:15 ` [PATCH v3 3/3] mmc: sh_mobile_sdhi: Add r7s72100 support Chris Brandt
2016-11-01 8:49 ` Wolfram Sang
2016-10-14 13:14 ` [PATCH v3 0/3] " Chris Brandt
2016-11-07 18:38 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqBToUrSbErWrc+zV-WX29Dj5dm+XzWMCfBgOiEtoG8Jg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=Chris.Brandt@renesas.com \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.