From: Chris Brandt <Chris.Brandt@renesas.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms+renesas@verge.net.au>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port
Date: Thu, 20 Oct 2016 19:46:22 +0000 [thread overview]
Message-ID: <SG2PR06MB1165B756B67D1D101E91A7B38AD50@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: 20161020132852.GB4177@katana
Hello Wolfram,
> > > + /* if count was multiple of 4 */
> > > + if (!(count & 0x3))
> > > + return;
> > > + buf8 = (u8 *)(buf + (count >> 2));
> > > + count %= 4;
> >
> > To skip the same operation done on 'count' twice, maybe?
> >
> > buf8 = (u8 *)(buf + (count >> 2));
> > count &= 3;
> >
> > if (!count)
> > return;
>
>
> That looks like it should work.
> I can try it out and see if there is something we are missing.
Seems to work fine. Although I admit that because the driver is mostly being used as a block device (SD card), all the data requests are an even multiple of 4 (I put a printk after "if (!count) return;" ). Not sure if that will be the case when I test SDIO devices, but I'll find out once I start porting SDIO device drivers to 4.9+.
I'll submit a v4 of this patch series tomorrow.
Thank you.
Chris
next prev parent reply other threads:[~2016-10-20 19:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 14:15 [PATCH v3 0/3] mmc: sh_mobile_sdhi: Add r7s72100 support Chris Brandt
2016-09-12 14:15 ` [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option Chris Brandt
2016-09-13 12:57 ` Ulf Hansson
2016-09-13 13:26 ` Geert Uytterhoeven
2016-09-13 13:50 ` Chris Brandt
2016-09-13 15:10 ` Ulf Hansson
2016-09-13 15:59 ` Chris Brandt
2016-09-17 9:12 ` Ulf Hansson
2016-09-17 13:38 ` Chris Brandt
2016-09-13 13:28 ` Chris Brandt
2016-10-20 13:05 ` Wolfram Sang
2016-09-12 14:15 ` [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port Chris Brandt
2016-09-22 8:13 ` Ulf Hansson
2016-10-14 13:18 ` Chris Brandt
2016-10-17 13:36 ` Ulf Hansson
2016-10-17 15:15 ` Wolfram Sang
2016-10-20 13:28 ` Wolfram Sang
2016-10-20 14:35 ` Chris Brandt
2016-10-20 23:12 ` Wolfram Sang
2016-10-21 13:43 ` Chris Brandt
2016-10-21 21:56 ` Wolfram Sang
2016-10-24 11:06 ` Geert Uytterhoeven
2016-10-24 11:11 ` Wolfram Sang
2016-10-24 12:37 ` Chris Brandt
2016-10-20 19:46 ` Chris Brandt [this message]
2016-10-20 23:04 ` Wolfram Sang
2016-11-01 8:49 ` Wolfram Sang
2016-11-01 13:40 ` Chris Brandt
2016-11-01 15:07 ` Wolfram Sang
2016-11-01 15:13 ` Chris Brandt
2016-09-12 14:15 ` [PATCH v3 3/3] mmc: sh_mobile_sdhi: Add r7s72100 support Chris Brandt
2016-11-01 8:49 ` Wolfram Sang
2016-10-14 13:14 ` [PATCH v3 0/3] " Chris Brandt
2016-11-07 18:38 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SG2PR06MB1165B756B67D1D101E91A7B38AD50@SG2PR06MB1165.apcprd06.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.