From: Ulf Hansson <ulf.hansson@linaro.org>
To: rashmi.a@intel.com, Kishon <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-phy@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [“PATCH” 2/2] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP
Date: Tue, 8 Jun 2021 14:52:33 +0200 [thread overview]
Message-ID: <CAPDyKFr-vuP_bdG-iFjJyS3ZeVDiVq+3aVERHjBo-8BHf38m9g@mail.gmail.com> (raw)
In-Reply-To: <20210603182242.25733-3-rashmi.a@intel.com>
On Thu, 3 Jun 2021 at 20:22, <rashmi.a@intel.com> wrote:
>
> From: Rashmi A <rashmi.a@intel.com>
>
> Since the EMMC clock was changed from 200Mhz to 175Mhz in FIP,
> there were some warnings introduced, as the frequency values
> being checked was still wrt 200Mhz in code. Hence, the frequency
> checks are now updated based on the current 175Mhz EMMC clock changed
> in FIP.
>
> Spamming kernel log msg:
> "phy phy-20290000.mmc_phy.2: Unsupported rate: 43750000"
>
> Signed-off-by: Rashmi A <rashmi.a@intel.com>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
I guess $subject patch should be queued together with patch1/2 (via
the mmc tree?), no?
Vinod, Kishion, if that's okay I need an ack from you to pick it up.
Kind regards
Uffe
> ---
> drivers/phy/intel/phy-intel-keembay-emmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/intel/phy-intel-keembay-emmc.c b/drivers/phy/intel/phy-intel-keembay-emmc.c
> index eb7c635ed89a..0eb11ac7c2e2 100644
> --- a/drivers/phy/intel/phy-intel-keembay-emmc.c
> +++ b/drivers/phy/intel/phy-intel-keembay-emmc.c
> @@ -95,7 +95,8 @@ static int keembay_emmc_phy_power(struct phy *phy, bool on_off)
> else
> freqsel = 0x0;
>
> - if (mhz < 50 || mhz > 200)
> + /* Check for EMMC clock rate*/
> + if (mhz > 175)
> dev_warn(&phy->dev, "Unsupported rate: %d MHz\n", mhz);
>
> /*
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: rashmi.a@intel.com, Kishon <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-phy@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [“PATCH” 2/2] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP
Date: Tue, 8 Jun 2021 14:52:33 +0200 [thread overview]
Message-ID: <CAPDyKFr-vuP_bdG-iFjJyS3ZeVDiVq+3aVERHjBo-8BHf38m9g@mail.gmail.com> (raw)
In-Reply-To: <20210603182242.25733-3-rashmi.a@intel.com>
On Thu, 3 Jun 2021 at 20:22, <rashmi.a@intel.com> wrote:
>
> From: Rashmi A <rashmi.a@intel.com>
>
> Since the EMMC clock was changed from 200Mhz to 175Mhz in FIP,
> there were some warnings introduced, as the frequency values
> being checked was still wrt 200Mhz in code. Hence, the frequency
> checks are now updated based on the current 175Mhz EMMC clock changed
> in FIP.
>
> Spamming kernel log msg:
> "phy phy-20290000.mmc_phy.2: Unsupported rate: 43750000"
>
> Signed-off-by: Rashmi A <rashmi.a@intel.com>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
I guess $subject patch should be queued together with patch1/2 (via
the mmc tree?), no?
Vinod, Kishion, if that's okay I need an ack from you to pick it up.
Kind regards
Uffe
> ---
> drivers/phy/intel/phy-intel-keembay-emmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/intel/phy-intel-keembay-emmc.c b/drivers/phy/intel/phy-intel-keembay-emmc.c
> index eb7c635ed89a..0eb11ac7c2e2 100644
> --- a/drivers/phy/intel/phy-intel-keembay-emmc.c
> +++ b/drivers/phy/intel/phy-intel-keembay-emmc.c
> @@ -95,7 +95,8 @@ static int keembay_emmc_phy_power(struct phy *phy, bool on_off)
> else
> freqsel = 0x0;
>
> - if (mhz < 50 || mhz > 200)
> + /* Check for EMMC clock rate*/
> + if (mhz > 175)
> dev_warn(&phy->dev, "Unsupported rate: %d MHz\n", mhz);
>
> /*
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: rashmi.a@intel.com, Kishon <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-phy@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [“PATCH” 2/2] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP
Date: Tue, 8 Jun 2021 14:52:33 +0200 [thread overview]
Message-ID: <CAPDyKFr-vuP_bdG-iFjJyS3ZeVDiVq+3aVERHjBo-8BHf38m9g@mail.gmail.com> (raw)
In-Reply-To: <20210603182242.25733-3-rashmi.a@intel.com>
On Thu, 3 Jun 2021 at 20:22, <rashmi.a@intel.com> wrote:
>
> From: Rashmi A <rashmi.a@intel.com>
>
> Since the EMMC clock was changed from 200Mhz to 175Mhz in FIP,
> there were some warnings introduced, as the frequency values
> being checked was still wrt 200Mhz in code. Hence, the frequency
> checks are now updated based on the current 175Mhz EMMC clock changed
> in FIP.
>
> Spamming kernel log msg:
> "phy phy-20290000.mmc_phy.2: Unsupported rate: 43750000"
>
> Signed-off-by: Rashmi A <rashmi.a@intel.com>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
I guess $subject patch should be queued together with patch1/2 (via
the mmc tree?), no?
Vinod, Kishion, if that's okay I need an ack from you to pick it up.
Kind regards
Uffe
> ---
> drivers/phy/intel/phy-intel-keembay-emmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/intel/phy-intel-keembay-emmc.c b/drivers/phy/intel/phy-intel-keembay-emmc.c
> index eb7c635ed89a..0eb11ac7c2e2 100644
> --- a/drivers/phy/intel/phy-intel-keembay-emmc.c
> +++ b/drivers/phy/intel/phy-intel-keembay-emmc.c
> @@ -95,7 +95,8 @@ static int keembay_emmc_phy_power(struct phy *phy, bool on_off)
> else
> freqsel = 0x0;
>
> - if (mhz < 50 || mhz > 200)
> + /* Check for EMMC clock rate*/
> + if (mhz > 175)
> dev_warn(&phy->dev, "Unsupported rate: %d MHz\n", mhz);
>
> /*
> --
> 2.17.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-06-08 12:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 18:22 [“PATCH” 0/2] [KMB] mmc clock-frequency property update and rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` [“PATCH” 1/2] mmc: sdhci-of-arasan: Use clock-frequency property to update clk_xin rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-04 6:13 ` Michal Simek
2021-06-04 6:13 ` Michal Simek
2021-06-04 6:13 ` Michal Simek
2021-06-17 10:04 ` Ulf Hansson
2021-06-17 10:04 ` Ulf Hansson
2021-06-17 10:18 ` Sai Krishna Potthuri
2021-06-17 10:18 ` Sai Krishna Potthuri
2021-06-17 10:18 ` Sai Krishna Potthuri
2021-06-03 18:22 ` [“PATCH” 2/2] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-08 12:52 ` Ulf Hansson [this message]
2021-06-08 12:52 ` Ulf Hansson
2021-06-08 12:52 ` Ulf Hansson
2021-06-09 3:40 ` Vinod Koul
2021-06-09 3:40 ` Vinod Koul
2021-06-09 3:40 ` Vinod Koul
2021-06-29 15:08 ` [“PATCH” 0/2] [KMB] mmc clock-frequency property update and Ulf Hansson
2021-06-29 15:08 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFr-vuP_bdG-iFjJyS3ZeVDiVq+3aVERHjBo-8BHf38m9g@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=rashmi.a@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.