From: Ulf Hansson <ulf.hansson@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Tony Lindgren <tony@atomide.com>, "Reizer, Eyal" <eyalr@ti.com>,
KISHON VIJAY ABRAHAM <kishon@ti.com>, "Mishol, Guy" <guym@ti.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Ricardo Salveti <rsalveti@rsalveti.net>
Subject: Re: [EXTERNAL] Re: [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly
Date: Mon, 14 Jan 2019 14:47:31 +0100 [thread overview]
Message-ID: <CAPDyKFrYk87AwpHd5B06quGQAtfPYRHMD-9-2WzR=7Y=5Oog2A@mail.gmail.com> (raw)
In-Reply-To: <87k1jgsaze.fsf@kamboji.qca.qualcomm.com>
On Mon, 7 Jan 2019 at 17:12, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Tony Lindgren <tony@atomide.com> writes:
>
> > * Ulf Hansson <ulf.hansson@linaro.org> [190102 12:02]:
> >>
> >> However, if this is about an out-of-band IRQ line, instead of using
> >> the SDIO IRQs on DAT1, I think management of that, belongs in the wlan
> >> (or gpiochip) layers.
> >
> > Yes this can be handled at the gpiochip layer.
> >
> >> We have to distinguish if "down" has a strict requirement to power off
> >> the wlan-chip.
> >>
> >> For example, in "flight mode", is it okay to leave the wlan chip
> >> powered on and thus potentially also having its radio part active?
> >
> > I don't know. If unsure, we should at least have that possibility
> > available for future versions if needed. It might also help a bit
> > with PM measurements :)
>
> I don't know if there are any written rules but I have preferred that in
> wireless drivers "ifconfig down" means that all power is turned off on
> the device, at least this way user space can achive maximum power
> savings. And there's also a simple way to start the firmware from clean
> state, we all know how buggy firmwares are so I think that's important
> as well.
Alright, I buy this! I am going to have a look to see how we can
accomplish this in the best way, but I need some more time before I
can post something.
In the meantime, let's go with Tony's suggestion to fix the
regression. I am about to post a patch.
Kind regards
Uffe
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Reizer, Eyal" <eyalr-l0cyMroinI0@public.gmane.org>,
KISHON VIJAY ABRAHAM <kishon-l0cyMroinI0@public.gmane.org>,
"Mishol, Guy" <guym-l0cyMroinI0@public.gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Anders Roxell
<anders.roxell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Ricardo Salveti
<rsalveti-3fX5ma9fJBTk1uMJSBkQmQ@public.gmane.org>
Subject: Re: [EXTERNAL] Re: [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly
Date: Mon, 14 Jan 2019 14:47:31 +0100 [thread overview]
Message-ID: <CAPDyKFrYk87AwpHd5B06quGQAtfPYRHMD-9-2WzR=7Y=5Oog2A@mail.gmail.com> (raw)
In-Reply-To: <87k1jgsaze.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
On Mon, 7 Jan 2019 at 17:12, Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
>
> Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> writes:
>
> > * Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> [190102 12:02]:
> >>
> >> However, if this is about an out-of-band IRQ line, instead of using
> >> the SDIO IRQs on DAT1, I think management of that, belongs in the wlan
> >> (or gpiochip) layers.
> >
> > Yes this can be handled at the gpiochip layer.
> >
> >> We have to distinguish if "down" has a strict requirement to power off
> >> the wlan-chip.
> >>
> >> For example, in "flight mode", is it okay to leave the wlan chip
> >> powered on and thus potentially also having its radio part active?
> >
> > I don't know. If unsure, we should at least have that possibility
> > available for future versions if needed. It might also help a bit
> > with PM measurements :)
>
> I don't know if there are any written rules but I have preferred that in
> wireless drivers "ifconfig down" means that all power is turned off on
> the device, at least this way user space can achive maximum power
> savings. And there's also a simple way to start the firmware from clean
> state, we all know how buggy firmwares are so I think that's important
> as well.
Alright, I buy this! I am going to have a look to see how we can
accomplish this in the best way, but I need some more time before I
can post something.
In the meantime, let's go with Tony's suggestion to fix the
regression. I am about to post a patch.
Kind regards
Uffe
next prev parent reply other threads:[~2019-01-14 13:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 16:42 [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly Tony Lindgren
2018-12-17 16:42 ` Tony Lindgren
2018-12-18 1:06 ` Ricardo Salveti
2018-12-18 1:06 ` Ricardo Salveti
2018-12-18 12:34 ` Ulf Hansson
2018-12-18 12:34 ` Ulf Hansson
2018-12-18 15:54 ` Tony Lindgren
2018-12-18 15:54 ` Tony Lindgren
2018-12-20 10:14 ` Ulf Hansson
2018-12-20 10:14 ` Ulf Hansson
2018-12-20 23:14 ` Tony Lindgren
2018-12-20 23:14 ` Tony Lindgren
2018-12-23 7:38 ` [EXTERNAL] " Reizer, Eyal
2018-12-23 7:38 ` Reizer, Eyal
2018-12-23 16:02 ` Tony Lindgren
2018-12-23 16:02 ` Tony Lindgren
2018-12-28 11:01 ` Ulf Hansson
2018-12-28 11:01 ` Ulf Hansson
2018-12-28 19:59 ` Tony Lindgren
2018-12-28 19:59 ` Tony Lindgren
2019-01-02 12:01 ` Ulf Hansson
2019-01-02 12:01 ` Ulf Hansson
2019-01-07 15:18 ` Tony Lindgren
2019-01-07 15:18 ` Tony Lindgren
2019-01-07 16:12 ` Kalle Valo
2019-01-07 16:12 ` Kalle Valo
2019-01-14 13:47 ` Ulf Hansson [this message]
2019-01-14 13:47 ` Ulf Hansson
2018-12-28 9:48 ` Ulf Hansson
2018-12-28 9:48 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFrYk87AwpHd5B06quGQAtfPYRHMD-9-2WzR=7Y=5Oog2A@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=anders.roxell@linaro.org \
--cc=eyalr@ti.com \
--cc=guym@ti.com \
--cc=john.stultz@linaro.org \
--cc=kishon@ti.com \
--cc=kvalo@codeaurora.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalveti@rsalveti.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.