From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 5/5] spi: make remove callback a void function
Date: Thu, 27 Jan 2022 12:39:22 +0100 [thread overview]
Message-ID: <CAPDyKFrZQ0JUjNt_bcxLXVGZ6NtLdUktN7v_4fj--ntoO26TPg@mail.gmail.com> (raw)
In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de>
- To avoid spamming lists/people, I have dropped most of them from the
to/cc list
On Sun, 23 Jan 2022 at 18:54, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # For MMC
[...]
Kind regards
Uffe
next prev parent reply other threads:[~2022-01-27 11:40 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 17:51 [PATCH 0/5] spi: make remove callback a void function Uwe Kleine-König
2022-01-23 17:51 ` Uwe Kleine-König
2022-01-23 17:51 ` Uwe Kleine-König
2022-01-23 17:51 ` [PATCH 1/5] staging: fbtft: Fix error path in fbtft_driver_module_init() Uwe Kleine-König
2022-01-23 17:51 ` Uwe Kleine-König
2022-01-23 17:51 ` [PATCH 2/5] staging: fbtft: Deduplicate driver registration macros Uwe Kleine-König
2022-01-23 17:51 ` Uwe Kleine-König
2022-01-27 21:36 ` Uwe Kleine-König
2022-01-27 21:36 ` Uwe Kleine-König
2022-01-28 7:16 ` Greg Kroah-Hartman
2022-01-28 7:16 ` Greg Kroah-Hartman
2022-01-23 17:51 ` [PATCH 3/5] tpm: st33zp24: Make st33zp24_remove() a void function Uwe Kleine-König
2022-01-23 17:52 ` [PATCH 4/5] platform/chrome: cros_ec: Make cros_ec_unregister() return void Uwe Kleine-König
2022-01-23 17:52 ` [PATCH 5/5] spi: make remove callback a void function Uwe Kleine-König
2022-01-23 17:52 ` Uwe Kleine-König
2022-01-23 17:52 ` Uwe Kleine-König
2022-01-23 22:49 ` Marc Kleine-Budde
2022-01-24 12:23 ` Andy Shevchenko
2022-01-24 12:23 ` Andy Shevchenko
2022-01-24 12:23 ` Andy Shevchenko
2022-01-24 12:23 ` Andy Shevchenko
2022-01-25 9:35 ` Alexandre Belloni
2022-01-25 9:35 ` Alexandre Belloni
2022-01-25 9:35 ` Alexandre Belloni
2022-01-25 9:35 ` Alexandre Belloni
2022-01-25 9:44 ` Stefan Schmidt
2022-01-25 9:44 ` Stefan Schmidt
2022-01-25 9:44 ` Stefan Schmidt
2022-01-25 9:44 ` Stefan Schmidt
2022-01-25 9:47 ` Jonathan Cameron
2022-01-25 9:47 ` Jonathan Cameron
2022-01-25 9:47 ` Jonathan Cameron
2022-01-25 9:47 ` Jonathan Cameron
2022-01-25 10:29 ` Uwe Kleine-König
2022-01-25 10:29 ` Uwe Kleine-König
2022-01-25 10:29 ` Uwe Kleine-König
2022-01-25 10:29 ` Uwe Kleine-König
2022-01-25 10:19 ` Miquel Raynal
2022-01-25 10:19 ` Miquel Raynal
2022-01-25 10:19 ` Miquel Raynal
2022-01-25 10:19 ` Miquel Raynal
2022-01-25 10:25 ` Claudius Heine
2022-01-25 10:25 ` Claudius Heine
2022-01-25 10:25 ` Claudius Heine
2022-01-25 10:25 ` Claudius Heine
2022-01-25 10:37 ` Geert Uytterhoeven
2022-01-25 10:37 ` Geert Uytterhoeven
2022-01-25 10:37 ` Geert Uytterhoeven
2022-01-25 10:37 ` Geert Uytterhoeven
[not found] ` <CGME20220125124340eucas1p2504c36206c5c17f63663a814fc8f7feb@eucas1p2.samsung.com>
2022-01-25 12:43 ` Lukasz Stelmach
2022-01-25 14:16 ` Jérôme Pouiller
2022-01-25 14:16 ` Jérôme Pouiller
2022-01-25 14:16 ` Jérôme Pouiller
2022-01-27 11:39 ` Ulf Hansson [this message]
2022-01-27 13:41 ` Marcus Folkesson
2022-02-08 13:39 ` Mark Brown
2022-02-08 13:39 ` Mark Brown
2022-02-08 13:39 ` Mark Brown
2022-02-08 13:39 ` Mark Brown
2022-02-18 12:37 ` Hans Verkuil
2022-02-18 12:37 ` Hans Verkuil
2022-02-18 12:37 ` Hans Verkuil
2022-02-18 12:37 ` Hans Verkuil
2022-03-02 7:30 ` Pavel Machek
2022-03-02 7:30 ` Pavel Machek
2022-03-02 7:30 ` Pavel Machek
2022-03-02 7:30 ` Pavel Machek
2022-01-25 9:30 ` [PATCH 0/5] " Lee Jones
2022-01-25 9:30 ` Lee Jones
2022-01-25 9:30 ` Lee Jones
2022-01-25 9:30 ` Lee Jones
2022-02-09 14:34 ` Mark Brown
2022-02-09 14:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrZQ0JUjNt_bcxLXVGZ6NtLdUktN7v_4fj--ntoO26TPg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.