Re: [PATCH 5/5] spi: make remove callback a void function - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
	Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <linux@roeck-us.net>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Yasunari Takiguchi" <Yasunari.Takiguchi@sony.com>,
	"Claudius Heine" <ch@denx.de>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Nanyong Sun" <sunnanyong@huawei.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	dri-devel@lists.freedesktop.org,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Frieder Schrempf" <frieder.schrempf@kontron.de>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Christian Lamparter" <chunkeey@googlemail.com>,
	"Ajay Singh" <ajay.kathat@microchip.com>,
	linux-clk@vger.kernel.org,
	"Stefan Schmidt" <stefan@datenfreihafen.org>,
	"Sidong Yang" <realwakka@gmail.com>,
	libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org,
	"Antti Palosaari" <crope@iki.fi>,
	"Jean Delvare" <jdelvare@suse.com>,
	linux-serial@vger.kernel.org,
	"Łukasz Stelmach" <l.stelmach@samsung.com>,
	"Mark Tomlinson" <mark.tomlinson@alliedtelesis.co.nz>,
	"James Schulman" <james.schulman@cirrus.com>,
	"Kamlesh Gurudasani" <kamlesh.gurudasani@gmail.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Zhang Qilong" <zhangqilong3@huawei.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	"Michael Walle" <michael@walle.cc>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	kernel@pengutronix.de, linux-mtd@lists.infradead.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	linux-wpan@vger.kernel.org,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Dan Robertson" <dan@dlrobertson.com>,
	"Markuss Broks" <markuss.broks@gmail.com>,
	"Lucas Tanure" <tanureal@opensource.cirrus.com>,
	"David Airlie" <airlied@linux.ie>,
	linux-wireless@vger.kernel.org,
	"David Rhodes" <david.rhodes@cirrus.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Solomon Peachy" <pizza@shaftnet.org>,
	"Marek Behún" <kabel@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Emmanuel Gil Peyrot" <linkmauve@linkmauve.fr>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Tudor Ambarus" <tudor.ambarus@microchip.com>,
	"Minghao Chi" <chi.minghao@zte.com.cn>,
	"Jon Hunter" <jonathanh@nvidia.com>,
	dingsenjie <dingsenjie@yulong.com>, "Heiko Schocher" <hs@denx.de>,
	"Wolfgang Grandegger" <wg@grandegger.com>,
	"Matt Kline" <matt@bitbashing.io>,
	"Woojung Huh" <woojung.huh@microchip.com>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Mike Looijmans" <mike.looijmans@topic.nl>,
	"Ronald Tschalär" <ronald@innovation.ch>,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	linux-can@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Davidlohr Bueso" <dbueso@suse.de>,
	UNGLinuxDriver@microchip.com, linux-usb@vger.kernel.org,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	linux-integrity@vger.kernel.org,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	linux-staging@lists.linux.dev, linux-iio@vger.kernel.org,
	"Michael Turquette" <mturquette@baylibre.com>,
	alsa-devel@alsa-project.org, "Nuno Sá" <nuno.sa@analog.com>,
	netdev@vger.kernel.org, "Wei Yongjun" <weiyongjun1@huawei.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
	linux-rtc@vger.kernel.org,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Aditya Srivastava" <yashsri421@gmail.com>,
	"Varka Bhadram" <varkabhadram@gmail.com>,
	wengjianfeng <wengjianfeng@yulong.com>,
	linux-input@vger.kernel.org, linux-media@vger.kernel.org,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Mark Greer" <mgreer@animalcreek.com>,
	"Mark Gross" <markgross@kernel.org>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	linux-fbdev@vger.kernel.org,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Stefan Mätje" <stefan.maetje@esd.eu>,
	linux-hwmon@vger.kernel.org, "Felipe Balbi" <balbi@kernel.org>,
	"Paulo Miguel Almeida" <paulo.miguel.almeida.rodenas@gmail.com>,
	"Support Opensource" <support.opensource@diasemi.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	linux-mmc@vger.kernel.org, "Liam Girdwood" <lgirdwood@gmail.com>,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Yang Li" <yang.lee@linux.alibaba.com>,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	patches@opensource.cirrus.com,
	"Kent Gustavsson" <kent@minoris.se>,
	"David S. Miller" <davem@davemloft.net>,
	"Alexander Aring" <alex.aring@gmail.com>,
	"Jiri Prchal" <jiri.prchal@aksignal.cz>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Emma Anholt" <emma@anholt.net>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Alexandru Ardelean" <ardeleanalex@gmail.com>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Torin Cooper-Bennun" <torin@maxiluxsystems.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	linux-leds@vger.kernel.org,
	"Eric Piel" <eric.piel@tremplin-utc.net>,
	"Stephan Gerhold" <stephan@gerhold.net>,
	"Richard Weinberger" <richard@nod.at>,
	"Russell King" <linux@armlinux.org.uk>,
	"Thomas Kopp" <thomas.kopp@microchip.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Vivien Didelot" <vivien.didelot@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	"Stefan Wahren" <stefan.wahren@i2se.com>,
	"Xue Liu" <liuxuenetmail@gmail.com>,
	"David Lechner" <david@lechnology.com>,
	"Will Deacon" <will@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Rui Miguel Silva" <rmfrfs@gmail.com>,
	"Marc Kleine-Budde" <mkl@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Yang Shen" <shenyang39@huawei.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Cai Huoqing" <caihuoqing@baidu.com>,
	"Daniel Mack" <daniel@zonque.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Colin Ian King" <colin.king@intel.com>,
	"Helge Deller" <deller@gmx.de>, "Alan Ott" <alan@signal11.us>
Subject: Re: [PATCH 5/5] spi: make remove callback a void function
Date: Tue, 25 Jan 2022 11:29:03 +0100	[thread overview]
Message-ID: <20220125102903.werurj56umtglcue@pengutronix.de> (raw)
In-Reply-To: <20220125094759.000019c5@Huawei.com>

[-- Attachment #1.1: Type: text/plain, Size: 1914 bytes --]

[Dropped a few people from Cc that are not reachable (Harry Morris,
Charles-Antoine Couret, Marco Felsch)]

On Tue, Jan 25, 2022 at 09:47:59AM +0000, Jonathan Cameron wrote:
> On Sun, 23 Jan 2022 18:52:01 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> 
> > The value returned by an spi driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> > 
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> For iio drivers.
> 
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> As you mention in the cover letter we'll be wanting an immutable
> branch somewhere to pull into subsystem trees.
> 
> Soon is good if possible as otherwise we'll end up with a bunch of merge
> conflicts getting resolved in next.

Yes, I considered creating a tag to pull already when sending out this
series, but I guessed delaying that a little bit to give people the
opportunity to ack would be a good idea.

@broonie: Do you think this change is a good idea? Would you require
some more acks for the preparatory patches? I had hoped to get Acks from
the corresponding maintainers, maybe they are busy and missed this
series as I put them on Cc: only. I promoted them to To: in this mail.

Or is it too ambitious to get this in during the next merge window?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/