From: Ulf Hansson <ulf.hansson@linaro.org> To: Patrice CHOTARD <patrice.chotard@st.com> Cc: Russell King <linux@armlinux.org.uk>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexandre Torgue <alexandre.torgue@st.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 03/15] mmc: mmci: Don't pretend all variants to have OPENDRAIN bit Date: Wed, 17 Jan 2018 10:33:28 +0100 [thread overview] Message-ID: <CAPDyKFrhBfGq0RBBdFLex+88XqrLB-Bm3rc2Q_UZCw8XB520ug@mail.gmail.com> (raw) In-Reply-To: <1516105859-3525-4-git-send-email-patrice.chotard@st.com> [...] > /* Busy detection for the ST Micro variant */ > @@ -1455,16 +1465,13 @@ static void mmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > ~MCI_ST_DATA2DIREN); > } > > - if (ios->bus_mode == MMC_BUSMODE_OPENDRAIN) { > - if (host->hw_designer != AMBA_VENDOR_ST) > - pwr |= MCI_ROD; > - else { > - /* > - * The ST Micro variant use the ROD bit for something > - * else and only has OD (Open Drain). > - */ > - pwr |= MCI_OD; > - } > + if (ios->bus_mode == MMC_BUSMODE_OPENDRAIN && > + host->variant->opendrain) { A few nitpicks (because I anyway had some comment on patch4): The above can be written on one line and the brackets isn't needed. Replace host->variant->opendrain with variant->opendrain. The same applies to the below change. > + /* > + * The ST Micro variant use the ROD bit for > + * something else and only has OD (Open Drain). > + */ I think we can remove this comment, as this information becomes implicit when we start using the variant data. > + pwr |= host->variant->opendrain; > } > > /* > -- > 1.9.1 > Kind regards Uffe
WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 03/15] mmc: mmci: Don't pretend all variants to have OPENDRAIN bit Date: Wed, 17 Jan 2018 10:33:28 +0100 [thread overview] Message-ID: <CAPDyKFrhBfGq0RBBdFLex+88XqrLB-Bm3rc2Q_UZCw8XB520ug@mail.gmail.com> (raw) In-Reply-To: <1516105859-3525-4-git-send-email-patrice.chotard@st.com> [...] > /* Busy detection for the ST Micro variant */ > @@ -1455,16 +1465,13 @@ static void mmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > ~MCI_ST_DATA2DIREN); > } > > - if (ios->bus_mode == MMC_BUSMODE_OPENDRAIN) { > - if (host->hw_designer != AMBA_VENDOR_ST) > - pwr |= MCI_ROD; > - else { > - /* > - * The ST Micro variant use the ROD bit for something > - * else and only has OD (Open Drain). > - */ > - pwr |= MCI_OD; > - } > + if (ios->bus_mode == MMC_BUSMODE_OPENDRAIN && > + host->variant->opendrain) { A few nitpicks (because I anyway had some comment on patch4): The above can be written on one line and the brackets isn't needed. Replace host->variant->opendrain with variant->opendrain. The same applies to the below change. > + /* > + * The ST Micro variant use the ROD bit for > + * something else and only has OD (Open Drain). > + */ I think we can remove this comment, as this information becomes implicit when we start using the variant data. > + pwr |= host->variant->opendrain; > } > > /* > -- > 1.9.1 > Kind regards Uffe
next prev parent reply other threads:[~2018-01-17 9:33 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-16 12:30 [PATCH v2 00/15] Add MMCI support for STM32F SoCs family patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 01/15] mmc: mmci: Don't pretend all variants to have MMCIMASK1 register patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 02/15] mmc: mmci: Don't pretend all variants to have MCI_STARBITERR flag patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 03/15] mmc: mmci: Don't pretend all variants to have OPENDRAIN bit patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-17 9:33 ` Ulf Hansson [this message] 2018-01-17 9:33 ` Ulf Hansson 2018-01-18 13:24 ` Patrice CHOTARD 2018-01-18 13:24 ` Patrice CHOTARD 2018-01-18 13:24 ` Patrice CHOTARD 2018-01-18 13:24 ` Patrice CHOTARD 2018-01-16 12:30 ` [PATCH v2 04/15] mmc: mmci: Add support for setting pad type via pinctrl patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-17 9:34 ` Ulf Hansson 2018-01-17 9:34 ` Ulf Hansson 2018-01-18 13:35 ` Patrice CHOTARD 2018-01-18 13:35 ` Patrice CHOTARD 2018-01-18 13:35 ` Patrice CHOTARD 2018-01-16 12:30 ` [PATCH v2 05/15] mmc: mmci: Add STM32 variant patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 06/15] ARM: dts: stm32: Add SDIO controller for stm32f746 patrice.chotard 2018-01-16 12:30 ` patrice.chotard [not found] ` <1516105859-3525-1-git-send-email-patrice.chotard-qxv4g6HH51o@public.gmane.org> 2018-01-16 12:30 ` [PATCH v2 07/15] ARM: dts: stm32: Add SDIO controller for stm32f429 patrice.chotard-qxv4g6HH51o 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 08/15] ARM: dts: stm32: Add pin map for SDIO controller on stm32f4 patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 09/15] ARM: dts: stm32: Enable SDIO controller on stm32f469 disco board patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 10/15] ARM: dts: stm32: Enable SDIO controller on stm32429i-eval board patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 11/15] ARM: stm32: Add AMBA support for STM32F4 and STM32F7 SoCs patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 12/15] ARM: configs: stm32: Enable MMC_ARMMMCI support patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 13/15] ARM: configs: stm32: Enable EXT3_FS support patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-01-16 12:30 ` [PATCH v2 14/15] clk: stm32: Add clk entry for SDMMC2 on stm32F769 patrice.chotard 2018-01-16 12:30 ` patrice.chotard 2018-02-26 8:41 ` Patrice CHOTARD 2018-02-26 8:41 ` Patrice CHOTARD 2018-02-26 8:41 ` Patrice CHOTARD 2018-03-01 9:12 ` Linus Walleij 2018-03-01 9:12 ` Linus Walleij 2018-03-01 9:42 ` Patrice CHOTARD 2018-03-01 9:42 ` Patrice CHOTARD 2018-03-01 9:42 ` Patrice CHOTARD 2018-03-01 9:42 ` Patrice CHOTARD 2018-03-15 21:24 ` Stephen Boyd 2018-03-15 21:24 ` Stephen Boyd 2018-03-15 21:24 ` Stephen Boyd 2018-01-16 12:30 ` [PATCH v2 15/15] gpio: stmpe: i2c transfer are forbiden in atomic context patrice.chotard 2018-01-16 12:30 ` patrice.chotard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPDyKFrhBfGq0RBBdFLex+88XqrLB-Bm3rc2Q_UZCw8XB520ug@mail.gmail.com \ --to=ulf.hansson@linaro.org \ --cc=alexandre.torgue@st.com \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=patrice.chotard@st.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.