From: Sam Protsenko <semen.protsenko@linaro.org> To: Tudor Ambarus <tudor.ambarus@linaro.org> Cc: broonie@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com Subject: Re: [PATCH v4 06/16] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Date: Mon, 5 Feb 2024 09:53:11 -0600 [thread overview] Message-ID: <CAPLW+4=S7+ur0Csd-qQcEBo2_Z3Dy9ZtarYY0=jYhY33kc4WDA@mail.gmail.com> (raw) In-Reply-To: <20240205124513.447875-7-tudor.ambarus@linaro.org> On Mon, Feb 5, 2024 at 6:45 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote: > > of_device_id::data is an opaque pointer. No explicit cast is needed. > Remove unneeded (void *) casts in of_match_table. > > Reviewed-by: Andi Shyti <andi.shyti@kernel.org> > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/spi/spi-s3c64xx.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index ccb700312d64..807270ec3c8a 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -1512,31 +1512,31 @@ static const struct platform_device_id s3c64xx_spi_driver_ids[] = { > > static const struct of_device_id s3c64xx_spi_dt_match[] = { > { .compatible = "samsung,s3c2443-spi", > - .data = (void *)&s3c2443_spi_port_config, > + .data = &s3c2443_spi_port_config, > }, > { .compatible = "samsung,s3c6410-spi", > - .data = (void *)&s3c6410_spi_port_config, > + .data = &s3c6410_spi_port_config, > }, > { .compatible = "samsung,s5pv210-spi", > - .data = (void *)&s5pv210_spi_port_config, > + .data = &s5pv210_spi_port_config, > }, > { .compatible = "samsung,exynos4210-spi", > - .data = (void *)&exynos4_spi_port_config, > + .data = &exynos4_spi_port_config, > }, > { .compatible = "samsung,exynos7-spi", > - .data = (void *)&exynos7_spi_port_config, > + .data = &exynos7_spi_port_config, > }, > { .compatible = "samsung,exynos5433-spi", > - .data = (void *)&exynos5433_spi_port_config, > + .data = &exynos5433_spi_port_config, > }, > { .compatible = "samsung,exynos850-spi", > - .data = (void *)&exynos850_spi_port_config, > + .data = &exynos850_spi_port_config, > }, > { .compatible = "samsung,exynosautov9-spi", > - .data = (void *)&exynosautov9_spi_port_config, > + .data = &exynosautov9_spi_port_config, > }, > { .compatible = "tesla,fsd-spi", > - .data = (void *)&fsd_spi_port_config, > + .data = &fsd_spi_port_config, > }, > { }, > }; > -- > 2.43.0.594.gd9cf4e227d-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Protsenko <semen.protsenko@linaro.org> To: Tudor Ambarus <tudor.ambarus@linaro.org> Cc: broonie@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com Subject: Re: [PATCH v4 06/16] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Date: Mon, 5 Feb 2024 09:53:11 -0600 [thread overview] Message-ID: <CAPLW+4=S7+ur0Csd-qQcEBo2_Z3Dy9ZtarYY0=jYhY33kc4WDA@mail.gmail.com> (raw) In-Reply-To: <20240205124513.447875-7-tudor.ambarus@linaro.org> On Mon, Feb 5, 2024 at 6:45 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote: > > of_device_id::data is an opaque pointer. No explicit cast is needed. > Remove unneeded (void *) casts in of_match_table. > > Reviewed-by: Andi Shyti <andi.shyti@kernel.org> > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/spi/spi-s3c64xx.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index ccb700312d64..807270ec3c8a 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -1512,31 +1512,31 @@ static const struct platform_device_id s3c64xx_spi_driver_ids[] = { > > static const struct of_device_id s3c64xx_spi_dt_match[] = { > { .compatible = "samsung,s3c2443-spi", > - .data = (void *)&s3c2443_spi_port_config, > + .data = &s3c2443_spi_port_config, > }, > { .compatible = "samsung,s3c6410-spi", > - .data = (void *)&s3c6410_spi_port_config, > + .data = &s3c6410_spi_port_config, > }, > { .compatible = "samsung,s5pv210-spi", > - .data = (void *)&s5pv210_spi_port_config, > + .data = &s5pv210_spi_port_config, > }, > { .compatible = "samsung,exynos4210-spi", > - .data = (void *)&exynos4_spi_port_config, > + .data = &exynos4_spi_port_config, > }, > { .compatible = "samsung,exynos7-spi", > - .data = (void *)&exynos7_spi_port_config, > + .data = &exynos7_spi_port_config, > }, > { .compatible = "samsung,exynos5433-spi", > - .data = (void *)&exynos5433_spi_port_config, > + .data = &exynos5433_spi_port_config, > }, > { .compatible = "samsung,exynos850-spi", > - .data = (void *)&exynos850_spi_port_config, > + .data = &exynos850_spi_port_config, > }, > { .compatible = "samsung,exynosautov9-spi", > - .data = (void *)&exynosautov9_spi_port_config, > + .data = &exynosautov9_spi_port_config, > }, > { .compatible = "tesla,fsd-spi", > - .data = (void *)&fsd_spi_port_config, > + .data = &fsd_spi_port_config, > }, > { }, > }; > -- > 2.43.0.594.gd9cf4e227d-goog >
next prev parent reply other threads:[~2024-02-05 15:53 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-05 12:44 [PATCH v4 00/16] spi: s3c64xx: straightforward cleanup Tudor Ambarus 2024-02-05 12:44 ` Tudor Ambarus 2024-02-05 12:44 ` [PATCH v4 01/16] spi: s3c64xx: explicitly include <linux/io.h> Tudor Ambarus 2024-02-05 12:44 ` Tudor Ambarus 2024-02-05 15:24 ` Peter Griffin 2024-02-05 15:24 ` Peter Griffin 2024-02-05 12:44 ` [PATCH v4 02/16] spi: s3c64xx: explicitly include <linux/bits.h> Tudor Ambarus 2024-02-05 12:44 ` Tudor Ambarus 2024-02-05 15:25 ` Peter Griffin 2024-02-05 15:25 ` Peter Griffin 2024-02-05 12:45 ` [PATCH v4 03/16] spi: s3c64xx: avoid possible negative array index Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 15:26 ` Peter Griffin 2024-02-05 15:26 ` Peter Griffin 2024-02-05 12:45 ` [PATCH v4 04/16] spi: s3c64xx: fix typo, s/configuartion/configuration Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 05/16] spi: s3c64xx: sort headers alphabetically Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 15:28 ` Peter Griffin 2024-02-05 15:28 ` Peter Griffin 2024-02-05 12:45 ` [PATCH v4 06/16] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 15:53 ` Sam Protsenko [this message] 2024-02-05 15:53 ` Sam Protsenko 2024-02-05 12:45 ` [PATCH v4 07/16] spi: s3c64xx: remove else after return Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 08/16] spi: s3c64xx: move common code outside if else Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 09/16] spi: s3c64xx: check return code of dmaengine_slave_config() Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 10/16] spi: s3c64xx: propagate the dma_submit_error() error code Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 11/16] spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 12/16] spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 13/16] spi: s3c64xx: drop blank line between declarations Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 14/16] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 15/16] spi: s3c64xx: remove duplicated definition Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-05 12:45 ` [PATCH v4 16/16] spi: s3c64xx: drop a superfluous bitwise NOT operation Tudor Ambarus 2024-02-05 12:45 ` Tudor Ambarus 2024-02-07 7:52 ` [PATCH v4 00/16] spi: s3c64xx: straightforward cleanup Tudor Ambarus 2024-02-07 7:52 ` Tudor Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPLW+4=S7+ur0Csd-qQcEBo2_Z3Dy9ZtarYY0=jYhY33kc4WDA@mail.gmail.com' \ --to=semen.protsenko@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=andi.shyti@kernel.org \ --cc=andre.draszik@linaro.org \ --cc=broonie@kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=peter.griffin@linaro.org \ --cc=tudor.ambarus@linaro.org \ --cc=willmcvicker@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.