Re: [GIT PULL] exynos-drm-fixes

From: Dave Airlie <airlied@gmail.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: airlied@linux.ie, linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [GIT PULL] exynos-drm-fixes
Date: Fri, 24 Nov 2023 11:14:26 +1000	[thread overview]
Message-ID: <CAPM=9txk2nqYykd5shh3Ux7Jff8hweQnhpNUtYmT9nbcKrHdsA@mail.gmail.com> (raw)
In-Reply-To: <20231120225537.1270358-1-inki.dae@samsung.com>

On Tue, 21 Nov 2023 at 09:00, Inki Dae <inki.dae@samsung.com> wrote:
>
> Hi Dave and Daniel,
>
>    Two fixups - fixing a potential error pointer dereference and wrong
>    error checking.
Hi Inki,

This fails to build on arm32, and it seems one of the fixes is wrong

[airlied@dreadlord drm-fixes]$ make ARCH=arm
CROSS_COMPILE=arm-linux-gnu- O=../../arm-build-fixes/  -j16
make[1]: Entering directory '/home/airlied/devel/kernel/arm-build-fixes'
  GEN     Makefile
      CALL    /home/airlied/devel/kernel/dim/drm-fixes/scripts/checksyscalls.sh
  CC [M]  drivers/gpu/drm/exynos/exynos_drm_dma.o
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:
In function ‘exynos_drm_register_dma’:
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:119:40:
error: passing argument 1 of ‘PTR_ERR’ makes pointer from integer
without a cast [-Werror=int-conversion]
  119 |                         return PTR_ERR(-ENODEV);
In file included from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/string.h:9,
                 from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-mapping.h:7,
                 from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-map-ops.h:9,
                 from
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_dma.c:7:
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/err.h:49:61:
note: expected ‘const void *’ but argument is of type ‘int’
   49 | static inline long __must_check PTR_ERR(__force const void *ptr)
      |                                                 ~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors

I think it should just be return -ENODEV, since the function returns an int.

Please fix it up and resend.

Thanks,
Dave.

>
>    Ps. regarding the first patch, I had sent a GIT-PULL[1] but it seems
>        you missed.
>    [1] https://lore.kernel.org/dri-devel/20231006040950.4397-1-inki.dae@samsung.com/T/#u
>
>    Please kindly let me know if there is any problem.
>
> Thanks,
> Inki Dae
>
> The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671b2263:
>
>   Linux 6.7-rc2 (2023-11-19 15:02:14 -0800)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-drm-fixes-for-v6.7-rc3
>
> for you to fetch changes up to a30ba4bd7cdb5726d86a557c5df8df71c7bc7fad:
>
>   drm/exynos: fix a wrong error checking (2023-11-21 07:41:11 +0900)
>
> ----------------------------------------------------------------
> Two fixups
> - Fix a potential error pointer dereference by checking the return value
>   of exynos_drm_crtc_get_by_type() function before accessing to crtc
>   object.
> - Fix a wrong error checking in exynos_drm_dma.c modules, which was reported
>   by Dan[1]
>
> [1] https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.mountain/
>
> ----------------------------------------------------------------
> Inki Dae (1):
>       drm/exynos: fix a wrong error checking
>
> Xiang Yang (1):
>       drm/exynos: fix a potential error pointer dereference
>
>  drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++-----
>  drivers/gpu/drm/exynos/exynos_hdmi.c    | 2 ++
>  2 files changed, 5 insertions(+), 5 deletions(-)