From: Dave Airlie <airlied@gmail.com> To: Lyude Paul <lyude@redhat.com> Cc: dri-devel <dri-devel@lists.freedesktop.org>, nouveau <nouveau@lists.freedesktop.org>, "amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>, "Sean Paul" <sean@poorly.run>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Imre Deak" <imre.deak@intel.com>, "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, LKML <linux-kernel@vger.kernel.org>, "Maxime Ripard" <mripard@kernel.org>, "Juston Li" <juston.li@intel.com>, "Daniel Vetter" <daniel@ffwll.ch>, "Harry Wentland" <hwentlan@amd.com>, "Ville Syrjälä" <ville.syrjala@linux.intel.com> Subject: Re: [PATCH v2 11/27] drm/dp_mst: Constify guid in drm_dp_get_mst_branch_by_guid() Date: Wed, 4 Sep 2019 07:41:07 +1000 [thread overview] Message-ID: <CAPM=9tz0fdZpfFAfQ0aCQ4D+0XQGm=zqeFKDHPFNwVEUeM1f5g@mail.gmail.com> (raw) In-Reply-To: <20190903204645.25487-12-lyude@redhat.com> On Wed, 4 Sep 2019 at 06:48, Lyude Paul <lyude@redhat.com> wrote: > > And it's helper, we'll be using this in just a moment. > Reviewed-by: Dave Airlie <airlied@redhat.com> > Cc: Juston Li <juston.li@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Harry Wentland <hwentlan@amd.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Signed-off-by: Lyude Paul <lyude@redhat.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 43452872efad..b44d3696c09a 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2060,7 +2060,7 @@ static struct drm_dp_mst_branch *drm_dp_get_mst_branch_device(struct drm_dp_mst_ > > static struct drm_dp_mst_branch *get_mst_branch_device_by_guid_helper( > struct drm_dp_mst_branch *mstb, > - uint8_t *guid) > + const uint8_t *guid) > { > struct drm_dp_mst_branch *found_mstb; > struct drm_dp_mst_port *port; > @@ -2084,7 +2084,7 @@ static struct drm_dp_mst_branch *get_mst_branch_device_by_guid_helper( > > static struct drm_dp_mst_branch * > drm_dp_get_mst_branch_device_by_guid(struct drm_dp_mst_topology_mgr *mgr, > - uint8_t *guid) > + const uint8_t *guid) > { > struct drm_dp_mst_branch *mstb; > int ret; > -- > 2.21.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: "Maxime Ripard" <mripard-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>, nouveau <nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, "Imre Deak" <imre.deak-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Maarten Lankhorst" <maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "amd-gfx mailing list" <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, "Harry Wentland" <hwentlan-5C7GfCeVMHo@public.gmane.org>, "Ville Syrjälä" <ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, dri-devel <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, "Daniel Vetter" <daniel-/w4YWyX8dFk@public.gmane.org>, "Daniel Vetter" <daniel.vetter-/w4YWyX8dFk@public.gmane.org>, "Sean Paul" <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>, "Juston Li" <juston.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Subject: Re: [PATCH v2 11/27] drm/dp_mst: Constify guid in drm_dp_get_mst_branch_by_guid() Date: Wed, 4 Sep 2019 07:41:07 +1000 [thread overview] Message-ID: <CAPM=9tz0fdZpfFAfQ0aCQ4D+0XQGm=zqeFKDHPFNwVEUeM1f5g@mail.gmail.com> (raw) In-Reply-To: <20190903204645.25487-12-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> On Wed, 4 Sep 2019 at 06:48, Lyude Paul <lyude@redhat.com> wrote: > > And it's helper, we'll be using this in just a moment. > Reviewed-by: Dave Airlie <airlied@redhat.com> > Cc: Juston Li <juston.li@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Harry Wentland <hwentlan@amd.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Signed-off-by: Lyude Paul <lyude@redhat.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 43452872efad..b44d3696c09a 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2060,7 +2060,7 @@ static struct drm_dp_mst_branch *drm_dp_get_mst_branch_device(struct drm_dp_mst_ > > static struct drm_dp_mst_branch *get_mst_branch_device_by_guid_helper( > struct drm_dp_mst_branch *mstb, > - uint8_t *guid) > + const uint8_t *guid) > { > struct drm_dp_mst_branch *found_mstb; > struct drm_dp_mst_port *port; > @@ -2084,7 +2084,7 @@ static struct drm_dp_mst_branch *get_mst_branch_device_by_guid_helper( > > static struct drm_dp_mst_branch * > drm_dp_get_mst_branch_device_by_guid(struct drm_dp_mst_topology_mgr *mgr, > - uint8_t *guid) > + const uint8_t *guid) > { > struct drm_dp_mst_branch *mstb; > int ret; > -- > 2.21.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-09-03 21:41 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-03 20:45 [PATCH v2 00/27] DP MST Refactors + debugging tools + suspend/resume reprobing Lyude Paul 2019-09-03 20:45 ` [PATCH v2 01/27] drm/dp_mst: Move link address dumping into a function Lyude Paul 2019-09-25 17:45 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 02/27] drm/dp_mst: Get rid of list clear in destroy_connector_work Lyude Paul 2019-09-25 17:45 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 03/27] drm/dp_mst: Destroy MSTBs asynchronously Lyude Paul 2019-09-25 18:16 ` Sean Paul 2019-09-25 20:08 ` Lyude Paul 2019-09-27 13:31 ` Sean Paul 2019-09-27 13:31 ` Sean Paul 2019-10-08 9:45 ` Daniel Vetter 2019-09-03 20:45 ` [PATCH v2 04/27] drm/dp_mst: Move test_calc_pbn_mode() into an actual selftest Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-25 18:17 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 05/27] drm/print: Add drm_err_printer() Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-03 20:45 ` [PATCH v2 06/27] drm/dp_mst: Combine redundant cases in drm_dp_encode_sideband_req() Lyude Paul 2019-09-03 21:35 ` Dave Airlie 2019-09-03 21:57 ` [PATCH v3] " Lyude Paul 2019-09-03 20:45 ` [PATCH v2 07/27] drm/dp_mst: Add sideband down request tracing + selftests Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-10 9:01 ` Jani Nikula 2019-09-03 20:45 ` [PATCH v2 08/27] drm/dp_mst: Remove PDT teardown in drm_dp_destroy_port() and refactor Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-25 19:00 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 09/27] drm/dp_mst: Refactor drm_dp_send_enum_path_resources Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-03 20:45 ` [PATCH v2 10/27] drm/dp_mst: Remove huge conditional in drm_dp_mst_handle_up_req() Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-03 20:45 ` [PATCH v2 11/27] drm/dp_mst: Constify guid in drm_dp_get_mst_branch_by_guid() Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-03 21:41 ` Dave Airlie [this message] 2019-09-03 21:41 ` Dave Airlie 2019-09-03 20:45 ` [PATCH v2 12/27] drm/dp_mst: Refactor drm_dp_mst_handle_up_req() Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-03 20:45 ` [PATCH v2 13/27] drm/dp_mst: Refactor drm_dp_mst_handle_down_rep() Lyude Paul 2019-09-03 20:45 ` [PATCH v2 14/27] drm/dp_mst: Destroy topology_mgr mutexes Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-25 19:14 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 15/27] drm/dp_mst: Cleanup drm_dp_send_link_address() a bit Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-03 21:42 ` Dave Airlie 2019-09-03 20:45 ` [PATCH v2 16/27] drm/dp_mst: Refactor pdt setup/teardown, add more locking Lyude Paul 2019-09-25 19:27 ` Sean Paul 2019-09-25 19:27 ` Sean Paul 2019-09-25 21:00 ` Lyude Paul 2019-09-25 21:00 ` Lyude Paul 2019-09-27 13:30 ` Sean Paul 2019-09-27 13:30 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 17/27] drm/dp_mst: Rename drm_dp_add_port and drm_dp_update_port Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-25 19:30 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 18/27] drm/dp_mst: Remove lies in {up,down}_rep_recv documentation Lyude Paul 2019-09-25 19:32 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 19/27] drm/dp_mst: Handle UP requests asynchronously Lyude Paul 2019-09-03 20:45 ` Lyude Paul 2019-09-25 19:46 ` Sean Paul 2019-09-03 20:45 ` [PATCH v2 20/27] drm/dp_mst: Protect drm_dp_mst_port members with connection_mutex Lyude Paul 2019-09-25 20:00 ` Sean Paul 2019-09-25 21:01 ` Lyude Paul 2019-09-25 21:01 ` Lyude Paul 2019-09-03 20:45 ` [PATCH v2 21/27] drm/dp_mst: Don't forget to update port->input in drm_dp_mst_handle_conn_stat() Lyude Paul 2019-09-25 20:03 ` Sean Paul 2019-09-03 20:46 ` [PATCH v2 22/27] drm/nouveau: Don't grab runtime PM refs for HPD IRQs Lyude Paul 2019-09-25 20:06 ` Sean Paul 2019-09-03 20:46 ` [PATCH v2 23/27] drm/amdgpu: Iterate through DRM connectors correctly Lyude Paul 2019-09-03 20:46 ` Lyude Paul 2019-09-13 20:45 ` Alex Deucher 2019-09-13 20:45 ` Alex Deucher 2019-09-27 13:48 ` Alex Deucher 2019-09-27 13:48 ` Alex Deucher 2019-09-03 20:46 ` [PATCH v2 24/27] drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology Lyude Paul 2019-09-13 20:46 ` Alex Deucher 2019-09-25 20:08 ` Sean Paul 2019-09-25 20:08 ` Sean Paul 2019-09-25 21:52 ` [PATCH v4] " Lyude Paul 2019-09-25 21:52 ` Lyude Paul 2019-09-27 13:29 ` Alex Deucher 2019-09-27 13:29 ` Alex Deucher 2019-09-03 20:46 ` [PATCH v2 25/27] drm/dp_mst: Add basic topology reprobing when resuming Lyude Paul 2019-09-03 20:46 ` Lyude Paul 2019-09-27 13:52 ` Sean Paul 2019-09-27 13:52 ` Sean Paul 2019-10-09 19:06 ` Lyude Paul 2019-10-09 19:06 ` Lyude Paul 2019-09-03 20:46 ` [PATCH v2 26/27] drm/dp_mst: Also print unhashed pointers for malloc/topology references Lyude Paul 2019-09-03 20:46 ` Lyude Paul 2019-09-27 14:25 ` Sean Paul 2019-10-09 19:40 ` Lyude Paul 2019-10-09 19:40 ` Lyude Paul 2019-09-03 20:46 ` [PATCH v2 27/27] drm/dp_mst: Add topology ref history tracking for debugging Lyude Paul 2019-09-27 14:51 ` Sean Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPM=9tz0fdZpfFAfQ0aCQ4D+0XQGm=zqeFKDHPFNwVEUeM1f5g@mail.gmail.com' \ --to=airlied@gmail.com \ --cc=airlied@linux.ie \ --cc=amd-gfx@lists.freedesktop.org \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=hwentlan@amd.com \ --cc=imre.deak@intel.com \ --cc=juston.li@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=nouveau@lists.freedesktop.org \ --cc=sean@poorly.run \ --cc=ville.syrjala@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.