Re: [PATCH v8 06/10] drm/vc4: crtc: Add some logging

From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
	LKML <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Dom Cobley <dom@raspberrypi.com>
Subject: Re: [PATCH v8 06/10] drm/vc4: crtc: Add some logging
Date: Tue, 2 Nov 2021 16:33:14 +0000	[thread overview]
Message-ID: <CAPY8ntBKMr8RRCSq2xY-_uji-d=4Vr4BG53VoXzSd2dKJF-0ww@mail.gmail.com> (raw)
In-Reply-To: <20211025152903.1088803-7-maxime@cerno.tech>

On Mon, 25 Oct 2021 at 16:29, Maxime Ripard <maxime@cerno.tech> wrote:
>
> The encoder retrieval code has been a source of bugs and glitches in the
> past and the crtc <-> encoder association been wrong in a number of
> different ways.
>
> Add some logging to quickly spot issues if they occur.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

> ---
>  drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
> index fbc1d4638650..6decaa12a078 100644
> --- a/drivers/gpu/drm/vc4/vc4_crtc.c
> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
> @@ -541,6 +541,9 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc,
>         struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state);
>         struct drm_device *dev = crtc->dev;
>
> +       drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)",
> +               crtc->name, crtc->base.id, encoder->name, encoder->base.id);
> +
>         require_hvs_enabled(dev);
>
>         /* Disable vblank irq handling before crtc is disabled. */
> @@ -572,6 +575,9 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc,
>         struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, new_state);
>         struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder);
>
> +       drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)",
> +               crtc->name, crtc->base.id, encoder->name, encoder->base.id);
> +
>         require_hvs_enabled(dev);
>
>         /* Enable vblank irq handling before crtc is started otherwise
> --
> 2.31.1
>