All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Theodore Ts'o <tytso@mit.edu>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	david <david@fromorbit.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Jan Kara <jack@suse.cz>, linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops
Date: Thu, 29 Mar 2018 15:47:55 -0700	[thread overview]
Message-ID: <CAPcyv4gknYC3WUEEfGjNH8ufFvokdZarSaZUm-cczCXyEz_D0w@mail.gmail.com> (raw)
In-Reply-To: <20180329180927.GA16055@lst.de>

On Thu, Mar 29, 2018 at 11:09 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote:
>> So ext4_direct_IO() for IS_DAX() files will just bail out. So could you
>> just provide ext4_dax_direct_IO() which will bail out and use it here? With
>> a similar comment as in xfs_vm_direct_IO() that open still needs this
>> method set... Thanks!
>
> In fact a common noop_direct_IO might make sense.

Ok, I introduced noop_direct_IO() in "fs, dax: prepare for
dax-specific address_space_operations", and cleaned up xfs, ext4, and
ext2 accordingly. Let me know if you want to see a resend of the
series with those changes. Otherwise this will appear in -next
shortly.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>, linux-nvdimm <linux-nvdimm@lists.01.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	david <david@fromorbit.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops
Date: Thu, 29 Mar 2018 15:47:55 -0700	[thread overview]
Message-ID: <CAPcyv4gknYC3WUEEfGjNH8ufFvokdZarSaZUm-cczCXyEz_D0w@mail.gmail.com> (raw)
In-Reply-To: <20180329180927.GA16055@lst.de>

On Thu, Mar 29, 2018 at 11:09 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote:
>> So ext4_direct_IO() for IS_DAX() files will just bail out. So could you
>> just provide ext4_dax_direct_IO() which will bail out and use it here? With
>> a similar comment as in xfs_vm_direct_IO() that open still needs this
>> method set... Thanks!
>
> In fact a common noop_direct_IO might make sense.

Ok, I introduced noop_direct_IO() in "fs, dax: prepare for
dax-specific address_space_operations", and cleaned up xfs, ext4, and
ext2 accordingly. Let me know if you want to see a resend of the
series with those changes. Otherwise this will appear in -next
shortly.

WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
	linux-nvdimm
	<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>,
	david <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-xfs <linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andreas Dilger
	<adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>,
	linux-fsdevel
	<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
	linux-ext4 <linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops
Date: Thu, 29 Mar 2018 15:47:55 -0700	[thread overview]
Message-ID: <CAPcyv4gknYC3WUEEfGjNH8ufFvokdZarSaZUm-cczCXyEz_D0w@mail.gmail.com> (raw)
In-Reply-To: <20180329180927.GA16055-jcswGhMUV9g@public.gmane.org>

On Thu, Mar 29, 2018 at 11:09 AM, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
> On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote:
>> So ext4_direct_IO() for IS_DAX() files will just bail out. So could you
>> just provide ext4_dax_direct_IO() which will bail out and use it here? With
>> a similar comment as in xfs_vm_direct_IO() that open still needs this
>> method set... Thanks!
>
> In fact a common noop_direct_IO might make sense.

Ok, I introduced noop_direct_IO() in "fs, dax: prepare for
dax-specific address_space_operations", and cleaned up xfs, ext4, and
ext2 accordingly. Let me know if you want to see a resend of the
series with those changes. Otherwise this will appear in -next
shortly.

  reply	other threads:[~2018-03-29 22:41 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 22:57 [PATCH v7 00/14] dax: fix dma vs truncate/hole-punch Dan Williams
2018-03-21 22:57 ` Dan Williams
2018-03-21 22:57 ` Dan Williams
2018-03-21 22:57 ` Dan Williams
2018-03-21 22:57 ` [PATCH v7 01/14] dax: store pfns in the radix Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57 ` [PATCH v7 02/14] fs, dax: prepare for dax-specific address_space_operations Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-29 15:28   ` Jan Kara
2018-03-29 15:28     ` Jan Kara
2018-03-21 22:57 ` [PATCH v7 03/14] block, dax: remove dead code in blkdev_writepages() Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-29 15:29   ` Jan Kara
2018-03-29 15:29     ` Jan Kara
2018-03-21 22:57 ` [PATCH v7 04/14] xfs, dax: introduce xfs_dax_aops Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-29 15:30   ` Jan Kara
2018-03-29 15:30     ` Jan Kara
2018-03-21 22:57 ` [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-29 15:40   ` Jan Kara
2018-03-29 15:40     ` Jan Kara
2018-03-29 15:40     ` Jan Kara
2018-03-29 18:09     ` Christoph Hellwig
2018-03-29 18:09       ` Christoph Hellwig
2018-03-29 18:09       ` Christoph Hellwig
2018-03-29 22:47       ` Dan Williams [this message]
2018-03-29 22:47         ` Dan Williams
2018-03-29 22:47         ` Dan Williams
2018-03-21 22:57 ` [PATCH v7 06/14] ext2, dax: introduce ext2_dax_aops Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-29 15:44   ` Jan Kara
2018-03-29 15:44     ` Jan Kara
2018-03-21 22:57 ` [PATCH v7 07/14] fs, dax: use page->mapping to warn if truncate collides with a busy page Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-29 16:02   ` Jan Kara
2018-03-29 16:02     ` Jan Kara
2018-03-29 19:02     ` Dan Williams
2018-03-29 19:02       ` Dan Williams
2018-03-29 23:02     ` Dan Williams
2018-03-29 23:02       ` Dan Williams
2018-03-30  8:22       ` Jan Kara
2018-03-30  8:22         ` Jan Kara
2018-03-21 22:57 ` [PATCH v7 08/14] mm, dax: enable filesystems to trigger dev_pagemap ->page_free callbacks Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-29 16:36   ` Jan Kara
2018-03-29 16:36     ` Jan Kara
2018-03-29 16:36     ` Jan Kara
2018-03-21 22:57 ` [PATCH v7 09/14] mm, dev_pagemap: introduce CONFIG_DEV_PAGEMAP_OPS Dan Williams
2018-03-21 22:57   ` Dan Williams
2018-03-22  7:49   ` Christoph Hellwig
2018-03-22  7:49     ` Christoph Hellwig
2018-03-30 10:37   ` Jan Kara
2018-03-30 10:37     ` Jan Kara
2018-03-30 10:37     ` Jan Kara
2018-03-21 22:58 ` [PATCH v7 10/14] memremap: mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams
2018-03-21 22:58   ` Dan Williams
2018-03-22  7:51   ` Christoph Hellwig
2018-03-22  7:51     ` Christoph Hellwig
2018-03-21 22:58 ` [PATCH v7 11/14] mm, fs, dax: handle layout changes to pinned dax mappings Dan Williams
2018-03-21 22:58   ` Dan Williams
2018-03-21 22:58   ` Dan Williams
2018-03-21 22:58 ` [PATCH v7 12/14] xfs: prepare xfs_break_layouts() to be called with XFS_MMAPLOCK_EXCL Dan Williams
2018-03-21 22:58   ` Dan Williams
2018-03-22  7:25   ` Christoph Hellwig
2018-03-22  7:25     ` Christoph Hellwig
2018-03-30 15:16   ` Darrick J. Wong
2018-03-30 15:16     ` Darrick J. Wong
2018-03-21 22:58 ` [PATCH v7 13/14] xfs: prepare xfs_break_layouts() for another layout type Dan Williams
2018-03-21 22:58   ` Dan Williams
2018-03-22  7:27   ` Christoph Hellwig
2018-03-22  7:27     ` Christoph Hellwig
2018-03-22 15:50     ` Dan Williams
2018-03-22 15:50       ` Dan Williams
2018-03-21 22:58 ` [PATCH v7 14/14] xfs, dax: introduce xfs_break_dax_layouts() Dan Williams
2018-03-21 22:58   ` Dan Williams
2018-03-21 22:58   ` Dan Williams
2018-03-22  7:43   ` Christoph Hellwig
2018-03-22  7:43     ` Christoph Hellwig
2018-03-22 16:28     ` Dan Williams
2018-03-22 16:28       ` Dan Williams
2018-03-22 17:02       ` Christoph Hellwig
2018-03-22 17:02         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4gknYC3WUEEfGjNH8ufFvokdZarSaZUm-cczCXyEz_D0w@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.