From: Dan Williams <dan.j.williams@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
linux-remoteproc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 16:12:29 -0700 [thread overview]
Message-ID: <CAPcyv4iqK-3X5ngXs6HjTQhtW0DEu5KsBcgAY1nVJCWPnSagGw@mail.gmail.com> (raw)
In-Reply-To: <1493420656.1873.22.camel@perches.com>
On Fri, Apr 28, 2017 at 4:04 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote:
>> ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e.
>> that the hexdump happens in the KERN_DEBUG case
>
> I think you are confusing KERN_DEBUG, a logging level, with a
> preprocessor #define of DEBUG.
Indeed I am.
>
>> which I don't want. I
>> want the call to be compiled out completely when it can't be
>> enabled/disabled dynamically.
>
> dev_dbg is compiled away completely when DEBUG is
> not defined and when CONFIG_DYNAMIC_DEBUG is not
> defined.
>
> This hex_dump facility should behave the same way.
>
>> I think we do need a hex_dump_dbg(), but that does not eliminate the
>> utility of / need for dynamic_hex_dump().
>
> dynamic_hex_dump should only exist when CONFIG_DYNAMIC_DEBUG
> is enabled and should otherwise be invisible to driver code.
>
So, I overlooked that Linus fixed this compile problem a while back with:
cdf17449af1d hexdump: do not print debug dumps for !CONFIG_DEBUG
Which predated the introduction of ACPI_NFIT_DEBUG. So I can just call
print_hex_dump_debug() and call it a day.
Sorry for the noise, Joe!
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Joe Perches <joe@perches.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 16:12:29 -0700 [thread overview]
Message-ID: <CAPcyv4iqK-3X5ngXs6HjTQhtW0DEu5KsBcgAY1nVJCWPnSagGw@mail.gmail.com> (raw)
In-Reply-To: <1493420656.1873.22.camel@perches.com>
On Fri, Apr 28, 2017 at 4:04 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote:
>> ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e.
>> that the hexdump happens in the KERN_DEBUG case
>
> I think you are confusing KERN_DEBUG, a logging level, with a
> preprocessor #define of DEBUG.
Indeed I am.
>
>> which I don't want. I
>> want the call to be compiled out completely when it can't be
>> enabled/disabled dynamically.
>
> dev_dbg is compiled away completely when DEBUG is
> not defined and when CONFIG_DYNAMIC_DEBUG is not
> defined.
>
> This hex_dump facility should behave the same way.
>
>> I think we do need a hex_dump_dbg(), but that does not eliminate the
>> utility of / need for dynamic_hex_dump().
>
> dynamic_hex_dump should only exist when CONFIG_DYNAMIC_DEBUG
> is enabled and should otherwise be invisible to driver code.
>
So, I overlooked that Linus fixed this compile problem a while back with:
cdf17449af1d hexdump: do not print debug dumps for !CONFIG_DEBUG
Which predated the introduction of ACPI_NFIT_DEBUG. So I can just call
print_hex_dump_debug() and call it a day.
Sorry for the noise, Joe!
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
"linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>,
linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Bjorn Andersson
<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Linux ACPI <linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jason Baron <jbaron-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 16:12:29 -0700 [thread overview]
Message-ID: <CAPcyv4iqK-3X5ngXs6HjTQhtW0DEu5KsBcgAY1nVJCWPnSagGw@mail.gmail.com> (raw)
In-Reply-To: <1493420656.1873.22.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
On Fri, Apr 28, 2017 at 4:04 PM, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
> On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote:
>> ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e.
>> that the hexdump happens in the KERN_DEBUG case
>
> I think you are confusing KERN_DEBUG, a logging level, with a
> preprocessor #define of DEBUG.
Indeed I am.
>
>> which I don't want. I
>> want the call to be compiled out completely when it can't be
>> enabled/disabled dynamically.
>
> dev_dbg is compiled away completely when DEBUG is
> not defined and when CONFIG_DYNAMIC_DEBUG is not
> defined.
>
> This hex_dump facility should behave the same way.
>
>> I think we do need a hex_dump_dbg(), but that does not eliminate the
>> utility of / need for dynamic_hex_dump().
>
> dynamic_hex_dump should only exist when CONFIG_DYNAMIC_DEBUG
> is enabled and should otherwise be invisible to driver code.
>
So, I overlooked that Linus fixed this compile problem a while back with:
cdf17449af1d hexdump: do not print debug dumps for !CONFIG_DEBUG
Which predated the introduction of ACPI_NFIT_DEBUG. So I can just call
print_hex_dump_debug() and call it a day.
Sorry for the noise, Joe!
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Joe Perches <joe@perches.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup
Date: Fri, 28 Apr 2017 16:12:29 -0700 [thread overview]
Message-ID: <CAPcyv4iqK-3X5ngXs6HjTQhtW0DEu5KsBcgAY1nVJCWPnSagGw@mail.gmail.com> (raw)
In-Reply-To: <1493420656.1873.22.camel@perches.com>
On Fri, Apr 28, 2017 at 4:04 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote:
>> ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e.
>> that the hexdump happens in the KERN_DEBUG case
>
> I think you are confusing KERN_DEBUG, a logging level, with a
> preprocessor #define of DEBUG.
Indeed I am.
>
>> which I don't want. I
>> want the call to be compiled out completely when it can't be
>> enabled/disabled dynamically.
>
> dev_dbg is compiled away completely when DEBUG is
> not defined and when CONFIG_DYNAMIC_DEBUG is not
> defined.
>
> This hex_dump facility should behave the same way.
>
>> I think we do need a hex_dump_dbg(), but that does not eliminate the
>> utility of / need for dynamic_hex_dump().
>
> dynamic_hex_dump should only exist when CONFIG_DYNAMIC_DEBUG
> is enabled and should otherwise be invisible to driver code.
>
So, I overlooked that Linus fixed this compile problem a while back with:
cdf17449af1d hexdump: do not print debug dumps for !CONFIG_DEBUG
Which predated the introduction of ACPI_NFIT_DEBUG. So I can just call
print_hex_dump_debug() and call it a day.
Sorry for the noise, Joe!
next prev parent reply other threads:[~2017-04-28 23:12 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 21:28 [PATCH 0/3] dynamic_hex_dump cleanup Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:28 ` [PATCH 1/3] printk: provide generic dynamic_hex_dump fallback Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:28 ` Dan Williams
2017-04-28 21:29 ` [PATCH 2/3] virtio, rpmsg: switch to dynamic_hex_dump() Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-29 8:46 ` kbuild test robot
2017-04-29 8:46 ` kbuild test robot
2017-04-29 8:46 ` kbuild test robot
2017-04-29 8:46 ` kbuild test robot
2017-04-28 21:29 ` [PATCH 3/3] acpi, nfit: kill ACPI_NFIT_DEBUG, " Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 21:29 ` Dan Williams
2017-04-28 23:48 ` [PATCH v2] acpi, nfit: kill ACPI_NFIT_DEBUG Dan Williams
2017-04-28 23:48 ` Dan Williams
2017-04-28 23:48 ` Dan Williams
2017-04-28 21:49 ` [PATCH 0/3] dynamic_hex_dump cleanup Joe Perches
2017-04-28 21:49 ` Joe Perches
2017-04-28 21:49 ` Joe Perches
2017-04-28 21:49 ` Joe Perches
2017-04-28 21:52 ` Dan Williams
2017-04-28 21:52 ` Dan Williams
2017-04-28 21:52 ` Dan Williams
2017-04-28 22:07 ` Joe Perches
2017-04-28 22:07 ` Joe Perches
2017-04-28 22:07 ` Joe Perches
2017-04-28 22:07 ` Joe Perches
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:14 ` Dan Williams
2017-04-28 22:19 ` Dan Williams
2017-04-28 22:19 ` Dan Williams
2017-04-28 22:19 ` Dan Williams
2017-04-28 22:31 ` Joe Perches
2017-04-28 22:31 ` Joe Perches
2017-04-28 22:31 ` Joe Perches
2017-04-28 22:31 ` Joe Perches
2017-04-28 22:59 ` Dan Williams
2017-04-28 22:59 ` Dan Williams
2017-04-28 22:59 ` Dan Williams
2017-04-28 22:59 ` Dan Williams
2017-04-28 23:04 ` Joe Perches
2017-04-28 23:04 ` Joe Perches
2017-04-28 23:04 ` Joe Perches
2017-04-28 23:04 ` Joe Perches
2017-04-28 23:12 ` Dan Williams [this message]
2017-04-28 23:12 ` Dan Williams
2017-04-28 23:12 ` Dan Williams
2017-04-28 23:12 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4iqK-3X5ngXs6HjTQhtW0DEu5KsBcgAY1nVJCWPnSagGw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=jbaron@akamai.com \
--cc=joe@perches.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.