From: Dan Williams <dan.j.williams@intel.com>
To: alexander.h.duyck@linux.intel.com
Cc: "Pasha Tatashin" <pavel.tatashin@microsoft.com>,
"Michal Hocko" <mhocko@suse.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Dave Hansen" <dave.hansen@intel.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux MM" <linux-mm@kvack.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [mm PATCH] memremap: Fix reference count for pgmap in devm_memremap_pages
Date: Mon, 8 Oct 2018 17:20:54 -0700 [thread overview]
Message-ID: <CAPcyv4jB5S7DbYr+LmMNpD0teKrO2aoVfJxnSFPrswPCcs-Snw@mail.gmail.com> (raw)
In-Reply-To: <20181008233404.1909.37302.stgit@localhost.localdomain>
On Mon, Oct 8, 2018 at 4:34 PM Alexander Duyck
<alexander.h.duyck@linux.intel.com> wrote:
>
> In the earlier patch "mm: defer ZONE_DEVICE page initialization to the
> point where we init pgmap" I had overlooked the reference count that was
> being held per page on the pgmap. As a result on running the ndctl test
> "create.sh" we would call into devm_memremap_pages_release and encounter
> the following percpu reference count error and hang:
> WARNING: CPU: 30 PID: 0 at lib/percpu-refcount.c:155
> percpu_ref_switch_to_atomic_rcu+0xf3/0x120
>
> This patch addresses that by performing an update for all of the device
> PFNs in a single call. In my testing this seems to resolve the issue while
> still allowing us to retain the improvements seen in memory initialization.
>
> Reported-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Dan Williams <dan.j.williams@intel.com>
Thanks Alex!
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: alexander.h.duyck@linux.intel.com
Cc: "Linux MM" <linux-mm@kvack.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Pasha Tatashin" <pavel.tatashin@microsoft.com>,
"Michal Hocko" <mhocko@suse.com>,
"Dave Jiang" <dave.jiang@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Dave Hansen" <dave.hansen@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [mm PATCH] memremap: Fix reference count for pgmap in devm_memremap_pages
Date: Mon, 8 Oct 2018 17:20:54 -0700 [thread overview]
Message-ID: <CAPcyv4jB5S7DbYr+LmMNpD0teKrO2aoVfJxnSFPrswPCcs-Snw@mail.gmail.com> (raw)
In-Reply-To: <20181008233404.1909.37302.stgit@localhost.localdomain>
On Mon, Oct 8, 2018 at 4:34 PM Alexander Duyck
<alexander.h.duyck@linux.intel.com> wrote:
>
> In the earlier patch "mm: defer ZONE_DEVICE page initialization to the
> point where we init pgmap" I had overlooked the reference count that was
> being held per page on the pgmap. As a result on running the ndctl test
> "create.sh" we would call into devm_memremap_pages_release and encounter
> the following percpu reference count error and hang:
> WARNING: CPU: 30 PID: 0 at lib/percpu-refcount.c:155
> percpu_ref_switch_to_atomic_rcu+0xf3/0x120
>
> This patch addresses that by performing an update for all of the device
> PFNs in a single call. In my testing this seems to resolve the issue while
> still allowing us to retain the improvements seen in memory initialization.
>
> Reported-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Dan Williams <dan.j.williams@intel.com>
Thanks Alex!
next prev parent reply other threads:[~2018-10-09 0:21 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 20:18 [PATCH v5 0/4] Address issues slowing persistent memory initialization Alexander Duyck
2018-09-25 20:18 ` Alexander Duyck
2018-09-25 20:19 ` [PATCH v5 1/4] mm: Remove now defunct NO_BOOTMEM from depends list for deferred init Alexander Duyck
2018-09-25 20:19 ` Alexander Duyck
2018-09-25 21:05 ` Mike Rapoport
2018-09-25 21:05 ` Mike Rapoport
2018-09-25 20:20 ` [PATCH v5 2/4] mm: Provide kernel parameter to allow disabling page init poisoning Alexander Duyck
2018-09-25 20:20 ` Alexander Duyck
2018-09-25 20:26 ` Dave Hansen
2018-09-25 20:26 ` Dave Hansen
2018-09-25 20:38 ` Alexander Duyck
2018-09-25 20:38 ` Alexander Duyck
2018-09-25 22:14 ` Dave Hansen
2018-09-25 22:14 ` Dave Hansen
2018-09-25 22:14 ` Dave Hansen
2018-09-25 22:27 ` Alexander Duyck
2018-09-25 22:27 ` Alexander Duyck
2018-09-25 22:27 ` Alexander Duyck
2018-09-26 7:38 ` Michal Hocko
2018-09-26 7:38 ` Michal Hocko
2018-09-26 15:24 ` Alexander Duyck
2018-09-26 15:39 ` Michal Hocko
2018-09-26 15:39 ` Michal Hocko
2018-09-26 15:41 ` Dave Hansen
2018-09-26 15:41 ` Dave Hansen
2018-09-26 16:18 ` Alexander Duyck
2018-09-26 15:36 ` Dave Hansen
2018-09-26 22:36 ` Andrew Morton
2018-09-26 22:36 ` Andrew Morton
2018-09-25 20:20 ` [PATCH v5 3/4] mm: Create non-atomic version of SetPageReserved for init use Alexander Duyck
2018-09-25 20:20 ` Alexander Duyck
2018-09-25 20:21 ` [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap Alexander Duyck
2018-09-25 20:21 ` Alexander Duyck
2018-09-26 7:55 ` Michal Hocko
2018-09-26 18:25 ` Alexander Duyck
2018-09-26 18:25 ` Alexander Duyck
2018-09-26 18:52 ` Dan Williams
2018-09-26 18:52 ` Dan Williams
2018-09-27 11:20 ` Michal Hocko
2018-09-27 11:20 ` Michal Hocko
2018-09-27 11:09 ` Michal Hocko
2018-09-27 11:09 ` Michal Hocko
2018-09-27 12:25 ` Oscar Salvador
2018-09-27 13:13 ` Michal Hocko
2018-09-27 14:50 ` Oscar Salvador
2018-09-27 14:50 ` Oscar Salvador
2018-09-27 14:50 ` Oscar Salvador
2018-09-27 15:41 ` David Hildenbrand
2018-09-27 15:41 ` David Hildenbrand
2018-09-28 8:12 ` Oscar Salvador
2018-09-28 8:12 ` Oscar Salvador
2018-09-28 8:44 ` Oscar Salvador
2018-09-28 8:44 ` Oscar Salvador
2018-09-28 15:50 ` Dan Williams
2018-09-28 15:50 ` Dan Williams
2018-09-27 12:32 ` Oscar Salvador
2018-10-08 21:01 ` Dan Williams
2018-10-08 21:01 ` Dan Williams
2018-10-08 21:38 ` Alexander Duyck
2018-10-08 21:38 ` Alexander Duyck
2018-10-08 22:00 ` Dan Williams
2018-10-08 22:00 ` Dan Williams
2018-10-08 22:00 ` Dan Williams
2018-10-08 22:07 ` Alexander Duyck
2018-10-08 22:07 ` Alexander Duyck
2018-10-08 22:36 ` Alexander Duyck
2018-10-08 22:36 ` Alexander Duyck
2018-10-08 22:59 ` Dan Williams
2018-10-08 23:34 ` [mm PATCH] memremap: Fix reference count for pgmap in devm_memremap_pages Alexander Duyck
2018-10-08 23:34 ` Alexander Duyck
2018-10-09 0:20 ` Dan Williams [this message]
2018-10-09 0:20 ` Dan Williams
2018-10-09 17:00 ` [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap Yi Zhang
2018-10-09 17:00 ` Yi Zhang
2018-10-09 18:04 ` Dan Williams
2018-10-09 18:04 ` Dan Williams
2018-10-09 20:26 ` Alexander Duyck
2018-10-09 20:26 ` Alexander Duyck
2018-10-09 21:19 ` Dan Williams
2018-10-09 21:19 ` Dan Williams
2018-10-10 12:52 ` Yi Zhang
2018-10-10 12:52 ` Yi Zhang
2018-10-10 15:27 ` Alexander Duyck
2018-10-10 15:27 ` Alexander Duyck
2018-10-11 8:17 ` Yi Zhang
2018-10-11 8:17 ` Yi Zhang
2018-10-10 9:58 ` Michal Hocko
2018-10-10 16:39 ` Alexander Duyck
2018-10-10 16:39 ` Alexander Duyck
2018-10-10 17:24 ` Michal Hocko
2018-10-10 17:24 ` Michal Hocko
2018-10-10 17:39 ` Alexander Duyck
2018-10-10 17:39 ` Alexander Duyck
2018-10-10 17:53 ` Michal Hocko
2018-10-10 17:53 ` Michal Hocko
2018-10-10 18:13 ` Alexander Duyck
2018-10-10 18:13 ` Alexander Duyck
2018-10-10 18:52 ` Michal Hocko
2018-10-10 18:52 ` Michal Hocko
2018-10-11 8:55 ` Michal Hocko
2018-10-11 8:55 ` Michal Hocko
2018-10-11 17:38 ` Alexander Duyck
2018-10-11 18:22 ` Dan Williams
2018-10-11 18:22 ` Dan Williams
2018-10-17 7:52 ` Michal Hocko
2018-10-17 7:52 ` Michal Hocko
2018-10-17 15:02 ` Alexander Duyck
2018-10-17 15:02 ` Alexander Duyck
2018-10-29 14:12 ` Michal Hocko
2018-10-29 14:12 ` Michal Hocko
2018-10-29 15:59 ` Alexander Duyck
2018-10-29 15:59 ` Alexander Duyck
2018-10-29 15:59 ` Alexander Duyck
2018-10-29 16:35 ` Michal Hocko
2018-10-29 16:35 ` Michal Hocko
2018-10-29 17:01 ` Alexander Duyck
2018-10-29 17:24 ` Michal Hocko
2018-10-29 17:24 ` Michal Hocko
2018-10-29 17:34 ` Dan Williams
2018-10-29 17:34 ` Dan Williams
2018-10-29 17:45 ` Michal Hocko
2018-10-29 17:45 ` Michal Hocko
2018-10-29 17:42 ` Alexander Duyck
2018-10-29 17:42 ` Alexander Duyck
2018-10-29 18:18 ` Michal Hocko
2018-10-29 18:18 ` Michal Hocko
2018-10-29 19:59 ` Alexander Duyck
2018-10-29 19:59 ` Alexander Duyck
2018-10-30 6:29 ` Michal Hocko
2018-10-30 6:29 ` Michal Hocko
2018-10-30 6:55 ` Dan Williams
2018-10-30 8:17 ` Michal Hocko
2018-10-30 8:17 ` Michal Hocko
2018-10-30 15:57 ` Dan Williams
2018-10-30 8:05 ` Oscar Salvador
2018-10-29 15:49 ` Dan Williams
2018-10-29 15:49 ` Dan Williams
2018-10-29 15:56 ` Michal Hocko
2018-10-10 18:18 ` Dan Williams
2018-10-10 18:18 ` Dan Williams
2018-10-11 8:39 ` Yi Zhang
2018-10-11 8:39 ` Yi Zhang
2018-10-11 15:38 ` Alexander Duyck
2018-10-11 15:38 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jB5S7DbYr+LmMNpD0teKrO2aoVfJxnSFPrswPCcs-Snw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=pavel.tatashin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.