From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jane Chu <jane.chu@oracle.com>, Michal Hocko <mhocko@suse.com>,
Jan Kara <jack@suse.cz>, Matthew Wilcox <mawilcox@microsoft.com>,
KVM list <kvm@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Alex Williamson <alex.williamson@redhat.com>,
Gerd Rausch <gerd.rausch@oracle.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes
Date: Fri, 2 Mar 2018 15:49:45 -0800 [thread overview]
Message-ID: <CAPcyv4jM=N=wjnK4gWxHu0Fk9VXnfReLf6shW6mbzvf3sahjrQ@mail.gmail.com> (raw)
In-Reply-To: <20180302225734.GE31240@lst.de>
On Fri, Mar 2, 2018 at 2:57 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote:
>> They are indeed a hodge-podge. The problem is that the current
>> IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with
>> IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks
>> you propose for the next merge window.
>
> The only thing broken about IS_DAX are the code elimination games
> based on the CONFIG_* flags. Remove those and just add proper stubs
> for the dax routines and everything will be fine for now until we can
> kill that inode flag.
>
> IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't
> helping anyone.
Ok, I'll take another shot at something suitable for 4.16, but without
these new helpers...
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
KVM list <kvm@vger.kernel.org>,
Haozhong Zhang <haozhong.zhang@intel.com>,
Jane Chu <jane.chu@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Gerd Rausch <gerd.rausch@oracle.com>,
stable <stable@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
"Theodore Ts'o" <tytso@mit.edu>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes
Date: Fri, 2 Mar 2018 15:49:45 -0800 [thread overview]
Message-ID: <CAPcyv4jM=N=wjnK4gWxHu0Fk9VXnfReLf6shW6mbzvf3sahjrQ@mail.gmail.com> (raw)
In-Reply-To: <20180302225734.GE31240@lst.de>
On Fri, Mar 2, 2018 at 2:57 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote:
>> They are indeed a hodge-podge. The problem is that the current
>> IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with
>> IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks
>> you propose for the next merge window.
>
> The only thing broken about IS_DAX are the code elimination games
> based on the CONFIG_* flags. Remove those and just add proper stubs
> for the dax routines and everything will be fine for now until we can
> kill that inode flag.
>
> IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't
> helping anyone.
Ok, I'll take another shot at something suitable for 4.16, but without
these new helpers...
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
KVM list <kvm@vger.kernel.org>,
Haozhong Zhang <haozhong.zhang@intel.com>,
Jane Chu <jane.chu@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Gerd Rausch <gerd.rausch@oracle.com>,
stable <stable@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
"Theodore Ts'o" <tytso@mit.edu>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes
Date: Fri, 2 Mar 2018 15:49:45 -0800 [thread overview]
Message-ID: <CAPcyv4jM=N=wjnK4gWxHu0Fk9VXnfReLf6shW6mbzvf3sahjrQ@mail.gmail.com> (raw)
In-Reply-To: <20180302225734.GE31240@lst.de>
On Fri, Mar 2, 2018 at 2:57 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote:
>> They are indeed a hodge-podge. The problem is that the current
>> IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with
>> IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks
>> you propose for the next merge window.
>
> The only thing broken about IS_DAX are the code elimination games
> based on the CONFIG_* flags. Remove those and just add proper stubs
> for the dax routines and everything will be fine for now until we can
> kill that inode flag.
>
> IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't
> helping anyone.
Ok, I'll take another shot at something suitable for 4.16, but without
these new helpers...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Jane Chu <jane.chu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>,
Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
Matthew Wilcox <mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
KVM list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Darrick J. Wong"
<darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-nvdimm
<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-xfs <linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
Alex Williamson
<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Gerd Rausch <gerd.rausch-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Andreas Dilger
<adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>,
Alexander Viro
<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>
Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes
Date: Fri, 2 Mar 2018 15:49:45 -0800 [thread overview]
Message-ID: <CAPcyv4jM=N=wjnK4gWxHu0Fk9VXnfReLf6shW6mbzvf3sahjrQ@mail.gmail.com> (raw)
In-Reply-To: <20180302225734.GE31240-jcswGhMUV9g@public.gmane.org>
On Fri, Mar 2, 2018 at 2:57 PM, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
> On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote:
>> They are indeed a hodge-podge. The problem is that the current
>> IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with
>> IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks
>> you propose for the next merge window.
>
> The only thing broken about IS_DAX are the code elimination games
> based on the CONFIG_* flags. Remove those and just add proper stubs
> for the dax routines and everything will be fine for now until we can
> kill that inode flag.
>
> IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't
> helping anyone.
Ok, I'll take another shot at something suitable for 4.16, but without
these new helpers...
next prev parent reply other threads:[~2018-03-02 23:43 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 3:53 [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` [PATCH v5 01/12] dax: fix vma_is_fsdax() helper Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 22:52 ` Christoph Hellwig
2018-03-02 22:52 ` Christoph Hellwig
2018-03-02 22:52 ` Christoph Hellwig
2018-03-02 3:53 ` [PATCH v5 02/12] dax: introduce IS_DEVDAX() and IS_FSDAX() Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 17:45 ` Darrick J. Wong
2018-03-02 17:45 ` Darrick J. Wong
2018-03-02 18:37 ` Dan Williams
2018-03-02 18:37 ` Dan Williams
2018-03-02 18:37 ` Dan Williams
2018-03-02 19:06 ` [PATCH v6] " Dan Williams
2018-03-02 19:06 ` Dan Williams
2018-03-02 19:06 ` Dan Williams
2018-03-02 19:06 ` Dan Williams
2018-03-02 19:06 ` Dan Williams
2018-03-02 19:58 ` Darrick J. Wong
2018-03-02 19:58 ` Darrick J. Wong
2018-03-02 22:53 ` [PATCH v5 02/12] " Christoph Hellwig
2018-03-02 22:53 ` Christoph Hellwig
2018-03-02 22:53 ` Christoph Hellwig
2018-03-02 3:53 ` [PATCH v5 03/12] ext2, dax: finish implementing dax_sem helpers Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` [PATCH v5 04/12] ext2, dax: define ext2_dax_*() infrastructure in all cases Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:53 ` Dan Williams
2018-03-02 3:54 ` [PATCH v5 05/12] ext4, dax: define ext4_dax_*() " Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` [PATCH v5 06/12] ext2, dax: replace IS_DAX() with IS_FSDAX() Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` [PATCH v5 07/12] ext4, " Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` [PATCH v5 08/12] xfs, " Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 17:46 ` Darrick J. Wong
2018-03-02 17:46 ` Darrick J. Wong
2018-03-02 3:54 ` [PATCH v5 09/12] mm, dax: replace IS_DAX() with IS_DEVDAX() or IS_FSDAX() Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 22:54 ` Christoph Hellwig
2018-03-02 22:54 ` Christoph Hellwig
2018-03-02 3:54 ` [PATCH v5 10/12] fs, dax: kill IS_DAX() Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` [PATCH v5 11/12] dax: fix S_DAX definition Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` [PATCH v5 12/12] vfio: disable filesystem-dax page pinning Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 3:54 ` Dan Williams
2018-03-02 22:10 ` [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes Christoph Hellwig
2018-03-02 22:10 ` Christoph Hellwig
2018-03-02 22:10 ` Christoph Hellwig
2018-03-02 22:21 ` Dan Williams
2018-03-02 22:21 ` Dan Williams
2018-03-02 22:21 ` Dan Williams
2018-03-02 22:21 ` Dan Williams
2018-03-02 22:57 ` Christoph Hellwig
2018-03-02 22:57 ` Christoph Hellwig
2018-03-02 22:57 ` Christoph Hellwig
2018-03-02 22:57 ` Christoph Hellwig
2018-03-02 23:49 ` Dan Williams [this message]
2018-03-02 23:49 ` Dan Williams
2018-03-02 23:49 ` Dan Williams
2018-03-02 23:49 ` Dan Williams
2018-03-03 2:19 ` Dan Williams
2018-03-03 2:19 ` Dan Williams
2018-03-03 2:19 ` Dan Williams
2018-03-03 2:19 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jM=N=wjnK4gWxHu0Fk9VXnfReLf6shW6mbzvf3sahjrQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=alex.williamson@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=gerd.rausch@oracle.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jane.chu@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mhocko@suse.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.