From: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Aneesh Kumar K.V"
<aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
Cc: linux-nvdimm <linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH v9 0/7] Mark the namespace disabled on pfn superblock mismatch
Date: Fri, 6 Sep 2019 10:49:05 -0700 [thread overview]
Message-ID: <CAPcyv4jsDeZ27cfCQbeNtwxWhaUb-nT-U=mQnMM18GL7yxc7RQ@mail.gmail.com> (raw)
In-Reply-To: <20190905154603.10349-1-aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
On Thu, Sep 5, 2019 at 8:46 AM Aneesh Kumar K.V
<aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org> wrote:
>
> We add new members to pfn superblock (PAGE_SIZE and struct page size) in this series.
> This is now checked while initializing the namespace. If we find a mismatch we mark
> the namespace disabled.
>
> This series also handle configs where hugepage support is not enabled by default.
> This can result in different align restrictions for dax namespace. We mark the
> dax namespace disabled if we find the alignment not supported.
>
> Changes from v8:
> * updated patch 7 for addressing review feedback
>
> Changes from v6:
> * Formatting changes
>
> Changes from v5:
> * Split patch 3
> * Update commit message
> * Add MAX_STRUCT_PAGE_SIZE with value 64 and use that when allocating reserve block
> * Add BUILD_BUG_ON if we find sizeof(struct page) > 64
>
>
>
> Aneesh Kumar K.V (6):
> libnvdimm/pmem: Advance namespace seed for specific probe errors
> libnvdimm/pfn_dev: Add a build check to make sure we notice when
> struct page size change
> libnvdimm/pfn_dev: Add page size and struct page size to pfn
> superblock
> libnvdimm/label: Remove the dpa align check
> libnvdimm: Use PAGE_SIZE instead of SZ_4K for align check
> libnvdimm/dax: Pick the right alignment default when creating dax
> devices
>
> Dan Williams (1):
> libnvdimm/region: Rewrite _probe_success() to _advance_seeds()
>
> drivers/nvdimm/bus.c | 8 +--
> drivers/nvdimm/label.c | 5 --
> drivers/nvdimm/namespace_devs.c | 40 +++++++++---
> drivers/nvdimm/nd-core.h | 3 +-
> drivers/nvdimm/nd.h | 10 +--
> drivers/nvdimm/pfn.h | 5 +-
> drivers/nvdimm/pfn_devs.c | 110 +++++++++++++++++++++++++-------
> drivers/nvdimm/pmem.c | 29 +++++++--
> drivers/nvdimm/region_devs.c | 76 ++++------------------
> include/linux/huge_mm.h | 7 +-
> 10 files changed, 176 insertions(+), 117 deletions(-)
Looks good, 0day has no complaints and this passes all the current
unit tests. I'll get it pushed out for v5.4 consideration. Thanks
Aneesh!
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v9 0/7] Mark the namespace disabled on pfn superblock mismatch
Date: Fri, 6 Sep 2019 10:49:05 -0700 [thread overview]
Message-ID: <CAPcyv4jsDeZ27cfCQbeNtwxWhaUb-nT-U=mQnMM18GL7yxc7RQ@mail.gmail.com> (raw)
Message-ID: <20190906174905.65vre-ZzR1yzOvOQxUcvVBqdl4EaDdXAkWsqFfO0ThE@z> (raw)
In-Reply-To: <20190905154603.10349-1-aneesh.kumar@linux.ibm.com>
On Thu, Sep 5, 2019 at 8:46 AM Aneesh Kumar K.V
<aneesh.kumar@linux.ibm.com> wrote:
>
> We add new members to pfn superblock (PAGE_SIZE and struct page size) in this series.
> This is now checked while initializing the namespace. If we find a mismatch we mark
> the namespace disabled.
>
> This series also handle configs where hugepage support is not enabled by default.
> This can result in different align restrictions for dax namespace. We mark the
> dax namespace disabled if we find the alignment not supported.
>
> Changes from v8:
> * updated patch 7 for addressing review feedback
>
> Changes from v6:
> * Formatting changes
>
> Changes from v5:
> * Split patch 3
> * Update commit message
> * Add MAX_STRUCT_PAGE_SIZE with value 64 and use that when allocating reserve block
> * Add BUILD_BUG_ON if we find sizeof(struct page) > 64
>
>
>
> Aneesh Kumar K.V (6):
> libnvdimm/pmem: Advance namespace seed for specific probe errors
> libnvdimm/pfn_dev: Add a build check to make sure we notice when
> struct page size change
> libnvdimm/pfn_dev: Add page size and struct page size to pfn
> superblock
> libnvdimm/label: Remove the dpa align check
> libnvdimm: Use PAGE_SIZE instead of SZ_4K for align check
> libnvdimm/dax: Pick the right alignment default when creating dax
> devices
>
> Dan Williams (1):
> libnvdimm/region: Rewrite _probe_success() to _advance_seeds()
>
> drivers/nvdimm/bus.c | 8 +--
> drivers/nvdimm/label.c | 5 --
> drivers/nvdimm/namespace_devs.c | 40 +++++++++---
> drivers/nvdimm/nd-core.h | 3 +-
> drivers/nvdimm/nd.h | 10 +--
> drivers/nvdimm/pfn.h | 5 +-
> drivers/nvdimm/pfn_devs.c | 110 +++++++++++++++++++++++++-------
> drivers/nvdimm/pmem.c | 29 +++++++--
> drivers/nvdimm/region_devs.c | 76 ++++------------------
> include/linux/huge_mm.h | 7 +-
> 10 files changed, 176 insertions(+), 117 deletions(-)
Looks good, 0day has no complaints and this passes all the current
unit tests. I'll get it pushed out for v5.4 consideration. Thanks
Aneesh!
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-09-06 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 15:45 [PATCH v9 0/7] Mark the namespace disabled on pfn superblock mismatch Aneesh Kumar K.V
[not found] ` <20190905154603.10349-1-aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
2019-09-05 15:45 ` [PATCH v9 1/7] libnvdimm/region: Rewrite _probe_success() to _advance_seeds() Aneesh Kumar K.V
2019-09-05 15:45 ` [PATCH v9 2/7] libnvdimm/pmem: Advance namespace seed for specific probe errors Aneesh Kumar K.V
2019-09-05 15:45 ` [PATCH v9 3/7] libnvdimm/pfn_dev: Add a build check to make sure we notice when struct page size change Aneesh Kumar K.V
2019-09-05 15:46 ` [PATCH v9 4/7] libnvdimm/pfn_dev: Add page size and struct page size to pfn superblock Aneesh Kumar K.V
2019-09-05 15:46 ` [PATCH v9 5/7] libnvdimm/label: Remove the dpa align check Aneesh Kumar K.V
2019-09-05 15:46 ` [PATCH v9 6/7] libnvdimm: Use PAGE_SIZE instead of SZ_4K for " Aneesh Kumar K.V
2019-09-05 15:46 ` [PATCH v9 7/7] libnvdimm/dax: Pick the right alignment default when creating dax devices Aneesh Kumar K.V
2019-09-05 15:46 ` Aneesh Kumar K.V
2019-09-06 17:49 ` Dan Williams [this message]
2019-09-06 17:49 ` [PATCH v9 0/7] Mark the namespace disabled on pfn superblock mismatch Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jsDeZ27cfCQbeNtwxWhaUb-nT-U=mQnMM18GL7yxc7RQ@mail.gmail.com' \
--to=dan.j.williams-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.