From: Rahul Sharma <rahul.sharma@samsung.com> To: Jingoo Han <jg1.han@samsung.com> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, Kukjin Kim <kgene.kim@samsung.com>, Inki Dae <inki.dae@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, sunil joshi <joshi@samsung.com>, Doug Anderson <dianders@chromium.org>, Tomasz Figa <t.figa@samsung.com> Subject: Re: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420 Date: Thu, 8 May 2014 14:38:17 +0530 [thread overview] Message-ID: <CAPdUM4N1Y_hQikf47yijMqbNrecfJQuy3C-M10J5oaUuodPmaw@mail.gmail.com> (raw) In-Reply-To: <001f01cf6a87$56a86740$03f935c0$%han@samsung.com> Thanks Jingoo, On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote: > On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote: >> >> From: Rahul Sharma <Rahul.Sharma@samsung.com> >> >> Display controller HPD Gpio line is board specific. This patch >> is moving the pinctrl for hpd gpio line to the respective board >> file. >> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 ------- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 7 +++++++ >> 2 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> index e62c8eb..5848c42 100644 >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> @@ -59,13 +59,6 @@ >> interrupt-controller; >> #interrupt-cells = <2>; >> }; >> - >> - dp_hpd: dp_hpd { >> - samsung,pins = "gpx0-7"; >> - samsung,pin-function = <3>; >> - samsung,pin-pud = <0>; >> - samsung,pin-drv = <0>; >> - }; >> }; > > (+cc Doug Anderson, Tomasz Figa) > > 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific. > So, there should be "gpx0-7" part on chip specific dts file such as > 'exynos5420-pinctrl.dtsi'. > > However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin. > This is board specific. In my opinion, the following would look > better. In this way, this patch is not necessary. > > 1. case: Standard HPD pin is used. (smdk5420) > arch/arm/boot/dts/exynos5420-pinctrl.dts > pinctrl@13400000 { > dp_hpd: dp_hpd { > samsung,pins = "gpx0-7"; > samsung,pin-function = <3>; > samsung,pin-pud = <0>; > samsung,pin-drv = <0>; > }; > arch/arm/boot/dts/exynos5420-smdk5420.dts > dp-controller@145B0000 { > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > ... > > > 2. case: non-standard HPD pin such as GPIO is used. (peach pit) > arch/arm/boot/dts/exynos5420-peach-pit.dts > pinctrl@13400000 { > dp_hpd: dp_hpd { > samsung,pins = "gpx2-6"; > samsung,pin-function = <0>; > samsung,pin-pud = <3>; > samsung,pin-drv = <0>; > }; > dp-controller@145B0000 { > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > ... > samsung,hpd-gpio = <&gpx2 6 0>; > > Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts, > 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6", > respectively. > > A year ago, Doug Anderson and me agreed that standard HPD pin > part should be included to 'exynos5250-pinctrl.dtsi'. > (https://lkml.org/lkml/2013/5/11/134) > I wasn't aware of this discussion. It make sense. I will drop this patch. I need to choose some other name for this pin, say "peach_dp_hpd". Let me know if any concern. Regards, Rahul Sharma. > Best regards, > Jingoo Han > >> >> pinctrl@13410000 { >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 6910485..62d38c8 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -138,6 +138,13 @@ >> samsung,pin-pud = <1>; >> samsung,pin-drv = <0>; >> }; >> + >> + dp_hpd: dp_hpd { >> + samsung,pins = "gpx0-7"; >> + samsung,pin-function = <3>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; >> }; >> >> hdmi@14530000 { >> -- >> 1.7.9.5 >
WARNING: multiple messages have this Message-ID (diff)
From: rahul.sharma@samsung.com (Rahul Sharma) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420 Date: Thu, 8 May 2014 14:38:17 +0530 [thread overview] Message-ID: <CAPdUM4N1Y_hQikf47yijMqbNrecfJQuy3C-M10J5oaUuodPmaw@mail.gmail.com> (raw) In-Reply-To: <001f01cf6a87$56a86740$03f935c0$%han@samsung.com> Thanks Jingoo, On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote: > On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote: >> >> From: Rahul Sharma <Rahul.Sharma@samsung.com> >> >> Display controller HPD Gpio line is board specific. This patch >> is moving the pinctrl for hpd gpio line to the respective board >> file. >> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 ------- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 7 +++++++ >> 2 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> index e62c8eb..5848c42 100644 >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> @@ -59,13 +59,6 @@ >> interrupt-controller; >> #interrupt-cells = <2>; >> }; >> - >> - dp_hpd: dp_hpd { >> - samsung,pins = "gpx0-7"; >> - samsung,pin-function = <3>; >> - samsung,pin-pud = <0>; >> - samsung,pin-drv = <0>; >> - }; >> }; > > (+cc Doug Anderson, Tomasz Figa) > > 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific. > So, there should be "gpx0-7" part on chip specific dts file such as > 'exynos5420-pinctrl.dtsi'. > > However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin. > This is board specific. In my opinion, the following would look > better. In this way, this patch is not necessary. > > 1. case: Standard HPD pin is used. (smdk5420) > arch/arm/boot/dts/exynos5420-pinctrl.dts > pinctrl at 13400000 { > dp_hpd: dp_hpd { > samsung,pins = "gpx0-7"; > samsung,pin-function = <3>; > samsung,pin-pud = <0>; > samsung,pin-drv = <0>; > }; > arch/arm/boot/dts/exynos5420-smdk5420.dts > dp-controller at 145B0000 { > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > ... > > > 2. case: non-standard HPD pin such as GPIO is used. (peach pit) > arch/arm/boot/dts/exynos5420-peach-pit.dts > pinctrl at 13400000 { > dp_hpd: dp_hpd { > samsung,pins = "gpx2-6"; > samsung,pin-function = <0>; > samsung,pin-pud = <3>; > samsung,pin-drv = <0>; > }; > dp-controller at 145B0000 { > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > ... > samsung,hpd-gpio = <&gpx2 6 0>; > > Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts, > 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6", > respectively. > > A year ago, Doug Anderson and me agreed that standard HPD pin > part should be included to 'exynos5250-pinctrl.dtsi'. > (https://lkml.org/lkml/2013/5/11/134) > I wasn't aware of this discussion. It make sense. I will drop this patch. I need to choose some other name for this pin, say "peach_dp_hpd". Let me know if any concern. Regards, Rahul Sharma. > Best regards, > Jingoo Han > >> >> pinctrl at 13410000 { >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 6910485..62d38c8 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -138,6 +138,13 @@ >> samsung,pin-pud = <1>; >> samsung,pin-drv = <0>; >> }; >> + >> + dp_hpd: dp_hpd { >> + samsung,pins = "gpx0-7"; >> + samsung,pin-function = <3>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; >> }; >> >> hdmi at 14530000 { >> -- >> 1.7.9.5 >
next prev parent reply other threads:[~2014-05-08 9:08 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-20 11:48 [PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards Rahul Sharma 2014-04-20 11:48 ` Rahul Sharma 2014-04-20 11:48 ` [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420 Rahul Sharma 2014-04-20 11:48 ` Rahul Sharma 2014-05-08 6:32 ` Jingoo Han 2014-05-08 6:32 ` Jingoo Han 2014-05-08 9:08 ` Rahul Sharma [this message] 2014-05-08 9:08 ` Rahul Sharma 2014-05-09 0:45 ` Jingoo Han 2014-05-09 0:45 ` Jingoo Han 2014-05-09 1:17 ` Rahul Sharma 2014-05-09 1:17 ` Rahul Sharma 2014-04-20 11:48 ` [PATCH 2/5] ARM: dts: enable fimd for exynos5250 based snow board Rahul Sharma 2014-04-20 11:48 ` Rahul Sharma 2014-04-20 11:48 ` [PATCH 3/5] ARM: dts: enable dp-controller " Rahul Sharma 2014-04-20 11:48 ` Rahul Sharma 2014-05-07 13:36 ` Rahul Sharma 2014-05-07 13:36 ` Rahul Sharma 2014-04-20 11:48 ` [PATCH 4/5] ARM: dts: enable fimd for exynos5420 based peach-pit board Rahul Sharma 2014-04-20 11:48 ` Rahul Sharma 2014-04-20 11:48 ` [PATCH 5/5] ARM: dts: enable dp-controller " Rahul Sharma 2014-04-20 11:48 ` Rahul Sharma 2014-05-07 13:41 ` Rahul Sharma 2014-05-07 13:41 ` Rahul Sharma [not found] ` <1397994525-18537-1-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-04-25 9:45 ` [PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards Arun Kumar K 2014-04-25 9:45 ` Arun Kumar K 2014-05-08 5:39 ` Jingoo Han 2014-05-08 5:39 ` Jingoo Han
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPdUM4N1Y_hQikf47yijMqbNrecfJQuy3C-M10J5oaUuodPmaw@mail.gmail.com \ --to=rahul.sharma@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=inki.dae@samsung.com \ --cc=jg1.han@samsung.com \ --cc=joshi@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=t.figa@samsung.com \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.