From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
Richard Fontana <rfontana@redhat.com>,
Tzung-Bi Shih <tzungbi@google.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Thomas Gleixner <tglx@linutronix.de>,
"M, Naveen" <naveen.m@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [alsa-devel] [PATCH] ASoC: eve: implement set_bias_level function for rt5514
Date: Fri, 25 Oct 2019 16:14:46 +0000 [thread overview]
Message-ID: <CF33C36214C39B4496568E5578BE70C74032096B@PGSMSX108.gar.corp.intel.com> (raw)
In-Reply-To: <219281e5-d685-d584-0d22-5dcf3ca2bec2@linux.intel.com>
>
> Can you clarify if the rt5514 needs the MCLK while it's doing the hotword
> detection?
No, running the detection does not raise the bias level so the set_bias_level
will not be called. The mclk is only turned on then off in mixer control's handler
(rt5514_dsp_voice_wake_up_put) when enabling the hotword detection.
>
> My point is really that this patch uses a card-level BIAS indication, and I'd like
> to make sure this does not interfere with the audio DSP being in D3 state.
The function checks the name of dapm so it would only react when rt5514's
bias level is changing. And also the idle_bias_off of the codec driver is true so
it's target_bias_level should not be overwritten in the dapm_power_widgets()
function. The behavior should be similar to the previous patch which is using
supply widget.
Regards,
Brent
WARNING: multiple messages have this Message-ID (diff)
From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Tzung-Bi Shih <tzungbi@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Richard Fontana <rfontana@redhat.com>,
Mark Brown <broonie@kernel.org>, "M, Naveen" <naveen.m@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: eve: implement set_bias_level function for rt5514
Date: Fri, 25 Oct 2019 16:14:46 +0000 [thread overview]
Message-ID: <CF33C36214C39B4496568E5578BE70C74032096B@PGSMSX108.gar.corp.intel.com> (raw)
In-Reply-To: <219281e5-d685-d584-0d22-5dcf3ca2bec2@linux.intel.com>
>
> Can you clarify if the rt5514 needs the MCLK while it's doing the hotword
> detection?
No, running the detection does not raise the bias level so the set_bias_level
will not be called. The mclk is only turned on then off in mixer control's handler
(rt5514_dsp_voice_wake_up_put) when enabling the hotword detection.
>
> My point is really that this patch uses a card-level BIAS indication, and I'd like
> to make sure this does not interfere with the audio DSP being in D3 state.
The function checks the name of dapm so it would only react when rt5514's
bias level is changing. And also the idle_bias_off of the codec driver is true so
it's target_bias_level should not be overwritten in the dapm_power_widgets()
function. The behavior should be similar to the previous patch which is using
supply widget.
Regards,
Brent
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-25 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:11 [PATCH] ASoC: eve: implement set_bias_level function for rt5514 Brent Lu
2019-10-25 9:11 ` [alsa-devel] " Brent Lu
2019-10-25 14:05 ` Pierre-Louis Bossart
2019-10-25 14:05 ` Pierre-Louis Bossart
2019-10-25 14:43 ` Lu, Brent
2019-10-25 14:43 ` Lu, Brent
2019-10-25 14:48 ` Pierre-Louis Bossart
2019-10-25 14:48 ` Pierre-Louis Bossart
2019-10-25 16:14 ` Lu, Brent [this message]
2019-10-25 16:14 ` Lu, Brent
2019-10-25 16:57 ` Pierre-Louis Bossart
2019-10-25 16:57 ` Pierre-Louis Bossart
2019-10-28 14:56 ` [alsa-devel] Applied "ASoC: eve: implement set_bias_level function for rt5514" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF33C36214C39B4496568E5578BE70C74032096B@PGSMSX108.gar.corp.intel.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rfontana@redhat.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.