All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V3 0/9] nvmet: add ZBD backend support
Date: Wed, 2 Dec 2020 04:17:16 +0000	[thread overview]
Message-ID: <CH2PR04MB6522AD27DCACDEBC04EF6A00E7F30@CH2PR04MB6522.namprd04.prod.outlook.com> (raw)
In-Reply-To: BYAPR04MB49651C09824B2C82E44DB79C86F40@BYAPR04MB4965.namprd04.prod.outlook.com

On 2020/12/02 7:34, Chaitanya Kulkarni wrote:
> On 11/30/20 22:47, Damien Le Moal wrote:
>> This passes for me:
>>
>> ./zonefs-tests.sh -t 0012 /dev/nullb0
>> Gathering information on /dev/nullb0...
>> zonefs-tests on /dev/nullb0:
>>   4 zones (0 conventional zones, 4 sequential zones)
>>   524288 512B sectors zone size (256 MiB)
>>   1 max open zones
>> Running tests
>>   Test 0012:  mkzonefs (invalid device)                            ... PASS
>>
>> 1 / 1 tests passed
>>
>> This test create a a regular nullb device and tries mkzonefs on it, which should
>> fail since the block device is not zoned. In your case, it looks like the test
>> endup using an existing zoned nullb device, which should not happen (nullb4 and
>> nullb5). How many nullb devices do you have on that system ?
> 
> True, my test script creates random number nvmet namespaces and nullblk
> devices.
> 
> I think testcase is reading the wrong device, let me finish the V4 with
> removing
> 
> bio checks as per your comments and I'll look into this.

I pushed in zonefs test fix for this. Please try again, it should pass now.


-- 
Damien Le Moal
Western Digital Research

WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V3 0/9] nvmet: add ZBD backend support
Date: Wed, 2 Dec 2020 04:17:16 +0000	[thread overview]
Message-ID: <CH2PR04MB6522AD27DCACDEBC04EF6A00E7F30@CH2PR04MB6522.namprd04.prod.outlook.com> (raw)
In-Reply-To: BYAPR04MB49651C09824B2C82E44DB79C86F40@BYAPR04MB4965.namprd04.prod.outlook.com

On 2020/12/02 7:34, Chaitanya Kulkarni wrote:
> On 11/30/20 22:47, Damien Le Moal wrote:
>> This passes for me:
>>
>> ./zonefs-tests.sh -t 0012 /dev/nullb0
>> Gathering information on /dev/nullb0...
>> zonefs-tests on /dev/nullb0:
>>   4 zones (0 conventional zones, 4 sequential zones)
>>   524288 512B sectors zone size (256 MiB)
>>   1 max open zones
>> Running tests
>>   Test 0012:  mkzonefs (invalid device)                            ... PASS
>>
>> 1 / 1 tests passed
>>
>> This test create a a regular nullb device and tries mkzonefs on it, which should
>> fail since the block device is not zoned. In your case, it looks like the test
>> endup using an existing zoned nullb device, which should not happen (nullb4 and
>> nullb5). How many nullb devices do you have on that system ?
> 
> True, my test script creates random number nvmet namespaces and nullblk
> devices.
> 
> I think testcase is reading the wrong device, let me finish the V4 with
> removing
> 
> bio checks as per your comments and I'll look into this.

I pushed in zonefs test fix for this. Please try again, it should pass now.


-- 
Damien Le Moal
Western Digital Research

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-12-02  4:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2020-12-01  4:14 ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 1/9] block: export __bio_iov_append_get_pages() Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 2/9] nvmet: add ZNS support for bdev-ns Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 3/9] nvmet: trim down id-desclist to use req->ns Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 4/9] nvmet: add NVME_CSI_ZNS in ns-desc for zbdev Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 5/9] nvmet: add cns-cs-ctrl in id-ctrl for ZNS bdev Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 6/9] nvmet: add cns-cs-ns " Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 7/9] nvmet: add zns cmd effects to support zbdev Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 8/9] nvmet: add zns bdev config support Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  4:14 ` [PATCH V3 9/9] nvmet: add ZNS based I/O cmds handlers Chaitanya Kulkarni
2020-12-01  4:14   ` Chaitanya Kulkarni
2020-12-01  6:46 ` [PATCH V3 0/9] nvmet: add ZBD backend support Damien Le Moal
2020-12-01  6:46   ` Damien Le Moal
2020-12-01 22:34   ` Chaitanya Kulkarni
2020-12-01 22:34     ` Chaitanya Kulkarni
2020-12-02  4:17     ` Damien Le Moal [this message]
2020-12-02  4:17       ` Damien Le Moal
2020-12-02  6:26       ` Chaitanya Kulkarni
2020-12-02  6:26         ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR04MB6522AD27DCACDEBC04EF6A00E7F30@CH2PR04MB6522.namprd04.prod.outlook.com \
    --to=damien.lemoal@wdc.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.