All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Jason Baron" <jbaron@akamai.com>, <mcgrof@kernel.org>
Cc: <jim.cromie@gmail.com>, <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-modules@vger.kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>
Subject: Re: [PATCH v3 2/2] dyndbg: use the module notifier callbacks
Date: Mon, 06 Mar 2023 18:57:17 +0100	[thread overview]
Message-ID: <CQZHTJDTRJXM.3OF3W3WAZBLAK@vincent-arch> (raw)
In-Reply-To: <5884c688d10c9703fb0457f8839d6becc8657f8f.1677861177.git.jbaron@akamai.com>

> Bring dynamic debug in line with other subsystems by using the module
> notifier callbacks. This results in a net decrease in core module
> code.
>
> Additionally, Jim Cromie has a new dynamic debug classmap feature,
> which requires that jump labels be initialized prior to dynamic debug.
> Specifically, the new feature toggles a jump label from the existing
> dynamic_debug_setup() function. However, this does not currently work
> properly, because jump labels are initialized via the
> 'module_notify_list' notifier chain, which is invoked after the
> current call to dynamic_debug_setup(). Thus, this patch ensures that
> jump labels are initialized prior to dynamic debug by setting the
> dynamic debug notifier priority to 0, while jump labels have the
> higher priority of 1.
>
> Tested by Jim using his new test case, and I've verfied the correct
> printing via: # modprobe test_dynamic_debug dyndbg.
>
> Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@gmail.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@intel.com/
> Tested-by: Jim Cromie <jim.cromie@gmail.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> CC: Jim Cromie <jim.cromie@gmail.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Jason Baron <jbaron@akamai.com>

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

  parent reply	other threads:[~2023-03-06 17:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 16:50 [PATCH v3 0/2] dyndbg: let's use the module notifier callback Jason Baron
2023-03-03 16:50 ` [PATCH v3 1/2] dyndbg: remove unused 'base' arg from __ddebug_add_module() Jason Baron
2023-03-06 17:56   ` Vincenzo Palazzo
2023-03-03 16:50 ` [PATCH v3 2/2] dyndbg: use the module notifier callbacks Jason Baron
2023-03-04  6:51   ` kernel test robot
2023-03-06 17:57   ` Vincenzo Palazzo [this message]
2023-03-09 20:58     ` Luis Chamberlain
2023-03-03 22:06 ` [PATCH v3 0/2] dyndbg: let's use the module notifier callback Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CQZHTJDTRJXM.3OF3W3WAZBLAK@vincent-arch \
    --to=vincenzopalazzodev@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.