All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: mcgrof@kernel.org
Cc: jim.cromie@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Subject: [PATCH v3 0/2] dyndbg: let's use the module notifier callback
Date: Fri,  3 Mar 2023 11:50:54 -0500	[thread overview]
Message-ID: <cover.1677861177.git.jbaron@akamai.com> (raw)

Hi,

Jim Cromie hit a BUG() while toggling jump label branches in a module
before they were properly initialized. This isn't currently an issue,
but will be as part of his pending classmap series. Seems like we
should covert to using module callback notifier for dynamic debug
anyways to match other subsystems and remove core module code.
First patch is just a cleanup.

Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@xxxxxxxxx/

I've rebased this series onto modules-next tree. Although the first patch
is a cleanup entirely internal to dynamic debug I think it's a nice cleanup
to have as part of this series.

Thanks,

-Jason

v3:
-rebased to modules-next tree
-updated changelog as per Luis Chamberlain's suggestions

v2:
-Fix: error: field 'dyndbg_info' has incomplete type
 Reported-by: kernel test robot <lkp@intel.com>
 Link: https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@intel.com/
-make ddebug_remove_module() static


Jason Baron (2):
  dyndbg: remove unused 'base' arg from __ddebug_add_module()
  dyndbg: use the module notifier callbacks

 include/linux/dynamic_debug.h | 13 ---------
 include/linux/module.h        |  4 +++
 kernel/module/internal.h      |  2 --
 kernel/module/main.c          | 30 ++++++---------------
 lib/dynamic_debug.c           | 51 ++++++++++++++++++++++++++++-------
 5 files changed, 53 insertions(+), 47 deletions(-)

-- 
2.17.1


             reply	other threads:[~2023-03-03 16:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 16:50 Jason Baron [this message]
2023-03-03 16:50 ` [PATCH v3 1/2] dyndbg: remove unused 'base' arg from __ddebug_add_module() Jason Baron
2023-03-06 17:56   ` Vincenzo Palazzo
2023-03-03 16:50 ` [PATCH v3 2/2] dyndbg: use the module notifier callbacks Jason Baron
2023-03-04  6:51   ` kernel test robot
2023-03-06 17:57   ` Vincenzo Palazzo
2023-03-09 20:58     ` Luis Chamberlain
2023-03-03 22:06 ` [PATCH v3 0/2] dyndbg: let's use the module notifier callback Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1677861177.git.jbaron@akamai.com \
    --to=jbaron@akamai.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.