From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Greg KH" <greg@kroah.com>
Cc: <linux-pci@vger.kernel.org>, <robh@kernel.org>, <heiko@sntech.de>,
<kw@linux.com>, <shawn.lin@rock-chips.com>,
<linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
<linux-rockchip@lists.infradead.org>, <broonie@kernel.org>,
<bhelgaas@google.com>,
<linux-kernel-mentees@lists.linuxfoundation.org>,
<lpieralisi@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
"Dan Johansen" <strit@manjaro.org>
Subject: Re: [PATCH v1] drivers: pci: introduce configurable delay for Rockchip PCIe bus scan
Date: Wed, 10 May 2023 12:49:45 +0200 [thread overview]
Message-ID: <CSIJFLM445UI.1W405TTWNZYYU@vincent-arch> (raw)
In-Reply-To: <2023051014-foe-multiply-ffff@gregkh>
> On Tue, May 09, 2023 at 05:39:12PM +0200, Vincenzo Palazzo wrote:
> > --- a/drivers/pci/controller/pcie-rockchip-host.c
> > +++ b/drivers/pci/controller/pcie-rockchip-host.c
> > @@ -38,6 +38,10 @@
> > #include "../pci.h"
> > #include "pcie-rockchip.h"
> >
> > +/* bus_scan_delay - module parameter to override the
> > + * device tree value, which is 0 by default. */
> > +static int bus_scan_delay = -1;
>
> Please do not add new module parameters, this is not the 1990's anymore.
> We have per-device settings everywhere, this makes that impossible.
> Just use a DT value, if it is wrong, then fix the DT value! No need to
> have the kernel override it, that's not what DT files are for.
Thanks!
Cheers!
Vincent.
WARNING: multiple messages have this Message-ID (diff)
From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Greg KH" <greg@kroah.com>
Cc: kw@linux.com, heiko@sntech.de, robh@kernel.org,
linux-pci@vger.kernel.org, shawn.lin@rock-chips.com,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
linux-rockchip@lists.infradead.org, broonie@kernel.org,
bhelgaas@google.com,
linux-kernel-mentees@lists.linuxfoundation.org,
lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org,
Dan Johansen <strit@manjaro.org>
Subject: Re: [PATCH v1] drivers: pci: introduce configurable delay for Rockchip PCIe bus scan
Date: Wed, 10 May 2023 12:49:45 +0200 [thread overview]
Message-ID: <CSIJFLM445UI.1W405TTWNZYYU@vincent-arch> (raw)
In-Reply-To: <2023051014-foe-multiply-ffff@gregkh>
> On Tue, May 09, 2023 at 05:39:12PM +0200, Vincenzo Palazzo wrote:
> > --- a/drivers/pci/controller/pcie-rockchip-host.c
> > +++ b/drivers/pci/controller/pcie-rockchip-host.c
> > @@ -38,6 +38,10 @@
> > #include "../pci.h"
> > #include "pcie-rockchip.h"
> >
> > +/* bus_scan_delay - module parameter to override the
> > + * device tree value, which is 0 by default. */
> > +static int bus_scan_delay = -1;
>
> Please do not add new module parameters, this is not the 1990's anymore.
> We have per-device settings everywhere, this makes that impossible.
> Just use a DT value, if it is wrong, then fix the DT value! No need to
> have the kernel override it, that's not what DT files are for.
Thanks!
Cheers!
Vincent.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Greg KH" <greg@kroah.com>
Cc: <linux-pci@vger.kernel.org>, <robh@kernel.org>, <heiko@sntech.de>,
<kw@linux.com>, <shawn.lin@rock-chips.com>,
<linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
<linux-rockchip@lists.infradead.org>, <broonie@kernel.org>,
<bhelgaas@google.com>,
<linux-kernel-mentees@lists.linuxfoundation.org>,
<lpieralisi@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
"Dan Johansen" <strit@manjaro.org>
Subject: Re: [PATCH v1] drivers: pci: introduce configurable delay for Rockchip PCIe bus scan
Date: Wed, 10 May 2023 12:49:45 +0200 [thread overview]
Message-ID: <CSIJFLM445UI.1W405TTWNZYYU@vincent-arch> (raw)
In-Reply-To: <2023051014-foe-multiply-ffff@gregkh>
> On Tue, May 09, 2023 at 05:39:12PM +0200, Vincenzo Palazzo wrote:
> > --- a/drivers/pci/controller/pcie-rockchip-host.c
> > +++ b/drivers/pci/controller/pcie-rockchip-host.c
> > @@ -38,6 +38,10 @@
> > #include "../pci.h"
> > #include "pcie-rockchip.h"
> >
> > +/* bus_scan_delay - module parameter to override the
> > + * device tree value, which is 0 by default. */
> > +static int bus_scan_delay = -1;
>
> Please do not add new module parameters, this is not the 1990's anymore.
> We have per-device settings everywhere, this makes that impossible.
> Just use a DT value, if it is wrong, then fix the DT value! No need to
> have the kernel override it, that's not what DT files are for.
Thanks!
Cheers!
Vincent.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-05-10 10:49 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 15:39 [PATCH v1] drivers: pci: introduce configurable delay for Rockchip PCIe bus scan Vincenzo Palazzo
2023-05-09 15:39 ` Vincenzo Palazzo
2023-05-09 15:39 ` Vincenzo Palazzo
2023-05-09 21:19 ` Bjorn Helgaas
2023-05-09 21:19 ` Bjorn Helgaas
2023-05-09 21:19 ` Bjorn Helgaas
2023-05-10 0:11 ` Peter Geis
2023-05-10 0:11 ` Peter Geis
2023-05-10 0:11 ` Peter Geis
2023-05-10 11:16 ` Vincenzo Palazzo
2023-05-10 11:16 ` Vincenzo Palazzo
2023-05-10 11:16 ` Vincenzo Palazzo
2023-05-10 19:46 ` Peter Geis
2023-05-10 19:46 ` Peter Geis
2023-05-10 19:46 ` Peter Geis
2023-05-10 20:47 ` Bjorn Helgaas
2023-05-10 20:47 ` Bjorn Helgaas
2023-05-10 20:47 ` Bjorn Helgaas
2023-05-11 1:07 ` Peter Geis
2023-05-11 1:07 ` Peter Geis
2023-05-11 1:07 ` Peter Geis
2023-05-12 10:46 ` Vincenzo Palazzo
2023-05-12 10:46 ` Vincenzo Palazzo
2023-05-12 10:46 ` Vincenzo Palazzo
2023-05-13 1:24 ` Bjorn Helgaas
2023-05-13 1:24 ` Bjorn Helgaas
2023-05-13 1:24 ` Bjorn Helgaas
2023-05-13 11:40 ` Peter Geis
2023-05-13 11:40 ` Peter Geis
2023-05-13 11:40 ` Peter Geis
2023-05-15 11:04 ` Vincenzo Palazzo
2023-05-15 11:04 ` Vincenzo Palazzo
2023-05-15 11:04 ` Vincenzo Palazzo
2023-05-15 11:04 ` Vincenzo Palazzo
2023-05-15 16:51 ` Bjorn Helgaas
2023-05-15 16:51 ` Bjorn Helgaas
2023-05-15 16:51 ` Bjorn Helgaas
2023-05-15 16:51 ` Bjorn Helgaas
2023-05-15 20:52 ` Peter Geis
2023-05-15 20:52 ` Peter Geis
2023-05-15 20:52 ` Peter Geis
2023-05-15 20:52 ` Peter Geis
2023-07-12 15:42 ` Vincenzo Palazzo
2023-07-12 15:42 ` Vincenzo Palazzo
2023-07-12 15:42 ` Vincenzo Palazzo
2023-07-12 15:42 ` Vincenzo Palazzo
2023-05-10 11:35 ` Vincenzo Palazzo
2023-05-10 11:35 ` Vincenzo Palazzo
2023-05-10 11:35 ` Vincenzo Palazzo
2023-05-12 16:40 ` Vincenzo Palazzo
2023-05-12 16:40 ` Vincenzo Palazzo
2023-05-12 16:40 ` Vincenzo Palazzo
2023-05-10 7:57 ` Greg KH
2023-05-10 7:57 ` Greg KH
2023-05-10 7:57 ` Greg KH
2023-05-10 10:49 ` Vincenzo Palazzo [this message]
2023-05-10 10:49 ` Vincenzo Palazzo
2023-05-10 10:49 ` Vincenzo Palazzo
2023-11-20 4:15 ` Tom Fitzhenry
2023-11-20 4:15 ` Tom Fitzhenry
2023-11-20 4:15 ` Tom Fitzhenry
2023-11-20 4:15 ` Tom Fitzhenry
-- strict thread matches above, loose matches on Subject: below --
2023-05-01 20:14 Vincenzo Palazzo
2023-05-01 20:14 ` Vincenzo Palazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CSIJFLM445UI.1W405TTWNZYYU@vincent-arch \
--to=vincenzopalazzodev@gmail.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=greg@kroah.com \
--cc=heiko@sntech.de \
--cc=kw@linux.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=strit@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.