Re: [PATCH 07/10] block: mspro_blk: use blk_is_valid_logical_block_size

From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Maxim Levitsky <mlevitsk@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Keith Busch <kbusch@kernel.org>,
	Josef Bacik <josef@toxicpanda.com>,
	"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
	"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
	"open list:SCSI CDROM DRIVER" <linux-scsi@vger.kernel.org>,
	Tejun Heo <tj@kernel.org>, Bart Van Assche <bvanassche@acm.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Jason Wang <jasowang@redhat.com>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Colin Ian King <colin.king@canonical.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Ajay Joshi <Ajay.Joshi@wdc.com>, Ming Lei <ming.lei@redhat.com>,
	"open list:SONY MEMORYSTICK SUBSYSTEM"
	<linux-mmc@vger.kernel.org>, Christoph Hellwig <hch@lst.de>,
	Satya Tangirala <satyat@google.com>,
	"open list:NETWORK BLOCK DEVICE (NBD)" <nbd@other.debian.org>,
	Hou Tao <houtao1@huawei.com>, Jens Axboe <axboe@fb.com>,
	"open list:VIRTIO CORE AND NET DRIVERS" 
	<virtualization@lists.linux-foundation.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 07/10] block: mspro_blk: use blk_is_valid_logical_block_size
Date: Tue, 21 Jul 2020 11:17:38 +0000	[thread overview]
Message-ID: <CY4PR04MB375189EEABA0475AB9460DA0E7780@CY4PR04MB3751.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200721105239.8270-8-mlevitsk@redhat.com

On 2020/07/21 19:55, Maxim Levitsky wrote:
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
>  drivers/memstick/core/mspro_block.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
> index cd6b8d4f23350..86c9eb0aef512 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -1199,6 +1199,12 @@ static int mspro_block_init_disk(struct memstick_dev *card)
>  
>  	msb->page_size = be16_to_cpu(sys_info->unit_size);
>  
> +	if (!(blk_is_valid_logical_block_size(msb->page_size))) {
> +		dev_warn(&card->dev,
> +			 "unsupported block size %d", msb->page_size);
> +		return -EINVAL;
> +	}
> +
>  	mutex_lock(&mspro_block_disk_lock);
>  	disk_id = idr_alloc(&mspro_block_disk_idr, card, 0, 256, GFP_KERNEL);
>  	mutex_unlock(&mspro_block_disk_lock);
> 

Looks good to me.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

-- 
Damien Le Moal
Western Digital Research