Re: [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP

From: "Michael Walle" <michael@walle.cc>
To: "AceLan Kao" <acelan.kao@canonical.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Dhruva Gole" <d-gole@ti.com>,
	linux-mtd@lists.infradead.org, "Mark Brown" <broonie@kernel.org>,
	"Kamal Dasu" <kamal.dasu@broadcom.com>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Mario Kicherer" <dev@kicherer.org>,
	"Chuanhong Guo" <gch981213@gmail.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>
Subject: Re: [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP
Date: Wed, 13 Mar 2024 16:56:00 +0100	[thread overview]
Message-ID: <CZSQTVDX6QR1.1K5UGJUNPLM0S@walle.cc> (raw)
In-Reply-To: <20231129064311.272422-1-acelan.kao@canonical.com>

[-- Attachment #1.1: Type: text/plain, Size: 715 bytes --]

Hi,

I just had a quick look to see where Florians breakage could come
from and just noticed this:

> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 849ccfedbc72..e0b6715e5dfe 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -974,7 +974,7 @@ static int spinand_manufacturer_match(struct spinand_device *spinand,
>  		spinand->manufacturer = manufacturer;
>  		return 0;
>  	}
> -	return -ENOTSUPP;
> +	return -EOPNOTSUPP;
>  }
>  
>  static int spinand_id_detect(struct spinand_device *spinand)

This seems to be random as no other spi-nand ENOTSUPP was converted
but just this. Is there a reason for this, AceLan?

-michael

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/