All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Wunderlich <frank-w@public-files.de>
To: linux-mediatek@lists.infradead.org,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	ryder.lee@mediatek.com
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port
Date: Mon, 03 Aug 2020 20:02:38 +0200	[thread overview]
Message-ID: <D0A969BC-1BB3-4EBB-8D03-DAA610E62EBE@public-files.de> (raw)
In-Reply-To: <CAAOTY_-H3L=uJNJRF1VedbwXNwY2N-q4F6A-NsdNwbQswG0D-Q@mail.gmail.com>



Am 3. August 2020 18:27:02 MESZ schrieb Chun-Kuang Hu <chunkuang.hu@kernel.org>:

>But now I have a solution that you need not to modify binding document.
>Because now mt7623 has a different routing than mt2701, and this
>patch's approach is to use different port setting in each device tree.
>My solution is that these two SoC has different compatible string:
>"mediatek,mt7623-mmsys" and "mediatek,mt2701-mmsys". For now,
>"mediatek,mt2701-mmsys" has its data as
>
>static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
>.main_path = mt2701_mtk_ddp_main,
>.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
>.ext_path = mt2701_mtk_ddp_ext,
>.ext_len = ARRAY_SIZE(mt2701_mtk_ddp_ext),
>.shadow_register = true,
>};
>
>I think you could create a data for "mediatek,mt7623-mmsys" which has
>a different routing.

The paths are defined as this:

static enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = {	DDP_COMPONENT_OVL0,	DDP_COMPONENT_RDMA0,	DDP_COMPONENT_COLOR0,	DDP_COMPONENT_BLS,	DDP_COMPONENT_DSI0,};

static enum mtk_ddp_comp_id mt2701_mtk_ddp_ext[] = {	DDP_COMPONENT_RDMA1,	DDP_COMPONENT_DPI0,};

First thing i notice is that main=dsi and ext=dpi (hdmi). I guess dpi should be main,right? And bls is actually routed to dpi...how about the other components?

The 2 loops are not really clear to me (except 1st overwrites mt2701 main-path and second ext_path based on ports/endpoints) but this only applies from bls-dpi-hdmi-connector,not xdma/color or similar.
Or should be main-path (or external) only bls and dpi? It looks like it only swappes dpi and dsi in my case.

@Ryder Lee can you explain it?
regards Frank

WARNING: multiple messages have this Message-ID (diff)
From: Frank Wunderlich <frank-w@public-files.de>
To: linux-mediatek@lists.infradead.org,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	ryder.lee@mediatek.com
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port
Date: Mon, 03 Aug 2020 20:02:38 +0200	[thread overview]
Message-ID: <D0A969BC-1BB3-4EBB-8D03-DAA610E62EBE@public-files.de> (raw)
In-Reply-To: <CAAOTY_-H3L=uJNJRF1VedbwXNwY2N-q4F6A-NsdNwbQswG0D-Q@mail.gmail.com>



Am 3. August 2020 18:27:02 MESZ schrieb Chun-Kuang Hu <chunkuang.hu@kernel.org>:

>But now I have a solution that you need not to modify binding document.
>Because now mt7623 has a different routing than mt2701, and this
>patch's approach is to use different port setting in each device tree.
>My solution is that these two SoC has different compatible string:
>"mediatek,mt7623-mmsys" and "mediatek,mt2701-mmsys". For now,
>"mediatek,mt2701-mmsys" has its data as
>
>static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
>.main_path = mt2701_mtk_ddp_main,
>.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
>.ext_path = mt2701_mtk_ddp_ext,
>.ext_len = ARRAY_SIZE(mt2701_mtk_ddp_ext),
>.shadow_register = true,
>};
>
>I think you could create a data for "mediatek,mt7623-mmsys" which has
>a different routing.

The paths are defined as this:

static enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = {	DDP_COMPONENT_OVL0,	DDP_COMPONENT_RDMA0,	DDP_COMPONENT_COLOR0,	DDP_COMPONENT_BLS,	DDP_COMPONENT_DSI0,};

static enum mtk_ddp_comp_id mt2701_mtk_ddp_ext[] = {	DDP_COMPONENT_RDMA1,	DDP_COMPONENT_DPI0,};

First thing i notice is that main=dsi and ext=dpi (hdmi). I guess dpi should be main,right? And bls is actually routed to dpi...how about the other components?

The 2 loops are not really clear to me (except 1st overwrites mt2701 main-path and second ext_path based on ports/endpoints) but this only applies from bls-dpi-hdmi-connector,not xdma/color or similar.
Or should be main-path (or external) only bls and dpi? It looks like it only swappes dpi and dsi in my case.

@Ryder Lee can you explain it?
regards Frank

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Frank Wunderlich <frank-w@public-files.de>
To: linux-mediatek@lists.infradead.org,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	ryder.lee@mediatek.com
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port
Date: Mon, 03 Aug 2020 20:02:38 +0200	[thread overview]
Message-ID: <D0A969BC-1BB3-4EBB-8D03-DAA610E62EBE@public-files.de> (raw)
In-Reply-To: <CAAOTY_-H3L=uJNJRF1VedbwXNwY2N-q4F6A-NsdNwbQswG0D-Q@mail.gmail.com>



Am 3. August 2020 18:27:02 MESZ schrieb Chun-Kuang Hu <chunkuang.hu@kernel.org>:

>But now I have a solution that you need not to modify binding document.
>Because now mt7623 has a different routing than mt2701, and this
>patch's approach is to use different port setting in each device tree.
>My solution is that these two SoC has different compatible string:
>"mediatek,mt7623-mmsys" and "mediatek,mt2701-mmsys". For now,
>"mediatek,mt2701-mmsys" has its data as
>
>static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
>.main_path = mt2701_mtk_ddp_main,
>.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
>.ext_path = mt2701_mtk_ddp_ext,
>.ext_len = ARRAY_SIZE(mt2701_mtk_ddp_ext),
>.shadow_register = true,
>};
>
>I think you could create a data for "mediatek,mt7623-mmsys" which has
>a different routing.

The paths are defined as this:

static enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = {	DDP_COMPONENT_OVL0,	DDP_COMPONENT_RDMA0,	DDP_COMPONENT_COLOR0,	DDP_COMPONENT_BLS,	DDP_COMPONENT_DSI0,};

static enum mtk_ddp_comp_id mt2701_mtk_ddp_ext[] = {	DDP_COMPONENT_RDMA1,	DDP_COMPONENT_DPI0,};

First thing i notice is that main=dsi and ext=dpi (hdmi). I guess dpi should be main,right? And bls is actually routed to dpi...how about the other components?

The 2 loops are not really clear to me (except 1st overwrites mt2701 main-path and second ext_path based on ports/endpoints) but this only applies from bls-dpi-hdmi-connector,not xdma/color or similar.
Or should be main-path (or external) only bls and dpi? It looks like it only swappes dpi and dsi in my case.

@Ryder Lee can you explain it?
regards Frank

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Frank Wunderlich <frank-w@public-files.de>
To: linux-mediatek@lists.infradead.org,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	ryder.lee@mediatek.com
Cc: David Airlie <airlied@linux.ie>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port
Date: Mon, 03 Aug 2020 20:02:38 +0200	[thread overview]
Message-ID: <D0A969BC-1BB3-4EBB-8D03-DAA610E62EBE@public-files.de> (raw)
In-Reply-To: <CAAOTY_-H3L=uJNJRF1VedbwXNwY2N-q4F6A-NsdNwbQswG0D-Q@mail.gmail.com>



Am 3. August 2020 18:27:02 MESZ schrieb Chun-Kuang Hu <chunkuang.hu@kernel.org>:

>But now I have a solution that you need not to modify binding document.
>Because now mt7623 has a different routing than mt2701, and this
>patch's approach is to use different port setting in each device tree.
>My solution is that these two SoC has different compatible string:
>"mediatek,mt7623-mmsys" and "mediatek,mt2701-mmsys". For now,
>"mediatek,mt2701-mmsys" has its data as
>
>static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
>.main_path = mt2701_mtk_ddp_main,
>.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
>.ext_path = mt2701_mtk_ddp_ext,
>.ext_len = ARRAY_SIZE(mt2701_mtk_ddp_ext),
>.shadow_register = true,
>};
>
>I think you could create a data for "mediatek,mt7623-mmsys" which has
>a different routing.

The paths are defined as this:

static enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = {	DDP_COMPONENT_OVL0,	DDP_COMPONENT_RDMA0,	DDP_COMPONENT_COLOR0,	DDP_COMPONENT_BLS,	DDP_COMPONENT_DSI0,};

static enum mtk_ddp_comp_id mt2701_mtk_ddp_ext[] = {	DDP_COMPONENT_RDMA1,	DDP_COMPONENT_DPI0,};

First thing i notice is that main=dsi and ext=dpi (hdmi). I guess dpi should be main,right? And bls is actually routed to dpi...how about the other components?

The 2 loops are not really clear to me (except 1st overwrites mt2701 main-path and second ext_path based on ports/endpoints) but this only applies from bls-dpi-hdmi-connector,not xdma/color or similar.
Or should be main-path (or external) only bls and dpi? It looks like it only swappes dpi and dsi in my case.

@Ryder Lee can you explain it?
regards Frank
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-08-03 18:03 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 11:17 [PATCH v2 0/5] make hdmi work on bananapi-r2 Frank Wunderlich
2020-07-28 11:17 ` Frank Wunderlich
2020-07-28 11:17 ` Frank Wunderlich
2020-07-28 11:17 ` Frank Wunderlich
2020-07-28 11:17 ` [PATCH v2 1/5] drm/mediatek: config component output by device node port Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-08-02  0:03   ` Chun-Kuang Hu
2020-08-02  0:03     ` Chun-Kuang Hu
2020-08-02  0:03     ` Chun-Kuang Hu
2020-08-02  0:03     ` Chun-Kuang Hu
2020-08-02  8:05     ` Aw: " Frank Wunderlich
2020-08-02  8:05       ` Frank Wunderlich
2020-08-02  8:05       ` Frank Wunderlich
2020-08-02  8:05       ` Frank Wunderlich
2020-08-02 23:47       ` Chun-Kuang Hu
2020-08-02 23:47         ` Chun-Kuang Hu
2020-08-02 23:47         ` Chun-Kuang Hu
2020-08-02 23:47         ` Chun-Kuang Hu
2020-08-03 10:42         ` Aw: " Frank Wunderlich
2020-08-03 10:42           ` Frank Wunderlich
2020-08-03 10:42           ` Frank Wunderlich
2020-08-03 10:42           ` Frank Wunderlich
2020-08-03 16:27           ` Chun-Kuang Hu
2020-08-03 16:27             ` Chun-Kuang Hu
2020-08-03 16:27             ` Chun-Kuang Hu
2020-08-03 16:27             ` Chun-Kuang Hu
2020-08-03 18:02             ` Frank Wunderlich [this message]
2020-08-03 18:02               ` Frank Wunderlich
2020-08-03 18:02               ` Frank Wunderlich
2020-08-03 18:02               ` Frank Wunderlich
2020-08-04  9:53             ` Aw: " Frank Wunderlich
2020-08-04  9:53               ` Frank Wunderlich
2020-08-04  9:53               ` Frank Wunderlich
2020-08-04  9:53               ` Frank Wunderlich
2020-07-28 11:17 ` [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080 Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-08-02  0:08   ` Chun-Kuang Hu
2020-08-02  0:08     ` Chun-Kuang Hu
2020-08-02  0:08     ` Chun-Kuang Hu
2020-08-02  0:08     ` Chun-Kuang Hu
2020-08-02  4:42     ` Frank Wunderlich
2020-08-02  4:42       ` Frank Wunderlich
2020-08-02  4:42       ` Frank Wunderlich
2020-08-02  4:42       ` Frank Wunderlich
2020-08-02 23:38       ` Chun-Kuang Hu
2020-08-02 23:38         ` Chun-Kuang Hu
2020-08-02 23:38         ` Chun-Kuang Hu
2020-08-02 23:38         ` Chun-Kuang Hu
2020-07-28 11:17 ` [PATCH v2 3/5] drm: Add get_possible_crtc API for dpi, dsi Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-08-02  3:02   ` Chun-Kuang Hu
2020-08-02  3:02     ` Chun-Kuang Hu
2020-08-02  3:02     ` Chun-Kuang Hu
2020-08-02  3:02     ` Chun-Kuang Hu
2020-07-28 11:17 ` [PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-07-28 11:17   ` Frank Wunderlich
2020-08-02  3:07   ` Chun-Kuang Hu
2020-08-02  3:07     ` Chun-Kuang Hu
2020-08-02  3:07     ` Chun-Kuang Hu
2020-08-02  3:07     ` Chun-Kuang Hu
2020-08-02  8:17     ` Frank Wunderlich
2020-08-02  8:17       ` Frank Wunderlich
2020-08-02  8:17       ` Frank Wunderlich
2020-08-02  8:17       ` Frank Wunderlich
2020-07-28 11:18 ` [PATCH v2 5/5] arm: dts: mt7623: add display subsystem related device nodes Frank Wunderlich
2020-07-28 11:18   ` Frank Wunderlich
2020-07-28 11:18   ` Frank Wunderlich
2020-07-28 11:18   ` Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0A969BC-1BB3-4EBB-8D03-DAA610E62EBE@public-files.de \
    --to=frank-w@public-files.de \
    --cc=airlied@linux.ie \
    --cc=bibby.hsieh@mediatek.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=ryder.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.