All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anson Huang <anson.huang@nxp.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Abel Vesa" <abel.vesa@nxp.com>,
	"Andrey Smirnov" <andrew.smirnov@gmail.com>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>,
	"Carlo Caione" <ccaione@baylibre.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Leonard Crestez" <leonard.crestez@nxp.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Devicetree List" <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
Date: Sat, 27 Jul 2019 06:19:07 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916233A56CF5DF778115716F5C30@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAEnQRZAZNMBx3ApVmRP8hYPw0XY_QgR-saE6WLcT8oZmHPCxSA@mail.gmail.com>

Hi, Daniel

> Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for
> IMX8MQ_CLK_TMU_ROOT
> 
> Hi all,
> 
> latest linux-next hangs at boot.
> 
> commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag:
> next-20190726, origin/master, origin/HEAD)
> Author: Stephen Rothwell <sfr@canb.auug.org.au>
> Date:   Fri Jul 26 15:18:02 2019 +1000
> 
>     Add linux-next specific files for 20190726
> 
>     Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> 
> I know this is crazy but reverting commit:
> 
> commit 431bdd1df48ee2896ea9980d9153e3aeaf0c81ef (refs/bisect/bad)
> Author: Anson Huang <Anson.Huang@nxp.com>
> Date:   Fri Jul 5 12:56:11 2019 +0800
> 
>     clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
> 
>     IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver
>     should manage this clock, so no need to have CLK_IS_CRITICAL flag
>     set.
> 
> 
> 
> makes the boot work again.
> 
> Any idea?

I just found if disabling SDMA1, then kernel can boot up, it does NOT make sense
TMU clock is related to SDMA1, I will check with design and get back to you soon.

Anson


WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <anson.huang@nxp.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Carlo Caione" <ccaione@baylibre.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>,
	"Leonard Crestez" <leonard.crestez@nxp.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"Abel Vesa" <abel.vesa@nxp.com>,
	"Andrey Smirnov" <andrew.smirnov@gmail.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Devicetree List" <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Stephen Boyd" <sboyd@kernel.org>
Subject: RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
Date: Sat, 27 Jul 2019 06:19:07 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916233A56CF5DF778115716F5C30@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAEnQRZAZNMBx3ApVmRP8hYPw0XY_QgR-saE6WLcT8oZmHPCxSA@mail.gmail.com>

Hi, Daniel

> Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for
> IMX8MQ_CLK_TMU_ROOT
> 
> Hi all,
> 
> latest linux-next hangs at boot.
> 
> commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag:
> next-20190726, origin/master, origin/HEAD)
> Author: Stephen Rothwell <sfr@canb.auug.org.au>
> Date:   Fri Jul 26 15:18:02 2019 +1000
> 
>     Add linux-next specific files for 20190726
> 
>     Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> 
> I know this is crazy but reverting commit:
> 
> commit 431bdd1df48ee2896ea9980d9153e3aeaf0c81ef (refs/bisect/bad)
> Author: Anson Huang <Anson.Huang@nxp.com>
> Date:   Fri Jul 5 12:56:11 2019 +0800
> 
>     clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
> 
>     IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver
>     should manage this clock, so no need to have CLK_IS_CRITICAL flag
>     set.
> 
> 
> 
> makes the boot work again.
> 
> Any idea?

I just found if disabling SDMA1, then kernel can boot up, it does NOT make sense
TMU clock is related to SDMA1, I will check with design and get back to you soon.

Anson

WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <anson.huang@nxp.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Carlo Caione" <ccaione@baylibre.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>,
	"Leonard Crestez" <leonard.crestez@nxp.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"Abel Vesa" <abel.vesa@nxp.com>,
	"Andrey Smirnov" <andrew.smirnov@gmail.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Devicetree List" <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>
Subject: RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
Date: Sat, 27 Jul 2019 06:19:07 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916233A56CF5DF778115716F5C30@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAEnQRZAZNMBx3ApVmRP8hYPw0XY_QgR-saE6WLcT8oZmHPCxSA@mail.gmail.com>

Hi, Daniel

> Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for
> IMX8MQ_CLK_TMU_ROOT
> 
> Hi all,
> 
> latest linux-next hangs at boot.
> 
> commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag:
> next-20190726, origin/master, origin/HEAD)
> Author: Stephen Rothwell <sfr@canb.auug.org.au>
> Date:   Fri Jul 26 15:18:02 2019 +1000
> 
>     Add linux-next specific files for 20190726
> 
>     Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> 
> I know this is crazy but reverting commit:
> 
> commit 431bdd1df48ee2896ea9980d9153e3aeaf0c81ef (refs/bisect/bad)
> Author: Anson Huang <Anson.Huang@nxp.com>
> Date:   Fri Jul 5 12:56:11 2019 +0800
> 
>     clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
> 
>     IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver
>     should manage this clock, so no need to have CLK_IS_CRITICAL flag
>     set.
> 
> 
> 
> makes the boot work again.
> 
> Any idea?

I just found if disabling SDMA1, then kernel can boot up, it does NOT make sense
TMU clock is related to SDMA1, I will check with design and get back to you soon.

Anson

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-27  6:19 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05  4:56 [PATCH 1/6] thermal: qoriq: Use devm_platform_ioremap_resource() instead of of_iomap() Anson.Huang
2019-07-05  4:56 ` Anson.Huang
2019-07-05  4:56 ` [PATCH 2/6] thermal: qoriq: Use __maybe_unused instead of #if CONFIG_PM_SLEEP Anson.Huang
2019-07-05  4:56   ` Anson.Huang
2019-07-05  4:56 ` [PATCH 3/6] dt-bindings: thermal: qoriq: Add optional clocks property Anson.Huang
2019-07-05  4:56   ` Anson.Huang
2019-07-22 23:55   ` Rob Herring
2019-07-22 23:55     ` Rob Herring
2019-07-05  4:56 ` [PATCH 4/6] thermal: qoriq: Add clock operations Anson.Huang
2019-07-05  4:56   ` Anson.Huang
2019-07-29  8:12   ` Guido Günther
2019-07-29  8:12     ` Guido Günther
2019-07-29  8:40     ` Anson Huang
2019-07-29  8:40       ` Anson Huang
2019-07-29  8:40       ` Anson Huang
2019-07-05  4:56 ` [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT Anson.Huang
2019-07-05  4:56   ` Anson.Huang
2019-07-05  7:01   ` Abel Vesa
2019-07-05  7:01     ` Abel Vesa
2019-07-05  7:01     ` Abel Vesa
2019-07-22 21:31   ` Stephen Boyd
2019-07-22 21:31     ` Stephen Boyd
2019-07-23  2:50   ` Shawn Guo
2019-07-23  2:50     ` Shawn Guo
2019-07-26 22:26   ` Daniel Baluta
2019-07-26 22:26     ` Daniel Baluta
2019-07-26 22:26     ` Daniel Baluta
2019-07-27  6:19     ` Anson Huang [this message]
2019-07-27  6:19       ` Anson Huang
2019-07-27  6:19       ` Anson Huang
2019-07-27  6:33       ` Daniel Baluta
2019-07-27  6:33         ` Daniel Baluta
2019-07-27 16:17         ` Abel Vesa
2019-07-27 16:17           ` Abel Vesa
2019-07-27 16:17           ` Abel Vesa
2019-07-29  1:29           ` Anson Huang
2019-07-29  1:29             ` Anson Huang
2019-07-29  1:29             ` Anson Huang
2019-07-29  6:51             ` Daniel Baluta
2019-07-29  6:51               ` Daniel Baluta
2019-07-29  6:51               ` Daniel Baluta
2019-07-29  7:14               ` Anson Huang
2019-07-29  7:14                 ` Anson Huang
2019-07-29  7:14                 ` Anson Huang
2019-07-29  7:20                 ` Daniel Baluta
2019-07-29  7:20                   ` Daniel Baluta
2019-07-29  7:20                   ` Daniel Baluta
2019-07-29  7:21                   ` Daniel Baluta
2019-07-29  7:21                     ` Daniel Baluta
2019-07-29  7:21                     ` Daniel Baluta
2019-07-29  7:49                     ` Anson Huang
2019-07-29  7:49                       ` Anson Huang
2019-07-29  7:49                       ` Anson Huang
2019-07-29  8:13                       ` Daniel Baluta
2019-07-29  8:13                         ` Daniel Baluta
2019-07-29  8:13                         ` Daniel Baluta
2019-07-27 18:26     ` Guido Günther
2019-07-27 18:26       ` Guido Günther
2019-07-27 18:26       ` Guido Günther
2019-07-27 20:17       ` Fabio Estevam
2019-07-27 20:17         ` Fabio Estevam
2019-07-27 20:17         ` Fabio Estevam
2019-07-28  7:58         ` Guido Günther
2019-07-28  7:58           ` Guido Günther
2019-07-28  7:58           ` Guido Günther
2019-07-28 15:24           ` Fabio Estevam
2019-07-28 15:24             ` Fabio Estevam
2019-07-28 15:24             ` Fabio Estevam
2019-07-05  4:56 ` [PATCH 6/6] arm64: dts: imx8mq: Add clock for TMU node Anson.Huang
2019-07-05  4:56   ` Anson.Huang
2019-07-23  2:51   ` Shawn Guo
2019-07-23  2:51     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0402MB3916233A56CF5DF778115716F5C30@DB3PR0402MB3916.eurprd04.prod.outlook.com \
    --to=anson.huang@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=agx@sigxcpu.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=angus@akkea.ca \
    --cc=ccaione@baylibre.com \
    --cc=daniel.baluta@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.