From: Bough Chen <haibo.chen@nxp.com>
To: "tharvey@gateworks.com" <tharvey@gateworks.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Marcel Ziswiler <marcel@ziswiler.com>,
Schrempf Frieder <frieder.schrempf@kontron.de>,
Adam Ford <aford173@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>, Peng Fan <peng.fan@nxp.com>
Cc: "tharvey@gateworks.com" <tharvey@gateworks.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] mmc: sdhci-esdhc-imx: disable CMDQ support
Date: Thu, 4 Nov 2021 02:06:10 +0000 [thread overview]
Message-ID: <DB7PR04MB40101E7FDF84E2997074861D908D9@DB7PR04MB4010.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20211103165415.2016-1-tharvey@gateworks.com>
[-- Attachment #1: Type: text/plain, Size: 4644 bytes --]
> -----Original Message-----
> From: Tim Harvey [mailto:tharvey@gateworks.com]
> Sent: 2021年11月4日 0:54
> To: Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>;
> dl-linux-imx <linux-imx@nxp.com>; Bough Chen <haibo.chen@nxp.com>;
> linux-mmc@vger.kernel.org; Marcel Ziswiler <marcel@ziswiler.com>;
> Schrempf Frieder <frieder.schrempf@kontron.de>; Adam Ford
> <aford173@gmail.com>; Lucas Stach <l.stach@pengutronix.de>; Peng Fan
> <peng.fan@nxp.com>
> Cc: tharvey@gateworks.com; stable@vger.kernel.org
> Subject: [PATCH] mmc: sdhci-esdhc-imx: disable CMDQ support
>
> On IMX SoC's which support CMDQ the following can occur during high a high
> cpu load:
>
> mmc2: cqhci: ============ CQHCI REGISTER DUMP ===========
> mmc2: cqhci: Caps: 0x0000310a | Version: 0x00000510
> mmc2: cqhci: Config: 0x00001001 | Control: 0x00000000
> mmc2: cqhci: Int stat: 0x00000000 | Int enab: 0x00000006
> mmc2: cqhci: Int sig: 0x00000006 | Int Coal: 0x00000000
> mmc2: cqhci: TDL base: 0x8003f000 | TDL up32: 0x00000000
> mmc2: cqhci: Doorbell: 0xbf01dfff | TCN: 0x00000000
> mmc2: cqhci: Dev queue: 0x00000000 | Dev Pend: 0x08000000
> mmc2: cqhci: Task clr: 0x00000000 | SSC1: 0x00011000
> mmc2: cqhci: SSC2: 0x00000001 | DCMD rsp: 0x00000800
> mmc2: cqhci: RED mask: 0xfdf9a080 | TERRI: 0x00000000
> mmc2: cqhci: Resp idx: 0x0000000d | Resp arg: 0x00000000
> mmc2: sdhci: ============ SDHCI REGISTER DUMP ===========
> mmc2: sdhci: Sys addr: 0x7c722000 | Version: 0x00000002
> mmc2: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000020
> mmc2: sdhci: Argument: 0x00018000 | Trn mode: 0x00000023
> mmc2: sdhci: Present: 0x01f88008 | Host ctl: 0x00000030
> mmc2: sdhci: Power: 0x00000002 | Blk gap: 0x00000080
> mmc2: sdhci: Wake-up: 0x00000008 | Clock: 0x0000000f
> mmc2: sdhci: Timeout: 0x0000008f | Int stat: 0x00000000
> mmc2: sdhci: Int enab: 0x107f4000 | Sig enab: 0x107f4000
> mmc2: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000502
> mmc2: sdhci: Caps: 0x07eb0000 | Caps_1: 0x8000b407
> mmc2: sdhci: Cmd: 0x00000d1a | Max curr: 0x00ffffff
> mmc2: sdhci: Resp[0]: 0x00000000 | Resp[1]: 0xffc003ff
> mmc2: sdhci: Resp[2]: 0x328f5903 | Resp[3]: 0x00d07f01
> mmc2: sdhci: Host ctl2: 0x00000088
> mmc2: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xfe179020
> mmc2: sdhci-esdhc-imx: ========= ESDHC IMX DEBUG STATUS DUMP ====
> mmc2: sdhci-esdhc-imx: cmd debug status: 0x2120
> mmc2: sdhci-esdhc-imx: data debug status: 0x2200
> mmc2: sdhci-esdhc-imx: trans debug status: 0x2300
> mmc2: sdhci-esdhc-imx: dma debug status: 0x2400
> mmc2: sdhci-esdhc-imx: adma debug status: 0x2510
> mmc2: sdhci-esdhc-imx: fifo debug status: 0x2680
> mmc2: sdhci-esdhc-imx: async fifo debug status: 0x2750
> mmc2: sdhci: ============================================
>
> For now, disable CMDQ support on the imx8qm/imx8qxp/imx8mm until the
> issue is found and resolved.
>
> Fixes: bb6e358169bf6 ("mmc: sdhci-esdhc-imx: add CMDQ support")
> Fixes: cde5e8e9ff146 ("mmc: sdhci-esdhc-imx: Add an new esdhc_soc_data for
> i.MX8MM")
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Best Regards
Haibo Chen
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index e658f0174242..60f19369de84 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -300,7 +300,6 @@ static struct esdhc_soc_data usdhc_imx8qxp_data = {
> .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
> | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
> - | ESDHC_FLAG_CQHCI
> | ESDHC_FLAG_STATE_LOST_IN_LPMODE
> | ESDHC_FLAG_CLK_RATE_LOST_IN_PM_RUNTIME,
> };
> @@ -309,7 +308,6 @@ static struct esdhc_soc_data usdhc_imx8mm_data = {
> .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
> | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
> - | ESDHC_FLAG_CQHCI
> | ESDHC_FLAG_STATE_LOST_IN_LPMODE,
> };
>
> --
> 2.17.1
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 34729 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Bough Chen <haibo.chen@nxp.com>
To: "tharvey@gateworks.com" <tharvey@gateworks.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Marcel Ziswiler <marcel@ziswiler.com>,
Schrempf Frieder <frieder.schrempf@kontron.de>,
Adam Ford <aford173@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>, Peng Fan <peng.fan@nxp.com>
Cc: "tharvey@gateworks.com" <tharvey@gateworks.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] mmc: sdhci-esdhc-imx: disable CMDQ support
Date: Thu, 4 Nov 2021 02:06:10 +0000 [thread overview]
Message-ID: <DB7PR04MB40101E7FDF84E2997074861D908D9@DB7PR04MB4010.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20211103165415.2016-1-tharvey@gateworks.com>
[-- Attachment #1: Type: text/plain, Size: 4481 bytes --]
> -----Original Message-----
> From: Tim Harvey [mailto:tharvey@gateworks.com]
> Sent: 2021年11月4日 0:54
> To: Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>;
> dl-linux-imx <linux-imx@nxp.com>; Bough Chen <haibo.chen@nxp.com>;
> linux-mmc@vger.kernel.org; Marcel Ziswiler <marcel@ziswiler.com>;
> Schrempf Frieder <frieder.schrempf@kontron.de>; Adam Ford
> <aford173@gmail.com>; Lucas Stach <l.stach@pengutronix.de>; Peng Fan
> <peng.fan@nxp.com>
> Cc: tharvey@gateworks.com; stable@vger.kernel.org
> Subject: [PATCH] mmc: sdhci-esdhc-imx: disable CMDQ support
>
> On IMX SoC's which support CMDQ the following can occur during high a high
> cpu load:
>
> mmc2: cqhci: ============ CQHCI REGISTER DUMP ===========
> mmc2: cqhci: Caps: 0x0000310a | Version: 0x00000510
> mmc2: cqhci: Config: 0x00001001 | Control: 0x00000000
> mmc2: cqhci: Int stat: 0x00000000 | Int enab: 0x00000006
> mmc2: cqhci: Int sig: 0x00000006 | Int Coal: 0x00000000
> mmc2: cqhci: TDL base: 0x8003f000 | TDL up32: 0x00000000
> mmc2: cqhci: Doorbell: 0xbf01dfff | TCN: 0x00000000
> mmc2: cqhci: Dev queue: 0x00000000 | Dev Pend: 0x08000000
> mmc2: cqhci: Task clr: 0x00000000 | SSC1: 0x00011000
> mmc2: cqhci: SSC2: 0x00000001 | DCMD rsp: 0x00000800
> mmc2: cqhci: RED mask: 0xfdf9a080 | TERRI: 0x00000000
> mmc2: cqhci: Resp idx: 0x0000000d | Resp arg: 0x00000000
> mmc2: sdhci: ============ SDHCI REGISTER DUMP ===========
> mmc2: sdhci: Sys addr: 0x7c722000 | Version: 0x00000002
> mmc2: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000020
> mmc2: sdhci: Argument: 0x00018000 | Trn mode: 0x00000023
> mmc2: sdhci: Present: 0x01f88008 | Host ctl: 0x00000030
> mmc2: sdhci: Power: 0x00000002 | Blk gap: 0x00000080
> mmc2: sdhci: Wake-up: 0x00000008 | Clock: 0x0000000f
> mmc2: sdhci: Timeout: 0x0000008f | Int stat: 0x00000000
> mmc2: sdhci: Int enab: 0x107f4000 | Sig enab: 0x107f4000
> mmc2: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000502
> mmc2: sdhci: Caps: 0x07eb0000 | Caps_1: 0x8000b407
> mmc2: sdhci: Cmd: 0x00000d1a | Max curr: 0x00ffffff
> mmc2: sdhci: Resp[0]: 0x00000000 | Resp[1]: 0xffc003ff
> mmc2: sdhci: Resp[2]: 0x328f5903 | Resp[3]: 0x00d07f01
> mmc2: sdhci: Host ctl2: 0x00000088
> mmc2: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xfe179020
> mmc2: sdhci-esdhc-imx: ========= ESDHC IMX DEBUG STATUS DUMP ====
> mmc2: sdhci-esdhc-imx: cmd debug status: 0x2120
> mmc2: sdhci-esdhc-imx: data debug status: 0x2200
> mmc2: sdhci-esdhc-imx: trans debug status: 0x2300
> mmc2: sdhci-esdhc-imx: dma debug status: 0x2400
> mmc2: sdhci-esdhc-imx: adma debug status: 0x2510
> mmc2: sdhci-esdhc-imx: fifo debug status: 0x2680
> mmc2: sdhci-esdhc-imx: async fifo debug status: 0x2750
> mmc2: sdhci: ============================================
>
> For now, disable CMDQ support on the imx8qm/imx8qxp/imx8mm until the
> issue is found and resolved.
>
> Fixes: bb6e358169bf6 ("mmc: sdhci-esdhc-imx: add CMDQ support")
> Fixes: cde5e8e9ff146 ("mmc: sdhci-esdhc-imx: Add an new esdhc_soc_data for
> i.MX8MM")
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Best Regards
Haibo Chen
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index e658f0174242..60f19369de84 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -300,7 +300,6 @@ static struct esdhc_soc_data usdhc_imx8qxp_data = {
> .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
> | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
> - | ESDHC_FLAG_CQHCI
> | ESDHC_FLAG_STATE_LOST_IN_LPMODE
> | ESDHC_FLAG_CLK_RATE_LOST_IN_PM_RUNTIME,
> };
> @@ -309,7 +308,6 @@ static struct esdhc_soc_data usdhc_imx8mm_data = {
> .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
> | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
> - | ESDHC_FLAG_CQHCI
> | ESDHC_FLAG_STATE_LOST_IN_LPMODE,
> };
>
> --
> 2.17.1
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 9551 bytes --]
next prev parent reply other threads:[~2021-11-04 2:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 20:47 IMX8MM eMMC CQHCI timeout Tim Harvey
2021-11-01 1:57 ` Bough Chen
2021-11-03 16:49 ` Tim Harvey
2021-11-03 16:54 ` [PATCH] mmc: sdhci-esdhc-imx: disable CMDQ support Tim Harvey
2021-11-03 17:12 ` Fabio Estevam
2021-11-04 2:06 ` Bough Chen [this message]
2021-11-04 2:06 ` Bough Chen
2021-11-05 7:56 ` Adrian Hunter
2021-11-15 14:54 ` Ulf Hansson
2021-11-03 17:21 ` IMX8MM eMMC CQHCI timeout Marcel Ziswiler
2021-11-04 2:13 ` Bough Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB40101E7FDF84E2997074861D908D9@DB7PR04MB4010.eurprd04.prod.outlook.com \
--to=haibo.chen@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=aford173@gmail.com \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=marcel@ziswiler.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.