From: "Ong, Boon Leong" <boon.leong.ong@intel.com>
To: Russell King <linux@armlinux.org.uk>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Riva, Emilio" <emilio.riva@ericsson.com>
Subject: RE: [PATCH net-next v4 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN support
Date: Wed, 15 Jun 2022 01:06:07 +0000 [thread overview]
Message-ID: <DM4PR11MB6095F0AA09EFA775AB0DE09CCAAD9@DM4PR11MB6095.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YqhLI0vWuDWNTQ8h@shell.armlinux.org.uk>
>On Tue, Jun 14, 2022 at 11:00:28AM +0800, Ong Boon Leong wrote:
>> +int xpcs_modify_changed(struct dw_xpcs *xpcs, int dev, u32 reg,
>> + u16 mask, u16 set)
>
>Why is this globally visible? I can find no reason for it in this patch
>set.
Ok. I will make it private.
>
>> +{
>> + u32 reg_addr = mdiobus_c45_addr(dev, reg);
>> + struct mii_bus *bus = xpcs->mdiodev->bus;
>> + int addr = xpcs->mdiodev->addr;
>> +
>> + return mdiobus_modify_changed(bus, addr, reg_addr, mask, set);
>
>There is a mdiodev_modify_changed() which would be slightly cleaner
>here.
>
Interesting. I could also add another patch to make the same change to
xpcs_read() and xpcs_write(). Ok?
WARNING: multiple messages have this Message-ID (diff)
From: "Ong, Boon Leong" <boon.leong.ong@intel.com>
To: Russell King <linux@armlinux.org.uk>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Riva, Emilio" <emilio.riva@ericsson.com>
Subject: RE: [PATCH net-next v4 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN support
Date: Wed, 15 Jun 2022 01:06:07 +0000 [thread overview]
Message-ID: <DM4PR11MB6095F0AA09EFA775AB0DE09CCAAD9@DM4PR11MB6095.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YqhLI0vWuDWNTQ8h@shell.armlinux.org.uk>
>On Tue, Jun 14, 2022 at 11:00:28AM +0800, Ong Boon Leong wrote:
>> +int xpcs_modify_changed(struct dw_xpcs *xpcs, int dev, u32 reg,
>> + u16 mask, u16 set)
>
>Why is this globally visible? I can find no reason for it in this patch
>set.
Ok. I will make it private.
>
>> +{
>> + u32 reg_addr = mdiobus_c45_addr(dev, reg);
>> + struct mii_bus *bus = xpcs->mdiodev->bus;
>> + int addr = xpcs->mdiodev->addr;
>> +
>> + return mdiobus_modify_changed(bus, addr, reg_addr, mask, set);
>
>There is a mdiodev_modify_changed() which would be slightly cleaner
>here.
>
Interesting. I could also add another patch to make the same change to
xpcs_read() and xpcs_write(). Ok?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-15 1:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 3:00 [PATCH net-next v4 0/5] pcs-xpcs, stmmac: add 1000BASE-X AN for network switch Ong Boon Leong
2022-06-14 3:00 ` Ong Boon Leong
2022-06-14 3:00 ` [PATCH net-next v4 1/5] net: make xpcs_do_config to accept advertising for pcs-xpcs and sja1105 Ong Boon Leong
2022-06-14 3:00 ` Ong Boon Leong
2022-06-14 3:00 ` [PATCH net-next v4 2/5] stmmac: intel: prepare to support 1000BASE-X phy interface setting Ong Boon Leong
2022-06-14 3:00 ` Ong Boon Leong
2022-06-14 3:00 ` [PATCH net-next v4 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN support Ong Boon Leong
2022-06-14 3:00 ` Ong Boon Leong
2022-06-14 8:47 ` Russell King (Oracle)
2022-06-14 8:47 ` Russell King (Oracle)
2022-06-15 1:06 ` Ong, Boon Leong [this message]
2022-06-15 1:06 ` Ong, Boon Leong
2022-06-14 3:00 ` [PATCH net-next v4 4/5] stmmac: intel: add phy-mode and fixed-link ACPI _DSD setting support Ong Boon Leong
2022-06-14 3:00 ` Ong Boon Leong
2022-06-14 18:57 ` Andrew Lunn
2022-06-14 18:57 ` Andrew Lunn
2022-06-14 3:00 ` [PATCH net-next v4 5/5] net: stmmac: make mdio register skips PHY scanning for fixed-link Ong Boon Leong
2022-06-14 3:00 ` Ong Boon Leong
2022-06-14 6:55 ` Ong, Boon Leong
2022-06-14 6:55 ` Ong, Boon Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB6095F0AA09EFA775AB0DE09CCAAD9@DM4PR11MB6095.namprd11.prod.outlook.com \
--to=boon.leong.ong@intel.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emilio.riva@ericsson.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.