RE: [PATCH v4 0/8] Refine error history and introduce event_notify vop

From: Avri Altman <Avri.Altman@wdc.com>
To: Stanley Chu <stanley.chu@mediatek.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Cc: "beanhuo@micron.com" <beanhuo@micron.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
	"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
	"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
	"andy.teng@mediatek.com" <andy.teng@mediatek.com>,
	"chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
	"cc.chou@mediatek.com" <cc.chou@mediatek.com>,
	"jiajie.hao@mediatek.com" <jiajie.hao@mediatek.com>,
	"alice.chao@mediatek.com" <alice.chao@mediatek.com>,
	"huadian.liu@mediatek.com" <huadian.liu@mediatek.com>
Subject: RE: [PATCH v4 0/8] Refine error history and introduce event_notify vop
Date: Sat, 5 Dec 2020 08:05:38 +0000	[thread overview]
Message-ID: <DM6PR04MB657567F698B1EEA7D848FE45FCF00@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <DM6PR04MB65758A2779FD814F52E137BAFCF00@DM6PR04MB6575.namprd04.prod.outlook.com>

> 
> Hi Stanley,
> Will you split this series to 3 separate series:
> Phy initialization cleanup, Error history, and event notification?
> As those 3 aren't really connected?
> 
> Please maintain Can's reviewed-by tag for the error history patches,
> And add mine for the phy initialization, so Martin can pick those.
And for the new event notification vop of course.  Sorry.

Thanks,
Avri

> 
> Thanks,
> Avri
> 
> >
> > Hi,
> > This series refines error history functions, do vop cleanups and introduce a
> > new event_notify vop to allow vendor to get notification of important
> > events.
> >
> > Changes since v3:
> >   - Fix build warning in patch [8/8]
> >
> > Changes since v2:
> >   - Add patches for vop cleanups
> >   - Introduce phy_initialization helper and replace direct invoking in ufs-cdns
> > and ufs-dwc by the helper
> >   - Introduce event_notify vop implemntation in ufs-mediatek
> >
> > Changes since v1:
> >   - Change notify_event() to event_notify() to follow vop naming covention
> >
> > Stanley Chu (8):
> >   scsi: ufs: Remove unused setup_regulators variant function
> >   scsi: ufs: Introduce phy_initialization helper
> >   scsi: ufs-cdns: Use phy_initialization helper
> >   scsi: ufs-dwc: Use phy_initialization helper
> >   scsi: ufs: Add error history for abort event in UFS Device W-LUN
> >   scsi: ufs: Refine error history functions
> >   scsi: ufs: Introduce event_notify variant function
> >   scsi: ufs-mediatek: Introduce event_notify implementation
> >
> >  drivers/scsi/ufs/cdns-pltfrm.c        |   3 +-
> >  drivers/scsi/ufs/ufs-mediatek-trace.h |  37 ++++++++
> >  drivers/scsi/ufs/ufs-mediatek.c       |  12 +++
> >  drivers/scsi/ufs/ufshcd-dwc.c         |  11 +--
> >  drivers/scsi/ufs/ufshcd.c             | 132 ++++++++++++++------------
> >  drivers/scsi/ufs/ufshcd.h             | 100 +++++++++----------
> >  6 files changed, 175 insertions(+), 120 deletions(-)
> >  create mode 100644 drivers/scsi/ufs/ufs-mediatek-trace.h
> >
> > --
> > 2.18.0