From: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"kbuild@lists.01.org" <kbuild@lists.01.org>
Cc: lkp <lkp@intel.com>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>
Subject: RE: drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249.
Date: Fri, 17 Dec 2021 13:29:08 +0000 [thread overview]
Message-ID: <DM8PR11MB56692F596CAAC7D7AA252B4789789@DM8PR11MB5669.namprd11.prod.outlook.com> (raw)
In-Reply-To: <202112161000.15tF7PTx-lkp@intel.com>
> From: Dan Carpenter <dan.carpenter@oracle.com>
> ...
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Sure. Will add the above tags in the fix patch.
> smatch warnings:
> drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249.
> ...
> mbase =ioremap(base + off, I10NM_HBM_IMC_MMIO_SIZE);
> ^^^^^^^^^^^^^^^^
>...
> if (!I10NM_IS_HBM_IMC(mcmtr)) {
> i10nm_printk(KERN_ERR, "This isn't an hbm mc!\n");
> return -ENODEV;
> }
> No clean up before the return.
Thanks for catching this issue. Will fix it.
- Qiuxu
WARNING: multiple messages have this Message-ID (diff)
From: Zhuo, Qiuxu <qiuxu.zhuo@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249.
Date: Fri, 17 Dec 2021 13:29:08 +0000 [thread overview]
Message-ID: <DM8PR11MB56692F596CAAC7D7AA252B4789789@DM8PR11MB5669.namprd11.prod.outlook.com> (raw)
In-Reply-To: <202112161000.15tF7PTx-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
> From: Dan Carpenter <dan.carpenter@oracle.com>
> ...
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Sure. Will add the above tags in the fix patch.
> smatch warnings:
> drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249.
> ...
> mbase =ioremap(base + off, I10NM_HBM_IMC_MMIO_SIZE);
> ^^^^^^^^^^^^^^^^
>...
> if (!I10NM_IS_HBM_IMC(mcmtr)) {
> i10nm_printk(KERN_ERR, "This isn't an hbm mc!\n");
> return -ENODEV;
> }
> No clean up before the return.
Thanks for catching this issue. Will fix it.
- Qiuxu
next prev parent reply other threads:[~2021-12-17 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 2:01 drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249 kernel test robot
2021-12-17 7:20 ` Dan Carpenter
2021-12-17 7:20 ` Dan Carpenter
2021-12-17 13:29 ` Zhuo, Qiuxu [this message]
2021-12-17 13:29 ` Zhuo, Qiuxu
2021-12-24 9:11 ` [PATCH 1/1] EDAC/i10nm: Release mdev/mbase when failing to detect HBM Qiuxu Zhuo
2022-01-11 5:25 drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249 Dan Carpenter
2022-01-10 20:21 ` kernel test robot
2022-01-11 5:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB56692F596CAAC7D7AA252B4789789@DM8PR11MB5669.namprd11.prod.outlook.com \
--to=qiuxu.zhuo@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.