RE: [PATCH V2 7/9] interconnect: imx: set of_node for interconnect provider

From: Peng Fan <peng.fan@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"djakov@kernel.org" <djakov@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	Abel Vesa <abel.vesa@nxp.com>,
	"abailon@baylibre.com" <abailon@baylibre.com>,
	"laurent.pinchart@ideasonboard.com" 
	<laurent.pinchart@ideasonboard.com>,
	"marex@denx.de" <marex@denx.de>,
	"paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>,
	"Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>,
	"aford173@gmail.com" <aford173@gmail.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"abelvesa@kernel.org" <abelvesa@kernel.org>
Subject: RE: [PATCH V2 7/9] interconnect: imx: set of_node for interconnect provider
Date: Sat, 2 Jul 2022 12:48:45 +0000	[thread overview]
Message-ID: <DU0PR04MB9417B73F60FE49C361E898F788BC9@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <3c773637f626877832041d3065f387261ba70816.camel@pengutronix.de>

> Subject: Re: [PATCH V2 7/9] interconnect: imx: set of_node for interconnect
> provider
> 
> Am Donnerstag, dem 16.06.2022 um 15:33 +0800 schrieb Peng Fan (OSS):
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The provider device is created using platform_device_register_data in
> > imx-bus driver, which not has of_node. With of_node set, it will be
> > easy to support QoS settings.
> >
> That's a bit dangerous, as sharing a of_node between two devices can lead
> to some reference counting issues IIRC, but then I also don't see a good way
> to do this any differently.

I just recalled there is a similar usage in usb code, I not remember the exact
file.

I thought not to let imx-bus.c to register the device, but I wanna to do all
these stuff step by step. The next step is to pick Abel's
https://lore.kernel.org/linux-arm-kernel/20220106164150.3474048-1-
abel.vesa@nxp.com/

Abel told me he was trying to decouple imx-bus with icc.

Thanks,
Peng.

> 
> Regards,
> Lucas
> 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/interconnect/imx/imx.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/interconnect/imx/imx.c
> > b/drivers/interconnect/imx/imx.c index 1f16eedea21c..78557fe6da2c
> > 100644
> > --- a/drivers/interconnect/imx/imx.c
> > +++ b/drivers/interconnect/imx/imx.c
> > @@ -264,6 +264,7 @@ int imx_icc_register(struct platform_device *pdev,
> >  	provider->xlate = of_icc_xlate_onecell;
> >  	provider->data = data;
> >  	provider->dev = dev->parent;
> > +	provider->dev->of_node = dev->parent->of_node;
> >  	platform_set_drvdata(pdev, imx_provider);
> >
> >  	ret = icc_provider_add(provider);
> 