From: Russell King <rmk+kernel@arm.linux.org.uk> To: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org Subject: [PATCH 02/10] SH: use clkdev_add_table() Date: Mon, 02 Mar 2015 17:06:11 +0000 [thread overview] Message-ID: <E1YSTnH-0001JY-GT@rmk-PC.arm.linux.org.uk> (raw) In-Reply-To: <20150302170538.GQ8656@n2100.arm.linux.org.uk> We have always had an efficient way of registering a table of clock lookups - it's called clkdev_add_table(). However, some people seem to really love writing inefficient and unnecessary code. Convert SH to use the correct interface. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> --- arch/sh/kernel/cpu/sh4a/clock-sh7734.c | 3 +-- arch/sh/kernel/cpu/sh4a/clock-sh7757.c | 4 ++-- arch/sh/kernel/cpu/sh4a/clock-sh7785.c | 4 ++-- arch/sh/kernel/cpu/sh4a/clock-sh7786.c | 4 ++-- arch/sh/kernel/cpu/sh4a/clock-shx3.c | 4 ++-- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7734.c b/arch/sh/kernel/cpu/sh4a/clock-sh7734.c index 1fdf1ee672de..7f54bf2f453d 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7734.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7734.c @@ -246,8 +246,7 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(main_clks); i++) ret |= clk_register(main_clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7757.c b/arch/sh/kernel/cpu/sh4a/clock-sh7757.c index 9a28fdb36387..e40ec2c97ad1 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7757.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7757.c @@ -141,8 +141,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7785.c b/arch/sh/kernel/cpu/sh4a/clock-sh7785.c index 17d0ea55a5a2..8eb6e62340c9 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7785.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7785.c @@ -164,8 +164,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7786.c b/arch/sh/kernel/cpu/sh4a/clock-sh7786.c index bec2a83f1ba5..5e50e7ebeff0 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7786.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7786.c @@ -179,8 +179,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-shx3.c b/arch/sh/kernel/cpu/sh4a/clock-shx3.c index 9a49a44f6f94..605221d1448a 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-shx3.c +++ b/arch/sh/kernel/cpu/sh4a/clock-shx3.c @@ -138,8 +138,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: rmk+kernel@arm.linux.org.uk (Russell King) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/10] SH: use clkdev_add_table() Date: Mon, 02 Mar 2015 17:06:11 +0000 [thread overview] Message-ID: <E1YSTnH-0001JY-GT@rmk-PC.arm.linux.org.uk> (raw) In-Reply-To: <20150302170538.GQ8656@n2100.arm.linux.org.uk> We have always had an efficient way of registering a table of clock lookups - it's called clkdev_add_table(). However, some people seem to really love writing inefficient and unnecessary code. Convert SH to use the correct interface. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> --- arch/sh/kernel/cpu/sh4a/clock-sh7734.c | 3 +-- arch/sh/kernel/cpu/sh4a/clock-sh7757.c | 4 ++-- arch/sh/kernel/cpu/sh4a/clock-sh7785.c | 4 ++-- arch/sh/kernel/cpu/sh4a/clock-sh7786.c | 4 ++-- arch/sh/kernel/cpu/sh4a/clock-shx3.c | 4 ++-- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7734.c b/arch/sh/kernel/cpu/sh4a/clock-sh7734.c index 1fdf1ee672de..7f54bf2f453d 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7734.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7734.c @@ -246,8 +246,7 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(main_clks); i++) ret |= clk_register(main_clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7757.c b/arch/sh/kernel/cpu/sh4a/clock-sh7757.c index 9a28fdb36387..e40ec2c97ad1 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7757.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7757.c @@ -141,8 +141,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7785.c b/arch/sh/kernel/cpu/sh4a/clock-sh7785.c index 17d0ea55a5a2..8eb6e62340c9 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7785.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7785.c @@ -164,8 +164,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-sh7786.c b/arch/sh/kernel/cpu/sh4a/clock-sh7786.c index bec2a83f1ba5..5e50e7ebeff0 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-sh7786.c +++ b/arch/sh/kernel/cpu/sh4a/clock-sh7786.c @@ -179,8 +179,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), diff --git a/arch/sh/kernel/cpu/sh4a/clock-shx3.c b/arch/sh/kernel/cpu/sh4a/clock-shx3.c index 9a49a44f6f94..605221d1448a 100644 --- a/arch/sh/kernel/cpu/sh4a/clock-shx3.c +++ b/arch/sh/kernel/cpu/sh4a/clock-shx3.c @@ -138,8 +138,8 @@ int __init arch_clk_init(void) for (i = 0; i < ARRAY_SIZE(clks); i++) ret |= clk_register(clks[i]); - for (i = 0; i < ARRAY_SIZE(lookups); i++) - clkdev_add(&lookups[i]); + + clkdev_add_table(lookups, ARRAY_SIZE(lookups)); if (!ret) ret = sh_clk_div4_register(div4_clks, ARRAY_SIZE(div4_clks), -- 1.8.3.1
next prev parent reply other threads:[~2015-03-02 17:06 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-02 17:05 [PATCH 00/10] initial clkdev cleanups Russell King - ARM Linux 2015-03-02 17:05 ` Russell King - ARM Linux 2015-03-02 17:05 ` Russell King - ARM Linux 2015-03-02 17:06 ` [PATCH 01/10] media: omap3isp: remove unused clkdev Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 22:33 ` Laurent Pinchart 2015-03-02 22:33 ` Laurent Pinchart 2015-03-02 22:33 ` Laurent Pinchart 2015-03-02 22:53 ` Sakari Ailus 2015-03-02 22:53 ` Sakari Ailus 2015-03-02 22:53 ` Sakari Ailus 2015-03-02 23:54 ` Russell King - ARM Linux 2015-03-02 23:54 ` Russell King - ARM Linux 2015-03-02 23:54 ` Russell King - ARM Linux 2015-03-03 0:39 ` Laurent Pinchart 2015-03-03 0:39 ` Laurent Pinchart 2015-03-03 0:39 ` Laurent Pinchart 2015-03-03 22:09 ` Sakari Ailus 2015-03-03 22:09 ` Sakari Ailus 2015-03-03 22:09 ` Sakari Ailus 2015-03-03 23:09 ` Sakari Ailus 2015-03-03 23:09 ` Sakari Ailus 2015-03-03 23:09 ` Sakari Ailus 2015-03-02 17:06 ` Russell King [this message] 2015-03-02 17:06 ` [PATCH 02/10] SH: use clkdev_add_table() Russell King 2015-03-02 17:18 ` Geert Uytterhoeven 2015-03-02 17:18 ` Geert Uytterhoeven 2015-03-02 17:18 ` Geert Uytterhoeven 2015-03-02 17:06 ` [PATCH 03/10] clk: versatile: convert Integrator IM/PD-1 to " Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:06 ` [PATCH 04/10] ARM: lpc32xx: convert " Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:06 ` [PATCH 05/10] clkdev: add clkdev_create() helper Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:22 ` Geert Uytterhoeven 2015-03-02 17:22 ` Geert Uytterhoeven 2015-03-02 17:22 ` Geert Uytterhoeven 2015-03-02 17:46 ` Russell King - ARM Linux 2015-03-02 17:46 ` Russell King - ARM Linux 2015-03-02 17:46 ` Russell King - ARM Linux 2015-03-02 20:36 ` Geert Uytterhoeven 2015-03-02 20:36 ` Geert Uytterhoeven 2015-03-02 20:36 ` Geert Uytterhoeven 2015-03-02 19:07 ` Stephen Boyd 2015-03-02 19:07 ` Stephen Boyd 2015-03-02 19:07 ` Stephen Boyd 2015-03-02 21:01 ` Russell King - ARM Linux 2015-03-02 21:01 ` Russell King - ARM Linux 2015-03-02 21:01 ` Russell King - ARM Linux 2015-03-02 21:54 ` Stephen Boyd 2015-03-02 21:54 ` Stephen Boyd 2015-03-02 21:54 ` Stephen Boyd 2015-03-02 17:06 ` [PATCH 06/10] ASOC: migor: use clkdev_create() Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:29 ` Mark Brown 2015-03-02 17:29 ` Mark Brown 2015-03-02 17:29 ` Mark Brown 2015-03-02 17:06 ` [PATCH 07/10] clk: s2mps11: " Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:06 ` [PATCH 08/10] ARM: orion: " Russell King 2015-03-02 17:06 ` Russell King 2015-03-03 10:25 ` Thomas Petazzoni 2015-03-03 10:25 ` Thomas Petazzoni 2015-03-03 10:25 ` Thomas Petazzoni 2015-03-02 17:06 ` [PATCH 09/10] ARM: omap2: " Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:06 ` [PATCH 10/10] ARM: omap2: use clkdev_add_alias() Russell King 2015-03-02 17:06 ` Russell King 2015-03-02 17:06 ` Russell King 2015-03-03 0:13 ` Tony Lindgren 2015-03-03 0:13 ` Tony Lindgren 2015-03-03 0:13 ` Tony Lindgren 2015-03-03 0:13 ` Tony Lindgren 2015-03-02 21:50 ` [PATCH 00/10] initial clkdev cleanups Stephen Boyd 2015-03-02 21:50 ` Stephen Boyd 2015-03-02 21:50 ` Stephen Boyd 2015-03-03 15:56 ` Andy Shevchenko 2015-03-03 15:56 ` Andy Shevchenko 2015-03-03 15:56 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E1YSTnH-0001JY-GT@rmk-PC.arm.linux.org.uk \ --to=rmk+kernel@arm.linux.org.uk \ --cc=alsa-devel@alsa-project.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.