From: Mark Brown <broonie@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Milo Kim <milo.kim@ti.com>,
Doug Anderson <dianders@google.com>,
Caesar Wang <wxt@rock-chips.com>,
Stephen Barber <smbarber@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Ajit Pal Singh <ajitpal.singh@st.com>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
Patrice Chotard <patrice.chotard@st.com>,
kernel@stlinux.com
Subject: Applied "regulator: pwm: Drop unneeded pwm_enable() call" to the regulator tree
Date: Fri, 03 Jun 2016 12:08:47 +0100 [thread overview]
Message-ID: <E1b8my7-0004mI-St@finisterre> (raw)
In-Reply-To: <1464942192-25967-3-git-send-email-boris.brezillon@free-electrons.com>
The patch
regulator: pwm: Drop unneeded pwm_enable() call
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 830583004e615a4637eacc77866b84908414d7a0 Mon Sep 17 00:00:00 2001
From: Boris Brezillon <boris.brezillon@free-electrons.com>
Date: Fri, 3 Jun 2016 10:23:00 +0200
Subject: [PATCH] regulator: pwm: Drop unneeded pwm_enable() call
Now that the PWM regulator driver implements the ->enable/disable() hooks
we can remove the pwm_enable() call from pwm_regulator_set_voltage().
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/pwm-regulator.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index fafa3488e960..ab3cc0235843 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -159,11 +159,6 @@ static int pwm_regulator_set_voltage(struct regulator_dev *rdev,
return ret;
}
- ret = pwm_enable(drvdata->pwm);
- if (ret) {
- dev_err(&rdev->dev, "Failed to enable PWM: %d\n", ret);
- return ret;
- }
drvdata->volt_uV = min_uV;
/* Delay required by PWM regulator to settle to the new voltage */
--
2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.orgMark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Milo Kim <milo.kim@ti.com>,
Doug Anderson <dianders@google.com>,
Caesar Wang <wxt@rock-chips.com>,
Stephen Barber <smbarber@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Ajit Pal Singh <ajitpal.singh@st.com>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
Patrice Chotard <patrice.chotard@st.co>
Subject: Applied "regulator: pwm: Drop unneeded pwm_enable() call" to the regulator tree
Date: Fri, 03 Jun 2016 12:08:47 +0100 [thread overview]
Message-ID: <E1b8my7-0004mI-St@finisterre> (raw)
In-Reply-To: <1464942192-25967-3-git-send-email-boris.brezillon@free-electrons.com>
The patch
regulator: pwm: Drop unneeded pwm_enable() call
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 830583004e615a4637eacc77866b84908414d7a0 Mon Sep 17 00:00:00 2001
From: Boris Brezillon <boris.brezillon@free-electrons.com>
Date: Fri, 3 Jun 2016 10:23:00 +0200
Subject: [PATCH] regulator: pwm: Drop unneeded pwm_enable() call
Now that the PWM regulator driver implements the ->enable/disable() hooks
we can remove the pwm_enable() call from pwm_regulator_set_voltage().
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/pwm-regulator.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index fafa3488e960..ab3cc0235843 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -159,11 +159,6 @@ static int pwm_regulator_set_voltage(struct regulator_dev *rdev,
return ret;
}
- ret = pwm_enable(drvdata->pwm);
- if (ret) {
- dev_err(&rdev->dev, "Failed to enable PWM: %d\n", ret);
- return ret;
- }
drvdata->volt_uV = min_uV;
/* Delay required by PWM regulator to settle to the new voltage */
--
2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.orgMark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Milo Kim <milo.kim@ti.com>,
Doug Anderson <dianders@google.com>,
Caesar Wang <wxt@rock-chips.com>,
Stephen Barber <smbarber@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Ajit Pal Singh <ajitpal.singh@st.com>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
Patrice Chotard <patrice.chotard@st.co>
Subject: Applied "regulator: pwm: Drop unneeded pwm_enable() call" to the regulator tree
Date: Fri, 03 Jun 2016 12:08:47 +0100 [thread overview]
Message-ID: <E1b8my7-0004mI-St@finisterre> (raw)
In-Reply-To: <1464942192-25967-3-git-send-email-boris.brezillon@free-electrons.com>
The patch
regulator: pwm: Drop unneeded pwm_enable() call
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 830583004e615a4637eacc77866b84908414d7a0 Mon Sep 17 00:00:00 2001
From: Boris Brezillon <boris.brezillon@free-electrons.com>
Date: Fri, 3 Jun 2016 10:23:00 +0200
Subject: [PATCH] regulator: pwm: Drop unneeded pwm_enable() call
Now that the PWM regulator driver implements the ->enable/disable() hooks
we can remove the pwm_enable() call from pwm_regulator_set_voltage().
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/pwm-regulator.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index fafa3488e960..ab3cc0235843 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -159,11 +159,6 @@ static int pwm_regulator_set_voltage(struct regulator_dev *rdev,
return ret;
}
- ret = pwm_enable(drvdata->pwm);
- if (ret) {
- dev_err(&rdev->dev, "Failed to enable PWM: %d\n", ret);
- return ret;
- }
drvdata->volt_uV = min_uV;
/* Delay required by PWM regulator to settle to the new voltage */
--
2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: Applied "regulator: pwm: Drop unneeded pwm_enable() call" to the regulator tree
Date: Fri, 03 Jun 2016 12:08:47 +0100 [thread overview]
Message-ID: <E1b8my7-0004mI-St@finisterre> (raw)
In-Reply-To: <1464942192-25967-3-git-send-email-boris.brezillon@free-electrons.com>
The patch
regulator: pwm: Drop unneeded pwm_enable() call
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 830583004e615a4637eacc77866b84908414d7a0 Mon Sep 17 00:00:00 2001
From: Boris Brezillon <boris.brezillon@free-electrons.com>
Date: Fri, 3 Jun 2016 10:23:00 +0200
Subject: [PATCH] regulator: pwm: Drop unneeded pwm_enable() call
Now that the PWM regulator driver implements the ->enable/disable() hooks
we can remove the pwm_enable() call from pwm_regulator_set_voltage().
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/pwm-regulator.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index fafa3488e960..ab3cc0235843 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -159,11 +159,6 @@ static int pwm_regulator_set_voltage(struct regulator_dev *rdev,
return ret;
}
- ret = pwm_enable(drvdata->pwm);
- if (ret) {
- dev_err(&rdev->dev, "Failed to enable PWM: %d\n", ret);
- return ret;
- }
drvdata->volt_uV = min_uV;
/* Delay required by PWM regulator to settle to the new voltage */
--
2.8.1
next prev parent reply other threads:[~2016-06-03 11:09 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 8:22 [PATCH 00/14] regulator: pwm: various improvements Boris Brezillon
2016-06-03 8:22 ` Boris Brezillon
2016-06-03 8:22 ` Boris Brezillon
2016-06-03 8:22 ` [PATCH 01/14] pwm: Add new helpers to create/manipulate PWM states Boris Brezillon
2016-06-03 8:22 ` Boris Brezillon
2016-06-03 8:23 ` [PATCH 02/14] regulator: pwm: Drop unneeded pwm_enable() call Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 11:08 ` Mark Brown [this message]
2016-06-03 11:08 ` Applied "regulator: pwm: Drop unneeded pwm_enable() call" to the regulator tree Mark Brown
2016-06-03 11:08 ` Mark Brown
2016-06-03 11:08 ` Mark Brown
2016-06-03 8:23 ` [PATCH 03/14] pwm: rockchip: Fix period and duty_cycle approximation Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:03 ` Brian Norris
2016-06-03 20:03 ` Brian Norris
2016-06-04 6:19 ` Boris Brezillon
2016-06-04 6:19 ` Boris Brezillon
2016-06-07 17:25 ` Brian Norris
2016-06-07 17:25 ` Brian Norris
2016-06-03 8:23 ` [PATCH 04/14] pwm: rockchip: Add support for hardware readout Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:07 ` Brian Norris
2016-06-03 20:07 ` Brian Norris
2016-06-03 20:20 ` Brian Norris
2016-06-03 20:20 ` Brian Norris
2016-06-04 6:24 ` Boris Brezillon
2016-06-04 6:24 ` Boris Brezillon
2016-06-07 17:26 ` Brian Norris
2016-06-07 17:26 ` Brian Norris
2016-06-03 8:23 ` [PATCH 05/14] pwm: rockchip: Avoid glitches on already running PWMs Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:28 ` Brian Norris
2016-06-03 20:28 ` Brian Norris
2016-06-04 6:26 ` Boris Brezillon
2016-06-04 6:26 ` Boris Brezillon
2016-06-03 8:23 ` [PATCH 06/14] pwm: rockchip: Add support for atomic update Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:37 ` Brian Norris
2016-06-03 20:37 ` Brian Norris
2016-06-03 20:37 ` Brian Norris
2016-06-03 8:23 ` [PATCH 07/14] pwm: sti: Add support for hardware readout Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` [PATCH 08/14] pwm: sti: Avoid glitches on already running PWMs Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:38 ` Brian Norris
2016-06-03 20:38 ` Brian Norris
2016-06-03 20:38 ` Brian Norris
2016-06-03 8:23 ` [PATCH 09/14] regulator: pwm: Adjust PWM config at probe time Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:41 ` Brian Norris
2016-06-03 20:41 ` Brian Norris
2016-06-03 8:23 ` [PATCH 10/14] regulator: pwm: Switch to the atomic PWM API Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:50 ` Brian Norris
2016-06-03 20:50 ` Brian Norris
2016-06-03 20:50 ` Brian Norris
2016-06-04 6:28 ` Boris Brezillon
2016-06-04 6:28 ` Boris Brezillon
2016-06-06 6:14 ` Laxman Dewangan
2016-06-06 6:14 ` Laxman Dewangan
2016-06-06 6:14 ` Laxman Dewangan
2016-06-03 8:23 ` [PATCH 11/14] regulator: pwm: properly initialize the ->state field Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:51 ` Brian Norris
2016-06-03 20:51 ` Brian Norris
2016-06-03 8:23 ` [PATCH 12/14] regulator: pwm: Retrieve correct voltage Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 20:55 ` Brian Norris
2016-06-03 20:55 ` Brian Norris
2016-06-03 8:23 ` [PATCH 13/14] regulator: pwm: Support extra continuous mode cases Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 21:03 ` Brian Norris
2016-06-03 21:03 ` Brian Norris
2016-06-04 6:30 ` Boris Brezillon
2016-06-04 6:30 ` Boris Brezillon
2016-06-03 8:23 ` [PATCH 14/14] regulator: pwm: Document pwm-dutycycle-unit and pwm-dutycycle-range Boris Brezillon
2016-06-03 8:23 ` Boris Brezillon
2016-06-03 21:04 ` Brian Norris
2016-06-03 21:04 ` Brian Norris
2016-06-03 21:04 ` Brian Norris
2016-06-06 14:09 ` Rob Herring
2016-06-06 14:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1b8my7-0004mI-St@finisterre \
--to=broonie@kernel.org \
--cc=ajitpal.singh@st.com \
--cc=boris.brezillon@free-electrons.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@stlinux.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maxime.coquelin@st.com \
--cc=milo.kim@ti.com \
--cc=patrice.chotard@st.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=smbarber@chromium.org \
--cc=srinivas.kandagatla@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.