From: Alexander Kochetkov <al.kochet@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
LAK <linux-arm-kernel@lists.infradead.org>,
linux-rockchip@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
Heiko Stuebner <heiko@sntech.de>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Caesar Wang <wxt@rock-chips.com>,
Huang Tao <huangtao@rock-chips.com>
Subject: Re: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device
Date: Mon, 23 Jan 2017 19:45:10 +0300 [thread overview]
Message-ID: <EA64873A-7F03-4095-BE38-939183B6457E@gmail.com> (raw)
In-Reply-To: <20170123162624.GG2166@mai>
Daniel, thanks for reviewing patches!
> 23 янв. 2017 г., в 19:26, Daniel Lezcano <daniel.lezcano@linaro.org> написал(а):
>
> On Tue, Nov 29, 2016 at 07:14:49PM +0300, Alexander Kochetkov wrote:
>> The patch move ce field out of struct bc_timer into struct
>> rk_clock_event_device and rename struct bc_timer to struct rk_timer.
>
> Why ?
Single rockchip timer can be either broadcast timer/clockevent (current implementation) or
clocksource (the one I’ve implemented in series). Both implementations based on
low level timer routines (rk_timer_disable, rk_timer_enable, rk_timer_update_counter,
rk_timer_counter_read and so on). Both implementations use timers in different modes
(interrupts vs free running). In order to distinguish this concepts I tried to split
low level timer routines from bc_timer.
Otherwise I can place all needed clocksource filelds into 'struct bc_timer’ and rename 'struct bc_timer’
into 'struct rk_timer’. If this is more clear solution I can rewrite patches.
Alexander.
WARNING: multiple messages have this Message-ID (diff)
From: al.kochet@gmail.com (Alexander Kochetkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device
Date: Mon, 23 Jan 2017 19:45:10 +0300 [thread overview]
Message-ID: <EA64873A-7F03-4095-BE38-939183B6457E@gmail.com> (raw)
In-Reply-To: <20170123162624.GG2166@mai>
Daniel, thanks for reviewing patches!
> 23 ???. 2017 ?., ? 19:26, Daniel Lezcano <daniel.lezcano@linaro.org> ???????(?):
>
> On Tue, Nov 29, 2016 at 07:14:49PM +0300, Alexander Kochetkov wrote:
>> The patch move ce field out of struct bc_timer into struct
>> rk_clock_event_device and rename struct bc_timer to struct rk_timer.
>
> Why ?
Single rockchip timer can be either broadcast timer/clockevent (current implementation) or
clocksource (the one I?ve implemented in series). Both implementations based on
low level timer routines (rk_timer_disable, rk_timer_enable, rk_timer_update_counter,
rk_timer_counter_read and so on). Both implementations use timers in different modes
(interrupts vs free running). In order to distinguish this concepts I tried to split
low level timer routines from bc_timer.
Otherwise I can place all needed clocksource filelds into 'struct bc_timer? and rename 'struct bc_timer?
into 'struct rk_timer?. If this is more clear solution I can rewrite patches.
Alexander.
next prev parent reply other threads:[~2017-01-23 16:45 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 14:31 [PATCHv2 00/11] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 01/11] dt-bindings: clarify compatible property for rockchip timers Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 02/11] ARM: dts: rockchip: update compatible property for rk3228 timer Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 03/11] ARM: dts: rockchip: update compatible property for rk3229 timer Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 04/11] ARM: dts: rockchip: add timer entries to rk3188 dtsi Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 05/11] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 06/11] clocksource/drivers/rockchip_timer: low level routines take rk_timer as parameter Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 07/11] clocksource/drivers/rockchip_timer: drop unused rk_base() and rk_ctrl() Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 08/11] clocksource/drivers/rockchip_timer: move TIMER_INT_UNMASK out of rk_timer_enable() Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 09/11] clocksource/drivers/rockchip_timer: implement loading 64bit value into timer Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 10/11] clocksource/drivers/rockchip_timer: implement reading 64bit value from timer Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 11/11] clocksource/drivers/rockchip_timer: implement clocksource timer Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 00/13] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 01/13] dt-bindings: clarify compatible property for rockchip timers Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 02/13] ARM: dts: rockchip: update compatible property for rk3228 timer Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 03/13] ARM: dts: rockchip: update compatible property for rk3229 timer Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 04/13] ARM: dts: rockchip: add timer entries to rk3188 dtsi Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 05/13] ARM: dts: rockchip: disable arm-global-timer for rk3188 Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 06/13] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 07/13] clocksource/drivers/rockchip_timer: low level routines take rk_timer as parameter Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 08/13] clocksource/drivers/rockchip_timer: drop unused rk_base() and rk_ctrl() Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 15:03 ` Heiko Stübner
2016-11-29 15:03 ` Heiko Stübner
2016-11-29 15:03 ` Heiko Stübner
2016-11-29 13:45 ` [PATCH v3 09/13] clocksource/drivers/rockchip_timer: move TIMER_INT_UNMASK out of rk_timer_enable() Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 10/13] clocksource/drivers/rockchip_timer: implement loading 64bit value into timer Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 11/13] clocksource/drivers/rockchip_timer: implement reading 64bit value from timer Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 12/13] clocksource/drivers/rockchip_timer: implement clocksource timer Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` [PATCH v3 13/13] clocksource/drivers/rockchip_timer: Prevent ftrace recursion Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 13:45 ` Alexander Kochetkov
2016-11-29 15:01 ` Heiko Stübner
2016-11-29 15:01 ` Heiko Stübner
2016-11-29 15:01 ` Heiko Stübner
2016-11-29 15:36 ` Alexander Kochetkov
2016-11-29 15:36 ` Alexander Kochetkov
2016-11-29 15:36 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 1/9] dt-bindings: clarify compatible property for rockchip timers Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-12-05 22:22 ` Rob Herring
2016-12-05 22:22 ` Rob Herring
2016-12-05 22:22 ` Rob Herring
2016-11-29 16:14 ` [PATCH v4 2/9] ARM: dts: rockchip: update compatible property for rk3228 timer Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2017-01-23 15:40 ` Daniel Lezcano
2017-01-23 15:40 ` Daniel Lezcano
2017-01-23 15:40 ` Daniel Lezcano
2017-01-23 16:12 ` Heiko Stübner
2017-01-23 16:12 ` Heiko Stübner
2017-01-23 16:12 ` Heiko Stübner
2017-01-23 16:13 ` Alexander Kochetkov
2017-01-23 16:13 ` Alexander Kochetkov
2017-01-23 16:13 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 3/9] ARM: dts: rockchip: update compatible property for rk3229 timer Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 4/9] ARM: dts: rockchip: add timer entries to rk3188 SoC Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 5/9] ARM: dts: rockchip: disable arm-global-timer for rk3188 Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2017-01-23 16:14 ` Heiko Stübner
2017-01-23 16:14 ` Heiko Stübner
2016-11-29 16:14 ` [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2017-01-23 16:26 ` Daniel Lezcano
2017-01-23 16:26 ` Daniel Lezcano
2017-01-23 16:45 ` Alexander Kochetkov [this message]
2017-01-23 16:45 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 7/9] clocksource/drivers/rockchip_timer: low level routines take rk_timer as parameter Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 8/9] clocksource/drivers/rockchip_timer: move TIMER_INT_UNMASK out of rk_timer_enable() Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2016-11-29 16:14 ` [PATCH v4 9/9] clocksource/drivers/rockchip_timer: implement clocksource timer Alexander Kochetkov
2016-11-29 16:14 ` Alexander Kochetkov
2017-01-23 17:09 ` Heiko Stübner
2017-01-23 17:09 ` Heiko Stübner
2016-12-21 14:21 ` [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-12-21 14:21 ` Alexander Kochetkov
2016-12-21 14:21 ` Alexander Kochetkov
2017-01-23 14:47 ` Daniel Lezcano
2017-01-23 14:47 ` Daniel Lezcano
2017-01-23 14:47 ` Daniel Lezcano
2017-01-23 17:12 ` Heiko Stübner
2017-01-23 17:12 ` Heiko Stübner
2017-01-23 17:24 ` Alexander Kochetkov
2017-01-23 17:24 ` Alexander Kochetkov
2017-01-23 17:24 ` Alexander Kochetkov
2017-01-23 17:57 ` Daniel Lezcano
2017-01-23 17:57 ` Daniel Lezcano
2017-01-26 11:08 ` Alexander Kochetkov
2017-01-26 11:08 ` Alexander Kochetkov
2017-01-26 11:08 ` Alexander Kochetkov
2017-01-26 13:19 ` Daniel Lezcano
2017-01-26 13:19 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EA64873A-7F03-4095-BE38-939183B6457E@gmail.com \
--to=al.kochet@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.