From: "Li, Liang Z" <liang.z.li@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
"mst@redhat.com" <mst@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"quintela@redhat.com" <quintela@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>
Subject: RE: [RESEND PATCH v3 kernel 2/7] virtio-balloon: define new feature bit and page bitmap head
Date: Tue, 25 Oct 2016 01:21:21 +0000 [thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E3A0FB4FF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <580E3C07.701@intel.com>
> On 10/20/2016 11:24 PM, Liang Li wrote:
> > Add a new feature which supports sending the page information with a
> > bitmap. The current implementation uses PFNs array, which is not very
> > efficient. Using bitmap can improve the performance of
> > inflating/deflating significantly
>
> Why is it not efficient? How is using a bitmap more efficient? What kinds of
> cases is the bitmap inefficient?
>
> > The page bitmap header will used to tell the host some information
> > about the page bitmap. e.g. the page size, page bitmap length and
> > start pfn.
>
> Why did you choose to add these features to the structure? What benefits
> do they add?
>
> Could you describe your solution a bit here, and describe its strengths and
> weaknesses?
>
Will elaborate the solution in V4.
> > /* Size of a PFN in the balloon interface. */ #define
> > VIRTIO_BALLOON_PFN_SHIFT 12 @@ -82,4 +83,22 @@ struct
> > virtio_balloon_stat {
> > __virtio64 val;
> > } __attribute__((packed));
> >
> > +/* Page bitmap header structure */
> > +struct balloon_bmap_hdr {
> > + /* Used to distinguish different request */
> > + __virtio16 cmd;
> > + /* Shift width of page in the bitmap */
> > + __virtio16 page_shift;
> > + /* flag used to identify different status */
> > + __virtio16 flag;
> > + /* Reserved */
> > + __virtio16 reserved;
> > + /* ID of the request */
> > + __virtio64 req_id;
> > + /* The pfn of 0 bit in the bitmap */
> > + __virtio64 start_pfn;
> > + /* The length of the bitmap, in bytes */
> > + __virtio64 bmap_len;
> > +};
>
> FWIW this is totally unreadable. Please do something like this:
>
> > +struct balloon_bmap_hdr {
> > + __virtio16 cmd; /* Used to distinguish different ...
> > + __virtio16 page_shift; /* Shift width of page in the bitmap */
> > + __virtio16 flag; /* flag used to identify different...
> > + __virtio16 reserved; /* Reserved */
> > + __virtio64 req_id; /* ID of the request */
> > + __virtio64 start_pfn; /* The pfn of 0 bit in the bitmap */
> > + __virtio64 bmap_len; /* The length of the bitmap, in bytes */
> > +};
>
> and please make an effort to add useful comments. "/* Reserved */"
> seems like a waste of bytes to me.
OK. Maybe 'padding' is better than 'reserved' .
Thanks for your comments!
Liang
WARNING: multiple messages have this Message-ID (diff)
From: "Li, Liang Z" <liang.z.li@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
"mst@redhat.com" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"amit.shah@redhat.com" <amit.shah@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"dgilbert@redhat.com" <dgilbert@redhat.com>
Subject: RE: [RESEND PATCH v3 kernel 2/7] virtio-balloon: define new feature bit and page bitmap head
Date: Tue, 25 Oct 2016 01:21:21 +0000 [thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E3A0FB4FF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <580E3C07.701@intel.com>
> On 10/20/2016 11:24 PM, Liang Li wrote:
> > Add a new feature which supports sending the page information with a
> > bitmap. The current implementation uses PFNs array, which is not very
> > efficient. Using bitmap can improve the performance of
> > inflating/deflating significantly
>
> Why is it not efficient? How is using a bitmap more efficient? What kinds of
> cases is the bitmap inefficient?
>
> > The page bitmap header will used to tell the host some information
> > about the page bitmap. e.g. the page size, page bitmap length and
> > start pfn.
>
> Why did you choose to add these features to the structure? What benefits
> do they add?
>
> Could you describe your solution a bit here, and describe its strengths and
> weaknesses?
>
Will elaborate the solution in V4.
> > /* Size of a PFN in the balloon interface. */ #define
> > VIRTIO_BALLOON_PFN_SHIFT 12 @@ -82,4 +83,22 @@ struct
> > virtio_balloon_stat {
> > __virtio64 val;
> > } __attribute__((packed));
> >
> > +/* Page bitmap header structure */
> > +struct balloon_bmap_hdr {
> > + /* Used to distinguish different request */
> > + __virtio16 cmd;
> > + /* Shift width of page in the bitmap */
> > + __virtio16 page_shift;
> > + /* flag used to identify different status */
> > + __virtio16 flag;
> > + /* Reserved */
> > + __virtio16 reserved;
> > + /* ID of the request */
> > + __virtio64 req_id;
> > + /* The pfn of 0 bit in the bitmap */
> > + __virtio64 start_pfn;
> > + /* The length of the bitmap, in bytes */
> > + __virtio64 bmap_len;
> > +};
>
> FWIW this is totally unreadable. Please do something like this:
>
> > +struct balloon_bmap_hdr {
> > + __virtio16 cmd; /* Used to distinguish different ...
> > + __virtio16 page_shift; /* Shift width of page in the bitmap */
> > + __virtio16 flag; /* flag used to identify different...
> > + __virtio16 reserved; /* Reserved */
> > + __virtio64 req_id; /* ID of the request */
> > + __virtio64 start_pfn; /* The pfn of 0 bit in the bitmap */
> > + __virtio64 bmap_len; /* The length of the bitmap, in bytes */
> > +};
>
> and please make an effort to add useful comments. "/* Reserved */"
> seems like a waste of bytes to me.
OK. Maybe 'padding' is better than 'reserved' .
Thanks for your comments!
Liang
WARNING: multiple messages have this Message-ID (diff)
From: "Li, Liang Z" <liang.z.li@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
"mst@redhat.com" <mst@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"quintela@redhat.com" <quintela@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>
Subject: RE: [RESEND PATCH v3 kernel 2/7] virtio-balloon: define new feature bit and page bitmap head
Date: Tue, 25 Oct 2016 01:21:21 +0000 [thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E3A0FB4FF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <580E3C07.701@intel.com>
> On 10/20/2016 11:24 PM, Liang Li wrote:
> > Add a new feature which supports sending the page information with a
> > bitmap. The current implementation uses PFNs array, which is not very
> > efficient. Using bitmap can improve the performance of
> > inflating/deflating significantly
>
> Why is it not efficient? How is using a bitmap more efficient? What kinds of
> cases is the bitmap inefficient?
>
> > The page bitmap header will used to tell the host some information
> > about the page bitmap. e.g. the page size, page bitmap length and
> > start pfn.
>
> Why did you choose to add these features to the structure? What benefits
> do they add?
>
> Could you describe your solution a bit here, and describe its strengths and
> weaknesses?
>
Will elaborate the solution in V4.
> > /* Size of a PFN in the balloon interface. */ #define
> > VIRTIO_BALLOON_PFN_SHIFT 12 @@ -82,4 +83,22 @@ struct
> > virtio_balloon_stat {
> > __virtio64 val;
> > } __attribute__((packed));
> >
> > +/* Page bitmap header structure */
> > +struct balloon_bmap_hdr {
> > + /* Used to distinguish different request */
> > + __virtio16 cmd;
> > + /* Shift width of page in the bitmap */
> > + __virtio16 page_shift;
> > + /* flag used to identify different status */
> > + __virtio16 flag;
> > + /* Reserved */
> > + __virtio16 reserved;
> > + /* ID of the request */
> > + __virtio64 req_id;
> > + /* The pfn of 0 bit in the bitmap */
> > + __virtio64 start_pfn;
> > + /* The length of the bitmap, in bytes */
> > + __virtio64 bmap_len;
> > +};
>
> FWIW this is totally unreadable. Please do something like this:
>
> > +struct balloon_bmap_hdr {
> > + __virtio16 cmd; /* Used to distinguish different ...
> > + __virtio16 page_shift; /* Shift width of page in the bitmap */
> > + __virtio16 flag; /* flag used to identify different...
> > + __virtio16 reserved; /* Reserved */
> > + __virtio64 req_id; /* ID of the request */
> > + __virtio64 start_pfn; /* The pfn of 0 bit in the bitmap */
> > + __virtio64 bmap_len; /* The length of the bitmap, in bytes */
> > +};
>
> and please make an effort to add useful comments. "/* Reserved */"
> seems like a waste of bytes to me.
OK. Maybe 'padding' is better than 'reserved' .
Thanks for your comments!
Liang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Li, Liang Z" <liang.z.li@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
"mst@redhat.com" <mst@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"quintela@redhat.com" <quintela@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [RESEND PATCH v3 kernel 2/7] virtio-balloon: define new feature bit and page bitmap head
Date: Tue, 25 Oct 2016 01:21:21 +0000 [thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E3A0FB4FF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <580E3C07.701@intel.com>
> On 10/20/2016 11:24 PM, Liang Li wrote:
> > Add a new feature which supports sending the page information with a
> > bitmap. The current implementation uses PFNs array, which is not very
> > efficient. Using bitmap can improve the performance of
> > inflating/deflating significantly
>
> Why is it not efficient? How is using a bitmap more efficient? What kinds of
> cases is the bitmap inefficient?
>
> > The page bitmap header will used to tell the host some information
> > about the page bitmap. e.g. the page size, page bitmap length and
> > start pfn.
>
> Why did you choose to add these features to the structure? What benefits
> do they add?
>
> Could you describe your solution a bit here, and describe its strengths and
> weaknesses?
>
Will elaborate the solution in V4.
> > /* Size of a PFN in the balloon interface. */ #define
> > VIRTIO_BALLOON_PFN_SHIFT 12 @@ -82,4 +83,22 @@ struct
> > virtio_balloon_stat {
> > __virtio64 val;
> > } __attribute__((packed));
> >
> > +/* Page bitmap header structure */
> > +struct balloon_bmap_hdr {
> > + /* Used to distinguish different request */
> > + __virtio16 cmd;
> > + /* Shift width of page in the bitmap */
> > + __virtio16 page_shift;
> > + /* flag used to identify different status */
> > + __virtio16 flag;
> > + /* Reserved */
> > + __virtio16 reserved;
> > + /* ID of the request */
> > + __virtio64 req_id;
> > + /* The pfn of 0 bit in the bitmap */
> > + __virtio64 start_pfn;
> > + /* The length of the bitmap, in bytes */
> > + __virtio64 bmap_len;
> > +};
>
> FWIW this is totally unreadable. Please do something like this:
>
> > +struct balloon_bmap_hdr {
> > + __virtio16 cmd; /* Used to distinguish different ...
> > + __virtio16 page_shift; /* Shift width of page in the bitmap */
> > + __virtio16 flag; /* flag used to identify different...
> > + __virtio16 reserved; /* Reserved */
> > + __virtio64 req_id; /* ID of the request */
> > + __virtio64 start_pfn; /* The pfn of 0 bit in the bitmap */
> > + __virtio64 bmap_len; /* The length of the bitmap, in bytes */
> > +};
>
> and please make an effort to add useful comments. "/* Reserved */"
> seems like a waste of bytes to me.
OK. Maybe 'padding' is better than 'reserved' .
Thanks for your comments!
Liang
next prev parent reply other threads:[~2016-10-25 1:21 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 6:24 [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [RESEND PATCH v3 kernel 1/7] virtio-balloon: rework deflate to add page to a list Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-24 16:46 ` Dave Hansen
2016-10-24 16:46 ` Dave Hansen
2016-10-24 16:46 ` [Qemu-devel] " Dave Hansen
2016-10-24 16:46 ` Dave Hansen
2016-10-25 1:14 ` Li, Liang Z
2016-10-25 1:14 ` [Qemu-devel] " Li, Liang Z
2016-10-25 1:14 ` Li, Liang Z
2016-10-25 1:14 ` Li, Liang Z
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [RESEND PATCH v3 kernel 2/7] virtio-balloon: define new feature bit and page bitmap head Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-24 16:51 ` Dave Hansen
2016-10-24 16:51 ` [Qemu-devel] " Dave Hansen
2016-10-24 16:51 ` Dave Hansen
2016-10-24 16:51 ` Dave Hansen
2016-10-25 1:21 ` Li, Liang Z [this message]
2016-10-25 1:21 ` [Qemu-devel] " Li, Liang Z
2016-10-25 1:21 ` Li, Liang Z
2016-10-25 1:21 ` Li, Liang Z
2016-10-26 15:35 ` Michael S. Tsirkin
2016-10-26 15:35 ` [Qemu-devel] " Michael S. Tsirkin
2016-10-26 15:35 ` Michael S. Tsirkin
2016-10-26 15:35 ` Michael S. Tsirkin
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [RESEND PATCH v3 kernel 3/7] mm: add a function to get the max pfn Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-24 16:53 ` Dave Hansen
2016-10-24 16:53 ` [Qemu-devel] " Dave Hansen
2016-10-24 16:53 ` Dave Hansen
2016-10-25 1:24 ` Li, Liang Z
2016-10-25 1:24 ` Li, Liang Z
2016-10-25 1:24 ` [Qemu-devel] " Li, Liang Z
2016-10-25 1:24 ` Li, Liang Z
2016-10-25 1:24 ` Li, Liang Z
2016-10-24 16:53 ` Dave Hansen
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [RESEND PATCH v3 kernel 4/7] virtio-balloon: speed up inflate/deflate process Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-25 6:36 ` Michael S. Tsirkin
2016-10-25 6:36 ` [Qemu-devel] " Michael S. Tsirkin
2016-10-25 6:36 ` Michael S. Tsirkin
2016-10-25 6:36 ` Michael S. Tsirkin
2016-10-25 9:46 ` Li, Liang Z
2016-10-25 9:46 ` [Qemu-devel] " Li, Liang Z
2016-10-25 9:46 ` Li, Liang Z
2016-10-25 9:46 ` Li, Liang Z
2016-10-21 6:24 ` [RESEND PATCH v3 kernel 5/7] mm: add the related functions to get unused page Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [RESEND PATCH v3 kernel 6/7] virtio-balloon: define feature bit and head for misc virt queue Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-27 18:29 ` Michael S. Tsirkin
2016-10-27 18:29 ` [Qemu-devel] " Michael S. Tsirkin
2016-10-27 18:29 ` Michael S. Tsirkin
2016-10-27 18:29 ` Michael S. Tsirkin
2016-10-21 6:24 ` [RESEND PATCH v3 kernel 7/7] virtio-balloon: tell host vm's unused page info Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 6:24 ` [Qemu-devel] " Liang Li
2016-10-21 6:24 ` Liang Li
2016-10-21 17:25 ` [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration Dave Hansen
2016-10-21 17:25 ` [Qemu-devel] " Dave Hansen
2016-10-21 17:25 ` Dave Hansen
2016-10-21 17:25 ` Dave Hansen
2016-10-21 19:44 ` Michael S. Tsirkin
2016-10-21 19:44 ` Michael S. Tsirkin
2016-10-21 19:44 ` [Qemu-devel] " Michael S. Tsirkin
2016-10-21 19:44 ` Michael S. Tsirkin
2016-10-23 11:29 ` Li, Liang Z
2016-10-23 11:29 ` Li, Liang Z
2016-10-23 11:29 ` [Qemu-devel] " Li, Liang Z
2016-10-23 11:29 ` Li, Liang Z
2016-10-25 3:52 ` Michael S. Tsirkin
2016-10-25 3:52 ` Michael S. Tsirkin
2016-10-25 3:52 ` [Qemu-devel] " Michael S. Tsirkin
2016-10-25 3:52 ` Michael S. Tsirkin
2016-10-25 3:52 ` Michael S. Tsirkin
2016-10-26 10:06 ` Li, Liang Z
2016-10-26 10:06 ` [Qemu-devel] " Li, Liang Z
2016-10-26 10:06 ` Li, Liang Z
2016-10-26 10:06 ` Li, Liang Z
2016-10-26 10:13 ` Li, Liang Z
2016-10-26 10:13 ` Li, Liang Z
2016-10-26 10:13 ` [Qemu-devel] " Li, Liang Z
2016-10-26 10:13 ` Li, Liang Z
2016-10-26 10:13 ` Li, Liang Z
2016-10-26 18:15 ` Dave Hansen
2016-10-26 18:15 ` [Qemu-devel] " Dave Hansen
2016-10-26 18:15 ` Dave Hansen
2016-10-26 18:15 ` Dave Hansen
2016-10-27 0:36 ` Li, Liang Z
2016-10-27 0:36 ` Li, Liang Z
2016-10-27 0:36 ` [Qemu-devel] " Li, Liang Z
2016-10-27 0:36 ` Li, Liang Z
2016-10-27 0:36 ` Li, Liang Z
2016-10-26 18:11 ` Dave Hansen
2016-10-26 18:11 ` [Qemu-devel] " Dave Hansen
2016-10-26 18:11 ` Dave Hansen
2016-10-27 0:51 ` Li, Liang Z
2016-10-27 0:51 ` [Qemu-devel] " Li, Liang Z
2016-10-27 0:51 ` Li, Liang Z
2016-10-27 0:51 ` Li, Liang Z
2016-10-26 18:11 ` Dave Hansen
2016-10-26 10:06 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2CBF3009FA73547804AE4C663CAB28E3A0FB4FF@shsmsx102.ccr.corp.intel.com \
--to=liang.z.li@intel.com \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dave.hansen@intel.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.