From: "Deucher, Alexander" <Alexander.Deucher@amd.com> To: "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "ckoenig.leichtzumerken@gmail.com" <ckoenig.leichtzumerken@gmail.com>, "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>, "Wentland, Harry" <Harry.Wentland@amd.com> Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "helgaas@kernel.org" <helgaas@kernel.org>, "Kuehling, Felix" <Felix.Kuehling@amd.com> Subject: Re: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit Date: Tue, 11 May 2021 13:24:42 +0000 [thread overview] Message-ID: <MN2PR12MB4488E82C859899CDB2BE8D7AF7539@MN2PR12MB4488.namprd12.prod.outlook.com> (raw) In-Reply-To: <20210510163625.407105-5-andrey.grodzovsky@amd.com> [-- Attachment #1: Type: text/plain, Size: 3280 bytes --] [AMD Public Use] Typo in the subject: devie > device Alex ________________________________ From: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com> Sent: Monday, May 10, 2021 12:36 PM To: dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; linux-pci@vger.kernel.org <linux-pci@vger.kernel.org>; ckoenig.leichtzumerken@gmail.com <ckoenig.leichtzumerken@gmail.com>; daniel.vetter@ffwll.ch <daniel.vetter@ffwll.ch>; Wentland, Harry <Harry.Wentland@amd.com> Cc: ppaalanen@gmail.com <ppaalanen@gmail.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>; helgaas@kernel.org <helgaas@kernel.org>; Kuehling, Felix <Felix.Kuehling@amd.com>; Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com> Subject: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit Helps to expdite HW related stuff to amdgpu_pci_remove Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c index 5f6696a3c778..2b06dee9a0ce 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c @@ -170,7 +170,7 @@ void amdgpu_amdkfd_device_init(struct amdgpu_device *adev) } } -void amdgpu_amdkfd_device_fini(struct amdgpu_device *adev) +void amdgpu_amdkfd_device_fini_sw(struct amdgpu_device *adev) { if (adev->kfd.dev) { kgd2kfd_device_exit(adev->kfd.dev); diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h index 14f68c028126..f8e10af99c28 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h @@ -127,7 +127,7 @@ void amdgpu_amdkfd_interrupt(struct amdgpu_device *adev, const void *ih_ring_entry); void amdgpu_amdkfd_device_probe(struct amdgpu_device *adev); void amdgpu_amdkfd_device_init(struct amdgpu_device *adev); -void amdgpu_amdkfd_device_fini(struct amdgpu_device *adev); +void amdgpu_amdkfd_device_fini_sw(struct amdgpu_device *adev); int amdgpu_amdkfd_submit_ib(struct kgd_dev *kgd, enum kgd_engine_type engine, uint32_t vmid, uint64_t gpu_addr, uint32_t *ib_cmd, uint32_t ib_len); diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index 357b9bf62a1c..ab6d2a43c9a3 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c @@ -858,10 +858,11 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd, return kfd->init_complete; } + + void kgd2kfd_device_exit(struct kfd_dev *kfd) { if (kfd->init_complete) { - kgd2kfd_suspend(kfd, false); device_queue_manager_uninit(kfd->dqm); kfd_interrupt_exit(kfd); kfd_topology_remove_device(kfd); -- 2.25.1 [-- Attachment #2: Type: text/html, Size: 5781 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Deucher, Alexander" <Alexander.Deucher@amd.com> To: "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "ckoenig.leichtzumerken@gmail.com" <ckoenig.leichtzumerken@gmail.com>, "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>, "Wentland, Harry" <Harry.Wentland@amd.com> Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "ppaalanen@gmail.com" <ppaalanen@gmail.com>, "helgaas@kernel.org" <helgaas@kernel.org>, "Kuehling, Felix" <Felix.Kuehling@amd.com> Subject: Re: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit Date: Tue, 11 May 2021 13:24:42 +0000 [thread overview] Message-ID: <MN2PR12MB4488E82C859899CDB2BE8D7AF7539@MN2PR12MB4488.namprd12.prod.outlook.com> (raw) In-Reply-To: <20210510163625.407105-5-andrey.grodzovsky@amd.com> [-- Attachment #1.1: Type: text/plain, Size: 3280 bytes --] [AMD Public Use] Typo in the subject: devie > device Alex ________________________________ From: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com> Sent: Monday, May 10, 2021 12:36 PM To: dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; linux-pci@vger.kernel.org <linux-pci@vger.kernel.org>; ckoenig.leichtzumerken@gmail.com <ckoenig.leichtzumerken@gmail.com>; daniel.vetter@ffwll.ch <daniel.vetter@ffwll.ch>; Wentland, Harry <Harry.Wentland@amd.com> Cc: ppaalanen@gmail.com <ppaalanen@gmail.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>; helgaas@kernel.org <helgaas@kernel.org>; Kuehling, Felix <Felix.Kuehling@amd.com>; Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com> Subject: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit Helps to expdite HW related stuff to amdgpu_pci_remove Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c index 5f6696a3c778..2b06dee9a0ce 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c @@ -170,7 +170,7 @@ void amdgpu_amdkfd_device_init(struct amdgpu_device *adev) } } -void amdgpu_amdkfd_device_fini(struct amdgpu_device *adev) +void amdgpu_amdkfd_device_fini_sw(struct amdgpu_device *adev) { if (adev->kfd.dev) { kgd2kfd_device_exit(adev->kfd.dev); diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h index 14f68c028126..f8e10af99c28 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h @@ -127,7 +127,7 @@ void amdgpu_amdkfd_interrupt(struct amdgpu_device *adev, const void *ih_ring_entry); void amdgpu_amdkfd_device_probe(struct amdgpu_device *adev); void amdgpu_amdkfd_device_init(struct amdgpu_device *adev); -void amdgpu_amdkfd_device_fini(struct amdgpu_device *adev); +void amdgpu_amdkfd_device_fini_sw(struct amdgpu_device *adev); int amdgpu_amdkfd_submit_ib(struct kgd_dev *kgd, enum kgd_engine_type engine, uint32_t vmid, uint64_t gpu_addr, uint32_t *ib_cmd, uint32_t ib_len); diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index 357b9bf62a1c..ab6d2a43c9a3 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c @@ -858,10 +858,11 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd, return kfd->init_complete; } + + void kgd2kfd_device_exit(struct kfd_dev *kfd) { if (kfd->init_complete) { - kgd2kfd_suspend(kfd, false); device_queue_manager_uninit(kfd->dqm); kfd_interrupt_exit(kfd); kfd_topology_remove_device(kfd); -- 2.25.1 [-- Attachment #1.2: Type: text/html, Size: 5781 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-05-11 13:24 UTC|newest] Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 16:36 [PATCH v6 00/16] RFC Support hot device unplug in amdgpu Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` [PATCH v6 01/16] drm/ttm: Remap all page faults to per process dummy page Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:38 ` Christian König 2021-05-11 6:38 ` Christian König 2021-05-11 6:38 ` Christian König 2021-05-11 14:44 ` Andrey Grodzovsky 2021-05-11 14:44 ` Andrey Grodzovsky 2021-05-11 14:44 ` Andrey Grodzovsky 2021-05-11 15:12 ` Christian König 2021-05-11 15:12 ` Christian König 2021-05-11 15:12 ` Christian König 2021-05-10 16:36 ` [PATCH v6 02/16] drm/ttm: Expose ttm_tt_unpopulate for driver use Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 18:27 ` Felix Kuehling 2021-05-10 18:27 ` Felix Kuehling 2021-05-10 18:27 ` Felix Kuehling 2021-05-10 18:32 ` Andrey Grodzovsky 2021-05-10 18:32 ` Andrey Grodzovsky 2021-05-10 18:32 ` Andrey Grodzovsky 2021-05-10 16:36 ` [PATCH v6 03/16] drm/amdgpu: Split amdgpu_device_fini into early and late Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 23:49 ` kernel test robot 2021-05-10 23:49 ` kernel test robot 2021-05-10 23:49 ` kernel test robot 2021-05-10 23:49 ` kernel test robot 2021-05-10 16:36 ` [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:40 ` Christian König 2021-05-11 6:40 ` Christian König 2021-05-11 6:40 ` Christian König 2021-05-11 14:52 ` Andrey Grodzovsky 2021-05-11 14:52 ` Andrey Grodzovsky 2021-05-11 14:52 ` Andrey Grodzovsky 2021-05-11 13:24 ` Deucher, Alexander [this message] 2021-05-11 13:24 ` Deucher, Alexander 2021-05-10 16:36 ` [PATCH v6 05/16] drm/amdgpu: Add early fini callback Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:41 ` Christian König 2021-05-11 6:41 ` Christian König 2021-05-11 6:41 ` Christian König 2021-05-10 16:36 ` [PATCH v6 06/16] drm/amdgpu: Handle IOMMU enabled case Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:44 ` Christian König 2021-05-11 6:44 ` Christian König 2021-05-11 6:44 ` Christian König 2021-05-11 15:46 ` Andrey Grodzovsky 2021-05-11 15:46 ` Andrey Grodzovsky 2021-05-11 15:46 ` Andrey Grodzovsky 2021-05-11 15:56 ` Alex Deucher 2021-05-11 15:56 ` Alex Deucher 2021-05-11 15:56 ` Alex Deucher 2021-05-11 15:59 ` Andrey Grodzovsky 2021-05-11 15:59 ` Andrey Grodzovsky 2021-05-11 15:59 ` Andrey Grodzovsky 2021-05-10 16:36 ` [PATCH v6 07/16] drm/amdgpu: Remap all page faults to per process dummy page Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` [PATCH v6 08/16] PCI: Add support for dev_groups to struct pci_device_driver Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 20:56 ` Bjorn Helgaas 2021-05-10 20:56 ` Bjorn Helgaas 2021-05-10 20:56 ` Bjorn Helgaas 2021-05-10 16:36 ` [PATCH v6 09/16] drm/amdgpu: Convert driver sysfs attributes to static attributes Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` [PATCH v6 10/16] drm/amdgpu: Guard against write accesses after device removal Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:50 ` Christian König 2021-05-11 6:50 ` Christian König 2021-05-11 6:50 ` Christian König 2021-05-11 17:52 ` Andrey Grodzovsky 2021-05-11 17:52 ` Andrey Grodzovsky 2021-05-11 17:52 ` Andrey Grodzovsky 2021-05-12 14:01 ` Andrey Grodzovsky 2021-05-12 14:01 ` Andrey Grodzovsky 2021-05-12 14:01 ` Andrey Grodzovsky 2021-05-12 14:06 ` Christian König 2021-05-12 14:06 ` Christian König 2021-05-12 14:06 ` Christian König 2021-05-12 14:11 ` Andrey Grodzovsky 2021-05-12 14:11 ` Andrey Grodzovsky 2021-05-12 14:11 ` Andrey Grodzovsky 2021-05-10 16:36 ` [PATCH v6 11/16] drm/sched: Make timeout timer rearm conditional Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:52 ` Christian König 2021-05-11 6:52 ` Christian König 2021-05-11 6:52 ` Christian König 2021-05-10 16:36 ` [PATCH v6 12/16] drm/amdgpu: Prevent any job recoveries after device is unplugged Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:53 ` Christian König 2021-05-11 6:53 ` Christian König 2021-05-11 6:53 ` Christian König 2021-05-10 16:36 ` [PATCH v6 13/16] drm/amdgpu: Fix hang on device removal Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:54 ` Christian König 2021-05-11 6:54 ` Christian König 2021-05-11 6:54 ` Christian König 2021-05-10 16:36 ` [PATCH v6 14/16] drm/scheduler: Fix hang when sched_entity released Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` [PATCH v6 15/16] drm/amd/display: Remove superflous drm_mode_config_cleanup Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 21:38 ` Rodrigo Siqueira 2021-05-10 21:38 ` Rodrigo Siqueira 2021-05-10 21:38 ` Rodrigo Siqueira 2021-05-10 16:36 ` [PATCH v6 16/16] drm/amdgpu: Verify DMA opearations from device are done Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-10 16:36 ` Andrey Grodzovsky 2021-05-11 6:56 ` Christian König 2021-05-11 6:56 ` Christian König 2021-05-11 6:56 ` Christian König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR12MB4488E82C859899CDB2BE8D7AF7539@MN2PR12MB4488.namprd12.prod.outlook.com \ --to=alexander.deucher@amd.com \ --cc=Andrey.Grodzovsky@amd.com \ --cc=Felix.Kuehling@amd.com \ --cc=Harry.Wentland@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=ckoenig.leichtzumerken@gmail.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=helgaas@kernel.org \ --cc=linux-pci@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.