Re: [RFC PATCH 0/2] Multiqueue support for qemu(virtio-net)

From: Krishna Kumar2 <krkumar2@in.ibm.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org,
	rusty@rustcorp.com.au, qemu-devel@nongnu.org
Subject: Re: [RFC PATCH 0/2] Multiqueue support for qemu(virtio-net)
Date: Wed, 20 Apr 2011 14:22:47 +0530	[thread overview]
Message-ID: <OF7CC46028.9A206852-ON65257878.00307271-65257878.00308D38@in.ibm.com> (raw)
In-Reply-To: <20110420082706.32157.59668.stgit@dhcp-91-7.nay.redhat.com.englab.nay.redhat.com>

Thanks Jason!

So I can use my virtio-net guest driver and test with this patch?
Please provide the script you use to start MQ guest.

Regards,

- KK

Jason Wang <jasowang@redhat.com> wrote on 04/20/2011 02:03:07 PM:

> Jason Wang <jasowang@redhat.com>
> 04/20/2011 02:03 PM
>
> To
>
> Krishna Kumar2/India/IBM@IBMIN, kvm@vger.kernel.org, mst@redhat.com,
> netdev@vger.kernel.org, rusty@rustcorp.com.au, qemu-
> devel@nongnu.org, anthony@codemonkey.ws
>
> cc
>
> Subject
>
> [RFC PATCH 0/2] Multiqueue support for qemu(virtio-net)
>
> Inspired by Krishna's patch
(http://www.spinics.net/lists/kvm/msg52098.html
> ) and
> Michael's suggestions.  The following series adds the multiqueue support
for
> qemu and enable it for virtio-net (both userspace and vhost).
>
> The aim for this series is to simplified the management and achieve the
same
> performacne with less codes.
>
> Follows are the differences between this series and Krishna's:
>
> - Add the multiqueue support for qemu and also for userspace virtio-net
> - Instead of hacking the vhost module to manipulate kthreads, this patch
just
> implement the userspace based multiqueues and thus can re-use the
> existed vhost kernel-side codes without any modification.
> - Use 1:1 mapping between TX/RX pairs and vhost kthread because the
> implementation is based on usersapce.
> - The cli is also changed to make the mgmt easier, the -netdev option of
qdev
> can now accpet more than one ids. You can start a multiqueue virtio-net
device
> through:
> ./qemu-system-x86_64 -netdev tap,id=hn0,vhost=on,fd=X -netdev
> tap,id=hn0,vhost=on,fd=Y -device
virtio-net-pci,netdev=hn0#hn1,queues=2 ...
>
> The series is very primitive and still need polished.
>
> Suggestions are welcomed.
> ---
>
> Jason Wang (2):
>       net: Add multiqueue support
>       virtio-net: add multiqueue support
>
>
>  hw/qdev-properties.c |   37 ++++-
>  hw/qdev.h            |    3
>  hw/vhost.c           |   26 ++-
>  hw/vhost.h           |    1
>  hw/vhost_net.c       |    7 +
>  hw/vhost_net.h       |    2
>  hw/virtio-net.c      |  409 +++++++++++++++++++++++++++++++
> +------------------
>  hw/virtio-net.h      |    2
>  hw/virtio-pci.c      |    1
>  hw/virtio.h          |    1
>  net.c                |   34 +++-
>  net.h                |   15 +-
>  12 files changed, 353 insertions(+), 185 deletions(-)
>
> --
> Jason Wang