RE: [PATCH v5 2/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit ov7725 sensors

From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Prabhakar <prabhakar.csengg@gmail.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Jacopo Mondi <jacopo@jmondi.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v5 2/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit ov7725 sensors
Date: Sun, 21 Feb 2021 20:47:40 +0000	[thread overview]
Message-ID: <OSAPR01MB48671C18C35B6F52EBA37FD2AA829@OSAPR01MB4867.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210122113424.2833127-3-geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: 22 January 2021 11:34
> To: Prabhakar <prabhakar.csengg@gmail.com>; Magnus Damm <magnus.damm@gmail.com>; Rob Herring
> <robh+dt@kernel.org>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Jacopo Mondi <jacopo@jmondi.org>; linux-renesas-
> soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; Prabhakar
> Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; Geert Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH v5 2/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit ov7725 sensors
> 
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> The 8-bit ov7725 sensors can also be connected to the camera daughter
> board.
> 
> This patch creates a separate dtsi file to describe an ov7725 sensor,
> and includes it multiple times in r8a7742-iwg21d-q7-dbcm-ca.dts. The
> user can (un)comment #include statements depending on the cameras
> connected.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> [geert: describe a single camera in the .dtsi, include multiple times]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v5:
>   - Enable parent i2c bus when needed,
> 
> v4:
>   - Describe a single camera in the .dtsi file,
>   - Include the .dtsi multiple times.
> ---
>  .../boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts    |  6 +++-
>  .../r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 29 +++++++++++++++++++
>  2 files changed, 34 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> 

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-
> dbcm-ca.dts
> index bc8280b2ac47e3ec..2bcb229844abc5c2 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> @@ -198,7 +198,7 @@ &scifb1 {
>  /*
>   * Below configuration ties VINx endpoints to ov5640/ov7725 camera endpoints
>   *
> - * Uncomment the #include statements to change configuration
> + * (un)comment the #include statements to change configuration
>   */
> 
>  /* 8bit CMOS Camera 1 (J13) */
> @@ -208,6 +208,7 @@ &scifb1 {
>  #define VIN_EP			vin0ep
>  #undef CAM_ENABLED
>  #include "r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi"
> +//#include "r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi"
> 
>  #ifdef CAM_ENABLED
>  &vin0 {
> @@ -241,6 +242,7 @@ vin0ep: endpoint {
>  #define VIN_EP			vin1ep
>  #undef CAM_ENABLED
>  #include "r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi"
> +//#include "r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi"
> 
>  #ifdef CAM_ENABLED
>  &vin1 {
> @@ -272,6 +274,7 @@ vin1ep: endpoint {
>  #define VIN_EP			vin2ep
>  #undef CAM_ENABLED
>  #include "r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi"
> +//#include "r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi"
> 
>  #ifdef CAM_ENABLED
>  &vin2 {
> @@ -302,6 +305,7 @@ vin2ep: endpoint {
>  #define VIN_EP			vin3ep
>  #undef CAM_ENABLED
>  #include "r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi"
> +//#include "r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi"
> 
>  #ifdef CAM_ENABLED
>  &vin3 {
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-
> iwg21d-q7-dbcm-ov7725-single.dtsi
> new file mode 100644
> index 0000000000000000..f5e77f0242516720
> --- /dev/null
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> @@ -0,0 +1,29 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * This include file ties a VIN interface with a single ov7725 sensor on
> + * the iWave-RZ/G1H Qseven board development platform connected with the
> + * camera daughter board.
> + *
> + * Copyright (C) 2020 Renesas Electronics Corp.
> + */
> +
> +#define CAM_ENABLED	1
> +
> +&CAM_PARENT_I2C {
> +	status = "okay";
> +
> +	ov7725@21 {
> +		compatible = "ovti,ov7725";
> +		reg = <0x21>;
> +		clocks = <&MCLK_CAM>;
> +		status = "okay";
> +
> +		port {
> +			CAM_EP: endpoint {
> +				bus-width = <8>;
> +				bus-type = <6>;
> +				remote-endpoint = <&VIN_EP>;
> +			};
> +		};
> +	};
> +};
> --
> 2.25.1