From: "tarumizu.kohei@fujitsu.com" <tarumizu.kohei@fujitsu.com> To: 'Greg KH' <gregkh@linuxfoundation.org> Cc: "rafael@kernel.org" <rafael@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "conor.dooley@microchip.com" <conor.dooley@microchip.com>, "hpa@zytor.com" <hpa@zytor.com>, "will@kernel.org" <will@kernel.org>, "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>, "x86@kernel.org" <x86@kernel.org>, "mingo@redhat.com" <mingo@redhat.com>, "eugenis@google.com" <eugenis@google.com>, "arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>, "tglx@linutronix.de" <tglx@linutronix.de>, "pcc@google.com" <pcc@google.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "marcos@orca.pet" <marcos@orca.pet>, "tony.luck@intel.com" <tony.luck@intel.com>, "marcan@marcan.st" <marcan@marcan.st>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v4 1/8] drivers: base: Add hardware prefetch control core driver Date: Wed, 18 May 2022 12:38:02 +0000 [thread overview] Message-ID: <OSBPR01MB203742A3195333D0E8785E5A80D19@OSBPR01MB2037.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <YoSbmA+5m1Le0XGe@kroah.com> Thanks for the comment. > This feels wrong, attributes should be groups and be automatically added and > removed by the driver core that way. Not as lists of attributes like this, as that > will race and be wrong. > > Use a list of attribute groups please. > You just raced with userspace and lost :( > > Please use attribute groups instead of manually adding files after the device is > created and userspace is notified that it was present. > > That also makes your clean up logic much simpler (i.e. none as the drive core did it > for you already.) > Attribute groups please. I modify to use attribute groups in the next version. > Why do you think this needs to be in the driver core? Why isn't this just a normal > cpu driver? > > thanks, Does this mean that creating only dedicated driver for a CPU (e.g. arch/x86/kernel/cpu/x86-pfctl.c) without creating core driver? If so, there is no problem. I remove the core driver and create only the dedicated drivers for each CPU in the next version. As a reference, I previously wanted to define it as a common sysfs I/F for A64FX and x86, so I create a core driver to provide it. However, as I proceed with the consideration, it became clear that these were independent I/F specifications. Therefore, the core driver is not currently needed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "tarumizu.kohei@fujitsu.com" <tarumizu.kohei@fujitsu.com> To: 'Greg KH' <gregkh@linuxfoundation.org> Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "rafael@kernel.org" <rafael@kernel.org>, "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>, "eugenis@google.com" <eugenis@google.com>, "tony.luck@intel.com" <tony.luck@intel.com>, "pcc@google.com" <pcc@google.com>, "peterz@infradead.org" <peterz@infradead.org>, "marcos@orca.pet" <marcos@orca.pet>, "conor.dooley@microchip.com" <conor.dooley@microchip.com>, "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>, "marcan@marcan.st" <marcan@marcan.st>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "arnd@arndb.de" <arnd@arndb.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v4 1/8] drivers: base: Add hardware prefetch control core driver Date: Wed, 18 May 2022 12:38:02 +0000 [thread overview] Message-ID: <OSBPR01MB203742A3195333D0E8785E5A80D19@OSBPR01MB2037.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <YoSbmA+5m1Le0XGe@kroah.com> Thanks for the comment. > This feels wrong, attributes should be groups and be automatically added and > removed by the driver core that way. Not as lists of attributes like this, as that > will race and be wrong. > > Use a list of attribute groups please. > You just raced with userspace and lost :( > > Please use attribute groups instead of manually adding files after the device is > created and userspace is notified that it was present. > > That also makes your clean up logic much simpler (i.e. none as the drive core did it > for you already.) > Attribute groups please. I modify to use attribute groups in the next version. > Why do you think this needs to be in the driver core? Why isn't this just a normal > cpu driver? > > thanks, Does this mean that creating only dedicated driver for a CPU (e.g. arch/x86/kernel/cpu/x86-pfctl.c) without creating core driver? If so, there is no problem. I remove the core driver and create only the dedicated drivers for each CPU in the next version. As a reference, I previously wanted to define it as a common sysfs I/F for A64FX and x86, so I create a core driver to provide it. However, as I proceed with the consideration, it became clear that these were independent I/F specifications. Therefore, the core driver is not currently needed.
next prev parent reply other threads:[~2022-05-18 12:41 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 6:30 [PATCH v4 0/8] Add hardware prefetch control driver for A64FX and x86 Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 6:30 ` [PATCH v4 1/8] drivers: base: Add hardware prefetch control core driver Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 7:09 ` Greg KH 2022-05-18 7:09 ` Greg KH 2022-05-18 12:38 ` tarumizu.kohei [this message] 2022-05-18 12:38 ` tarumizu.kohei 2022-05-18 6:30 ` [PATCH v4 2/8] drivers: base: Add Kconfig/Makefile to build " Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 7:04 ` Greg KH 2022-05-18 7:04 ` Greg KH 2022-05-20 6:42 ` tarumizu.kohei 2022-05-20 6:42 ` tarumizu.kohei 2022-05-18 6:30 ` [PATCH v4 3/8] soc: fujitsu: Add hardware prefetch control support for A64FX Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 7:10 ` Greg KH 2022-05-18 7:10 ` Greg KH 2022-05-20 7:06 ` tarumizu.kohei 2022-05-20 7:06 ` tarumizu.kohei 2022-05-18 6:30 ` [PATCH v4 4/8] soc: fujitsu: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 6:30 ` [PATCH v4 5/8] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 7:09 ` Greg KH 2022-05-18 7:09 ` Greg KH 2022-05-20 7:00 ` tarumizu.kohei 2022-05-20 7:00 ` tarumizu.kohei 2022-05-18 6:30 ` [PATCH v4 6/8] x86: Add hardware prefetch control support for x86 Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 6:43 ` Greg KH 2022-05-18 6:43 ` Greg KH 2022-05-20 6:30 ` tarumizu.kohei 2022-05-20 6:30 ` tarumizu.kohei 2022-05-18 6:44 ` Greg KH 2022-05-18 6:44 ` Greg KH 2022-05-20 6:40 ` tarumizu.kohei 2022-05-20 6:40 ` tarumizu.kohei 2022-05-18 6:30 ` [PATCH v4 7/8] x86: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-18 6:43 ` Greg KH 2022-05-18 6:43 ` Greg KH 2022-05-20 6:35 ` tarumizu.kohei 2022-05-20 6:35 ` tarumizu.kohei 2022-05-18 6:30 ` [PATCH v4 8/8] docs: ABI: Add sysfs documentation interface of " Kohei Tarumizu 2022-05-18 6:30 ` Kohei Tarumizu 2022-05-19 8:29 ` [PATCH v4 0/8] Add hardware prefetch control driver for A64FX and x86 Hector Martin 2022-05-19 8:29 ` Hector Martin 2022-05-20 8:31 ` tarumizu.kohei 2022-05-20 8:31 ` tarumizu.kohei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OSBPR01MB203742A3195333D0E8785E5A80D19@OSBPR01MB2037.jpnprd01.prod.outlook.com \ --to=tarumizu.kohei@fujitsu.com \ --cc=arnd@arndb.de \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=conor.dooley@microchip.com \ --cc=dave.hansen@linux.intel.com \ --cc=eugenis@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=hpa@zytor.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marcan@marcan.st \ --cc=marcos@orca.pet \ --cc=mchehab+huawei@kernel.org \ --cc=mingo@redhat.com \ --cc=pcc@google.com \ --cc=peterz@infradead.org \ --cc=rafael@kernel.org \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.