From: Alan Stern <stern@rowland.harvard.edu>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>, "Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
<linux-pm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Aaron Lu <aaron.lwe@gmail.com>,
Shane Huang <shane.huang@amd.com>
Subject: Re: [PATCH v7 4/4] sd: change to auto suspend mode
Date: Mon, 28 Jan 2013 10:12:44 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1301281011570.1997-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <20130128085651.GA2568@aaronlu.sh.intel.com>
On Mon, 28 Jan 2013, Aaron Lu wrote:
> > Someone just asked about the default autosuspend delay, and I realized
> > your patch series doesn't set one. Since we don't know the properties
> > of the disk drive at this point (or even whether the device is a disk
> > drive), the only safe course is to call
> >
> > pm_runtime_set_autosuspend_delay(&sdev->sdev_gendev, -1);
> >
> > before calling blk_pm_runtime_init(). Then autosuspends will be
> > prevented until userspace writes a non-negative value into the device's
> > control/autosuspend_delay_ms file.
>
> Shall we do it inside blk_pm_runtime_init? This way, we do not need to
> do it for every driver. And for drivers that do know a proper value for
> autosuspend delay, they can call pm_runtime_set_autosuspend_delay
> somewhere after blk_pm_runtime_init.
Yes, that seems like a good approach. Be sure to mention it in the
kerneldoc.
Alan Stern
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>, "Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Aaron Lu <aaron.lwe@gmail.com>,
Shane Huang <shane.huang@amd.com>
Subject: Re: [PATCH v7 4/4] sd: change to auto suspend mode
Date: Mon, 28 Jan 2013 10:12:44 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1301281011570.1997-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <20130128085651.GA2568@aaronlu.sh.intel.com>
On Mon, 28 Jan 2013, Aaron Lu wrote:
> > Someone just asked about the default autosuspend delay, and I realized
> > your patch series doesn't set one. Since we don't know the properties
> > of the disk drive at this point (or even whether the device is a disk
> > drive), the only safe course is to call
> >
> > pm_runtime_set_autosuspend_delay(&sdev->sdev_gendev, -1);
> >
> > before calling blk_pm_runtime_init(). Then autosuspends will be
> > prevented until userspace writes a non-negative value into the device's
> > control/autosuspend_delay_ms file.
>
> Shall we do it inside blk_pm_runtime_init? This way, we do not need to
> do it for every driver. And for drivers that do know a proper value for
> autosuspend delay, they can call pm_runtime_set_autosuspend_delay
> somewhere after blk_pm_runtime_init.
Yes, that seems like a good approach. Be sure to mention it in the
kerneldoc.
Alan Stern
next prev parent reply other threads:[~2013-01-28 15:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 9:02 [PATCH v7 0/4] block layer runtime pm Aaron Lu
2013-01-16 9:02 ` [PATCH v7 1/4] block: add a flag to identify PM request Aaron Lu
2013-01-16 9:02 ` [PATCH v7 2/4] block: add runtime pm helpers Aaron Lu
2013-01-16 9:02 ` [PATCH v7 3/4] block: implement runtime pm strategy Aaron Lu
2013-01-16 15:30 ` Alan Stern
2013-01-16 15:30 ` Alan Stern
2013-01-17 5:13 ` Aaron Lu
2013-01-17 15:11 ` Alan Stern
2013-01-17 15:11 ` Alan Stern
2013-01-18 8:27 ` Aaron Lu
2013-01-18 15:26 ` Alan Stern
2013-01-18 15:26 ` Alan Stern
2013-01-19 6:24 ` Aaron Lu
2013-01-19 18:11 ` Alan Stern
2013-01-19 18:11 ` Alan Stern
2013-01-28 9:21 ` Aaron Lu
2013-01-28 15:11 ` Alan Stern
2013-01-17 6:31 ` Aaron Lu
2013-01-16 9:02 ` [PATCH v7 4/4] sd: change to auto suspend mode Aaron Lu
2013-01-18 21:25 ` Alan Stern
2013-01-18 21:25 ` Alan Stern
2013-01-21 12:44 ` Aaron Lu
2013-01-28 8:56 ` Aaron Lu
2013-01-28 15:12 ` Alan Stern [this message]
2013-01-28 15:12 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1301281011570.1997-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=James.Bottomley@hansenpartnership.com \
--cc=aaron.lu@intel.com \
--cc=aaron.lwe@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shane.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.